[jira] [Comment Edited] (IGNITE-12472) Checkstyle rule "NewlineAtEndOfFile" is broken on Windows systems.

["Maxim Muzafarov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-12472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039339#comment-17039339 ] 

Maxim Muzafarov edited comment on IGNITE-12472 at 2/18/20 6:36 PM:
-------------------------------------------------------------------

[~agura]

Thank you, Andrey. The RP merged to the master branch.

Built successfully.
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=pull%2F7174%2Fhead


was (Author: mmuzaf):
[~agura]

Thank you, Andrey. The RP merged to the master branch.

Builded successfully.
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_BuildApacheIgnite&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=pull%2F7174%2Fhead

> Checkstyle rule "NewlineAtEndOfFile" is broken on Windows systems.
> ------------------------------------------------------------------
>
>                 Key: IGNITE-12472
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12472
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Andrey N. Gura
>            Assignee: Andrey N. Gura
>            Priority: Major
>             Fix For: 2.9
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Checkstyle rule "NewlineAtEndOfFile" uses OS EOL character.
> https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> It could be fixed by explicit configuration of LF as EOL. Checked on TC, there are no checkstyle related failures. Also checked on Windows locally. Also there are no problems.
> Problems are possible for Windows user in case of invalid Git configuration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)