You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@solr.apache.org by David Smiley <ds...@apache.org> on 2022/01/12 04:34:58 UTC

Fails: PackageManagerCLITest

org.apache.solr.cloud.PackageManagerCLITest
Is usually failing:
http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager
Based on a quick, look, it seems that the package manager is calling
System.exit, which isn't allowed by the Lucene's test SecurityManager that
we're using.  The relevant code was recently touched by Jan but the
System.exit's have been there for a while.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley

Re: Fails: PackageManagerCLITest

Posted by Houston Putman <ho...@apache.org>.

Hey David,

The errors should disappear now that
https://issues.apache.org/jira/browse/SOLR-15902 is in.

Note that this was caused partially by a buggy semver library
mis-calculating version expressions (branch_9x), but also the versions were
hardcoded so that when main upgraded to 10.0.0, it no longer passed on main
either.

There is a separate ticket to tackle the semver issues (
https://issues.apache.org/jira/browse/SOLR-15910) , but I think the tests
should start passing now.

- Houston

On Tue, Jan 11, 2022 at 11:35 PM David Smiley <ds...@apache.org> wrote:

> org.apache.solr.cloud.PackageManagerCLITest
> Is usually failing:
> http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager
> Based on a quick, look, it seems that the package manager is calling
> System.exit, which isn't allowed by the Lucene's test SecurityManager that
> we're using.  The relevant code was recently touched by Jan but the
> System.exit's have been there for a while.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>

Re: Fails: PackageManagerCLITest

Posted by Houston Putman <ho...@apache.org>.

Reopened the issue, because the tests are in fact not fixed yet. Working on
it now.

On Wed, Jan 12, 2022 at 11:07 AM Jan Høydahl <jh...@cominvent.com> wrote:

> Hi,
>
> Yes, I touched the part checking version constraint, and added the check
> for invalid SemVer expression syntax when adding SolrVersion class.
> Earlier an invalid expression in a package manifest would print "Version
> incompatible!..." and exit. After the change it will print "Error in
> version constraint given in package manifest" and exit. So end game would
> be the same.
>
> I believe that PackageManager is only ever invoked from CLI. But when
> invoked from a test, the System.exit is dubious.
>
> Jan
>
> 12. jan. 2022 kl. 05:34 skrev David Smiley <ds...@apache.org>:
>
> org.apache.solr.cloud.PackageManagerCLITest
> Is usually failing:
> http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager
> Based on a quick, look, it seems that the package manager is calling
> System.exit, which isn't allowed by the Lucene's test SecurityManager that
> we're using.  The relevant code was recently touched by Jan but the
> System.exit's have been there for a while.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
>

Re: Fails: PackageManagerCLITest

Posted by Jan Høydahl <jh...@cominvent.com>.

Hi,

Yes, I touched the part checking version constraint, and added the check for invalid SemVer expression syntax when adding SolrVersion class.
Earlier an invalid expression in a package manifest would print "Version incompatible!..." and exit. After the change it will print "Error in version constraint given in package manifest" and exit. So end game would be the same.

I believe that PackageManager is only ever invoked from CLI. But when invoked from a test, the System.exit is dubious.

Jan

> 12. jan. 2022 kl. 05:34 skrev David Smiley <ds...@apache.org>:
> 
> org.apache.solr.cloud.PackageManagerCLITest
> Is usually failing: http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager <http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.PackageManagerCLITest.testPackageManager>
> Based on a quick, look, it seems that the package manager is calling System.exit, which isn't allowed by the Lucene's test SecurityManager that we're using.  The relevant code was recently touched by Jan but the System.exit's have been there for a while.
> 
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley <http://www.linkedin.com/in/davidwsmiley>