You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/09 13:47:00 UTC

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8947: [thumbnails] thumbnails for dashboards and charts

dpgaspar commented on a change in pull request #8947: [thumbnails] thumbnails for dashboards and charts
URL: https://github.com/apache/incubator-superset/pull/8947#discussion_r406216224
 
 

 ##########
 File path: superset/charts/api.py
 ##########
 @@ -39,9 +41,12 @@
     ChartPostSchema,
     ChartPutSchema,
     get_delete_ids_schema,
+    thumbnail_query_schema,
 )
 from superset.constants import RouteMethod
 from superset.models.slice import Slice
+from superset.tasks.thumbnails import cache_chart_thumbnail
+from superset.utils.selenium import ChartScreenshot
 
 Review comment:
   Totally agree 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org