[incubator-eventmesh] branch master updated: update doc

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new f7fecfe1 update doc
     new 7c693ded Merge pull request #2075 from LIU-WEI-git/update_doc
f7fecfe1 is described below

commit f7fecfe11073eaaea30016213d05a62f76a174ea
Author: Timcross-WEI <ti...@qq.com>
AuthorDate: Wed Nov 2 19:13:33 2022 +0800

    update doc
---
 eventmesh-connector-plugin/eventmesh-connector-pravega/README.md     | 2 +-
 .../org/apache/eventmesh/connector/pravega/client/PravegaClient.java | 1 -
 .../connector/pravega/config/PravegaConnectorConfigWrapper.java      | 5 ++---
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/eventmesh-connector-plugin/eventmesh-connector-pravega/README.md b/eventmesh-connector-plugin/eventmesh-connector-pravega/README.md
index 34b19ae2..6182a5df 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-pravega/README.md
+++ b/eventmesh-connector-plugin/eventmesh-connector-pravega/README.md
@@ -10,7 +10,7 @@ Naturally, Pravega connector makes each topic correspond to a pravega stream. Be
 - Publish success will respond `-1` as messageId since writing to Pravega will not return message offset of the stream. If you want to use EventMesh with Pravega, please ensure messageId is unimportant.
 - Name and ID in Pravega must be `0-9`, `A-Z`, `a-z`, `.`, `-`.
   - Topic must be legal in Pravega.
-  - ReaderGroup name format is `String.format("%s-%s", consumerGroup, topic)`
+  - ReaderGroup name format is `String.format("%s-%s", consumerGroup, topic)` for cluster message model, while random UUID for broadcast message model.
   - Reader name format is `String.format("%s-reader", instanceName).replaceAll("\\(", "-").replaceAll("\\)", "-")`. The `instanceName` consists of `consumerGroup`, config `eventMesh.server.cluster`, EventMesh version and PID. 
 
 ![pravega-connector](./pravega-connector.jpg)
diff --git a/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/client/PravegaClient.java b/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/client/PravegaClient.java
index aeb8d778..c585845d 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/client/PravegaClient.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/client/PravegaClient.java
@@ -153,7 +153,6 @@ public class PravegaClient {
             deleteReaderGroup(buildReaderGroupName(false, consumerGroup, topic));
         }
         subscribeTaskMap.remove(topic).stopRead();
-        writerMap.remove(topic).close();
         return true;
     }
 
diff --git a/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/config/PravegaConnectorConfigWrapper.java b/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/config/PravegaConnectorConfigWrapper.java
index dbb7f4c6..d7c6763b 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/config/PravegaConnectorConfigWrapper.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-pravega/src/main/java/org/apache/eventmesh/connector/pravega/config/PravegaConnectorConfigWrapper.java
@@ -19,11 +19,10 @@ package org.apache.eventmesh.connector.pravega.config;
 
 import org.apache.eventmesh.common.Constants;
 import org.apache.eventmesh.common.utils.PropertiesUtils;
+
 import org.apache.commons.lang3.StringUtils;
 
-import java.io.BufferedReader;
 import java.io.File;
-import java.io.FileReader;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Properties;
@@ -47,7 +46,7 @@ public class PravegaConnectorConfigWrapper {
     }
 
     /**
-     * Load DLedger properties file from classpath and conf home.
+     * Load Pravega properties file from classpath and conf home.
      * The properties defined in conf home will override classpath.
      */
     private void loadProperties() {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org