You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/12 19:27:02 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Lunderberg opened a new pull request, #10980:
URL: https://github.com/apache/tvm/pull/10980
Previously, arith::DetectIterMap simplified the output expression by replacing iteration variables with extent==1 with their value. This prevented the return value from being used in arith::InverseAffineIterMap to solve for the variable, as it no longer existed in the returned expressions.
This commit changes arith::DetectIterMap to keep the iteration variable even if extent==1, and adds a motivating unit test that requires this updated behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #10980:
URL: https://github.com/apache/tvm/pull/10980#issuecomment-1099436408
To make the API consistent, could you also update the FFI API https://github.com/apache/tvm/blob/main/src/arith/iter_affine_map.cc#L943-L948?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10980:
URL: https://github.com/apache/tvm/pull/10980#issuecomment-1100118705
Certainly, and thank you for catching it! The FFI and the Python API have been updated to expose the `simplify_trivial_iterators` argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #10980:
URL: https://github.com/apache/tvm/pull/10980#issuecomment-1097377646
cc @spectrometerHBH @jinhongyii @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10980:
URL: https://github.com/apache/tvm/pull/10980#issuecomment-1098159658
CI confirms that there are definitely locations that rely on simplifications being performed as part of `DetectIterMap`. Taking a glance at the 24 failures, some would be short updates to the test cases, but others fail by breaking internal assumptions. I've added another commit to maintain the same default behavior of simplifying trivial iterators as part of `DetectIterMap`, but using a flag to maintain them in the output when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #10980:
URL: https://github.com/apache/tvm/pull/10980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10980: [Arith] Updated arith::DetectIterMap to keep extent=1 components
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10980:
URL: https://github.com/apache/tvm/pull/10980#issuecomment-1097134071
Following a discussion with @vinx13. All tests in `test_arith_iter_affine_map.py` and `test_transform_layout.py` pass locally. It's possible that the change to `DetectIterMap`'s simplifications will result in failures elsewhere, so I'm watching the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org