You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/29 07:54:36 UTC
[GitHub] [iotdb] krystal-xiao opened a new pull request #4653: [IOTDB-1874]Remove useless regulars and optimize formatting
krystal-xiao opened a new pull request #4653:
URL: https://github.com/apache/iotdb/pull/4653
REGULAR encoding is no longer applicable, master has been removed, but V0.12.X has not, so needs to be synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4653: [IOTDB-1874]Remove useless regulars and optimize formatting
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4653:
URL: https://github.com/apache/iotdb/pull/4653#discussion_r776195602
##########
File path: docs/UserGuide/Data-Concept/Encoding.md
##########
@@ -47,13 +47,8 @@ Currently, there are two versions of GORILLA encoding implementation, it is reco
Usage restrictions: When using GORILLA to encode INT32 data, you need to ensure that there is no data point with the value `Integer.MIN_VALUE` in the sequence. When using GORILLA to encode INT64 data, you need to ensure that there is no data point with the value `Long.MIN_VALUE` in the sequence.
-* REGULAR
-Regular data encoding is more suitable for time encoding regular sequence increasing data (e.g. the timeseries with the same time elapsed between each data point), in which case it's better than TS_2DIFF.
-
-Regular data encoding method is not suitable for the data with fluctuations (irregular data), and TS_2DIFF is recommended to deal with it.
-
-* Correspondence between data type and encoding
+Correspondence between data type and encoding
Review comment:
```suggestion
## Correspondence between data type and encoding
```
##########
File path: docs/zh/UserGuide/Data-Concept/Encoding.md
##########
@@ -47,13 +47,8 @@ GORILLA编码是一种无损编码，它比较适合编码前后值比较接近
使用限制：使用Gorilla编码INT32数据时，需要保证序列中不存在值为`Integer.MIN_VALUE`的数据点；使用Gorilla编码INT64数据时，需要保证序列中不存在值为`Long.MIN_VALUE`的数据点。
-* 定频数据编码 (REGULAR)
-定频数据编码，仅适用于整型（INT32）和长整型（INT64）的时间列定频数据，且允许数据中有一些点缺失，使用此方法编码定频数据优于二阶差分编码（TS_2DIFF）。
-
-定频数据编码无法用于非定频数据，建议使用二阶差分编码（TS_2DIFF）进行处理。
-
-* 数据类型与编码的对应关系
+数据类型与编码的对应关系
Review comment:
```suggestion
## 数据类型与编码的对应关系
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4653: [IOTDB-1874]Remove useless regulars and optimize formatting
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4653:
URL: https://github.com/apache/iotdb/pull/4653#discussion_r776195883
##########
File path: docs/UserGuide/Data-Concept/Encoding.md
##########
@@ -47,13 +47,8 @@ Currently, there are two versions of GORILLA encoding implementation, it is reco
Usage restrictions: When using GORILLA to encode INT32 data, you need to ensure that there is no data point with the value `Integer.MIN_VALUE` in the sequence. When using GORILLA to encode INT64 data, you need to ensure that there is no data point with the value `Long.MIN_VALUE` in the sequence.
-* REGULAR
-Regular data encoding is more suitable for time encoding regular sequence increasing data (e.g. the timeseries with the same time elapsed between each data point), in which case it's better than TS_2DIFF.
-
-Regular data encoding method is not suitable for the data with fluctuations (irregular data), and TS_2DIFF is recommended to deal with it.
-
-* Correspondence between data type and encoding
+## Correspondence between data type and encoding
Review comment:
```suggestion
### Correspondence between data type and encoding
```
##########
File path: docs/zh/UserGuide/Data-Concept/Encoding.md
##########
@@ -47,13 +47,8 @@ GORILLA编码是一种无损编码，它比较适合编码前后值比较接近
使用限制：使用Gorilla编码INT32数据时，需要保证序列中不存在值为`Integer.MIN_VALUE`的数据点；使用Gorilla编码INT64数据时，需要保证序列中不存在值为`Long.MIN_VALUE`的数据点。
-* 定频数据编码 (REGULAR)
-定频数据编码，仅适用于整型（INT32）和长整型（INT64）的时间列定频数据，且允许数据中有一些点缺失，使用此方法编码定频数据优于二阶差分编码（TS_2DIFF）。
-
-定频数据编码无法用于非定频数据，建议使用二阶差分编码（TS_2DIFF）进行处理。
-
-* 数据类型与编码的对应关系
+## 数据类型与编码的对应关系
Review comment:
```suggestion
### 数据类型与编码的对应关系
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #4653: [To rel/0.12][IOTDB-1874]Remove useless regulars and optimize formatting
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #4653:
URL: https://github.com/apache/iotdb/pull/4653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org