You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by Todd Lipcon <to...@cloudera.com> on 2010/06/21 20:09:21 UTC

Review Request: Clean up HMaster calls to find regions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/214/
-----------------------------------------------------------

Review request for hbase and stack.


Summary
-------

Would be good to get these things out of HMaster entirely to share code with other META lookup stuff, but here's a first pass cleanup.


This addresses bug HBASE-2656.
    http://issues.apache.org/jira/browse/HBASE-2656


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/HRegionInfo.java d6f9611 
  src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4c0f392 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 66dc697 
  src/test/java/org/apache/hadoop/hbase/master/TestMaster.java a5f4d69 

Diff: http://review.hbase.org/r/214/diff


Testing
-------


Thanks,

Todd

Re: Review Request: Clean up HMaster calls to find regions

Posted by st...@duboce.net.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/214/#review259
-----------------------------------------------------------

Ship it!


+1 We can do others as we go.  Commit.  I wonder though if Pair is not constraining?  We should return all in the row.  Can do that later if proves to be the case.


src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<http://review.hbase.org/r/214/#comment1109>

    Generally useful method.  Good.


- stack


On 2010-06-21 11:09:21, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/214/
> -----------------------------------------------------------
> 
> (Updated 2010-06-21 11:09:21)
> 
> 
> Review request for hbase and stack.
> 
> 
> Summary
> -------
> 
> Would be good to get these things out of HMaster entirely to share code with other META lookup stuff, but here's a first pass cleanup.
> 
> 
> This addresses bug HBASE-2656.
>     http://issues.apache.org/jira/browse/HBASE-2656
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/HRegionInfo.java d6f9611 
>   src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4c0f392 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 66dc697 
>   src/test/java/org/apache/hadoop/hbase/master/TestMaster.java a5f4d69 
> 
> Diff: http://review.hbase.org/r/214/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>