You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/22 22:28:12 UTC

[GitHub] [incubator-superset] khtruong opened a new pull request #7347: fix: do not save colors without a color scheme

khtruong opened a new pull request #7347: fix: do not save colors without a color scheme
URL: https://github.com/apache/incubator-superset/pull/7347
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   The color mapping was saved every time whether or not a user chose a color scheme for their dashboard. We should not save a color mapping unless the user specifies a color scheme.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Tested manually
   
   ### REVIEWERS
   @betodealmeida @datability-io @xtinec 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org