You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Steve Huston <sh...@riverace.com> on 2013/06/06 04:57:29 UTC

Review Request: QMF build on Windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11665/
-----------------------------------------------------------

Review request for qpid.


Description
-------

Allow QMF to build on Windows using cmake. Resolve compile errors related to partial template specialization on Visual Studio.


This addresses bug QPID-4909.
    https://issues.apache.org/jira/browse/QPID-4909


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/CMakeLists.txt 1490097 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/Agent.cpp 1490097 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/AgentSession.cpp 1490097 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/AddressParser.h 1490097 

Diff: https://reviews.apache.org/r/11665/diff/


Testing
-------

Build.


Thanks,

Steve Huston

Re: Review Request: QMF build on Windows

Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11665/#review21518
-----------------------------------------------------------

Ship it!


This looks like an improvement.

- Ted Ross


On June 6, 2013, 2:57 a.m., Steve Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11665/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 2:57 a.m.)
> 
> 
> Review request for qpid.
> 
> 
> Description
> -------
> 
> Allow QMF to build on Windows using cmake. Resolve compile errors related to partial template specialization on Visual Studio.
> 
> 
> This addresses bug QPID-4909.
>     https://issues.apache.org/jira/browse/QPID-4909
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/CMakeLists.txt 1490097 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/Agent.cpp 1490097 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qmf/AgentSession.cpp 1490097 
>   http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/AddressParser.h 1490097 
> 
> Diff: https://reviews.apache.org/r/11665/diff/
> 
> 
> Testing
> -------
> 
> Build.
> 
> 
> Thanks,
> 
> Steve Huston
> 
>