You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Laszlo Puskas <lp...@hortonworks.com> on 2017/03/23 13:29:42 UTC
Review Request 57874: Configuration types from both the blueprint and
cluster template are validated before cluster creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-20542
https://issues.apache.org/jira/browse/AMBARI-20542
Repository: ambari
Description
-------
Problem:
When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
Previously only config types in the cluster template were considered during the validation.
Solution
All the config types are taken into account during the above validation, by calling the appropriate internal api.
Note:
A bug has also been corrected in finding valid/invalid config types.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
Diff: https://reviews.apache.org/r/57874/diff/1/
Testing
-------
Manually on local env.
Unit tests written.
Thanks,
Laszlo Puskas
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/
-----------------------------------------------------------
(Updated March 27, 2017, 11:07 a.m.)
Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
Changes
-------
Updated / fixed unit tests, removed unnecessary code.
Bugs: AMBARI-20542
https://issues.apache.org/jira/browse/AMBARI-20542
Repository: ambari
Description
-------
Problem:
When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
Previously only config types in the cluster template were considered during the validation.
Solution
All the config types are taken into account during the above validation, by calling the appropriate internal api.
Note:
A bug has also been corrected in finding valid/invalid config types.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 305c88e
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java bb10df9
Diff: https://reviews.apache.org/r/57874/diff/4/
Changes: https://reviews.apache.org/r/57874/diff/3-4/
Testing
-------
Manually on local env.
Unit tests written.
Thanks,
Laszlo Puskas
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/#review169874
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On March 23, 2017, 2:54 p.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57874/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 2:54 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20542
> https://issues.apache.org/jira/browse/AMBARI-20542
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
> Previously only config types in the cluster template were considered during the validation.
>
> Solution
> All the config types are taken into account during the above validation, by calling the appropriate internal api.
>
> Note:
> A bug has also been corrected in finding valid/invalid config types.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
>
>
> Diff: https://reviews.apache.org/r/57874/diff/3/
>
>
> Testing
> -------
>
> Manually on local env.
> Unit tests written.
>
>
> Thanks,
>
> Laszlo Puskas
>
>
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/#review169870
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 23, 2017, 9:54 a.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57874/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 9:54 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20542
> https://issues.apache.org/jira/browse/AMBARI-20542
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
> Previously only config types in the cluster template were considered during the validation.
>
> Solution
> All the config types are taken into account during the above validation, by calling the appropriate internal api.
>
> Note:
> A bug has also been corrected in finding valid/invalid config types.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
>
>
> Diff: https://reviews.apache.org/r/57874/diff/3/
>
>
> Testing
> -------
>
> Manually on local env.
> Unit tests written.
>
>
> Thanks,
>
> Laszlo Puskas
>
>
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/
-----------------------------------------------------------
(Updated March 23, 2017, 1:54 p.m.)
Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-20542
https://issues.apache.org/jira/browse/AMBARI-20542
Repository: ambari
Description
-------
Problem:
When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
Previously only config types in the cluster template were considered during the validation.
Solution
All the config types are taken into account during the above validation, by calling the appropriate internal api.
Note:
A bug has also been corrected in finding valid/invalid config types.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
Diff: https://reviews.apache.org/r/57874/diff/3/
Changes: https://reviews.apache.org/r/57874/diff/2-3/
Testing
-------
Manually on local env.
Unit tests written.
Thanks,
Laszlo Puskas
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/
-----------------------------------------------------------
(Updated March 23, 2017, 1:51 p.m.)
Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
Changes
-------
Fixed review notes.
Bugs: AMBARI-20542
https://issues.apache.org/jira/browse/AMBARI-20542
Repository: ambari
Description
-------
Problem:
When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
Previously only config types in the cluster template were considered during the validation.
Solution
All the config types are taken into account during the above validation, by calling the appropriate internal api.
Note:
A bug has also been corrected in finding valid/invalid config types.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
Diff: https://reviews.apache.org/r/57874/diff/2/
Changes: https://reviews.apache.org/r/57874/diff/1-2/
Testing
-------
Manually on local env.
Unit tests written.
Thanks,
Laszlo Puskas
Re: Review Request 57874: Configuration types from both the blueprint
and cluster template are validated before cluster creation
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57874/#review169866
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java
Line 47 (original), 47 (patched)
<https://reviews.apache.org/r/57874/#comment242576>
Please add `<>`
ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java
Line 50 (original), 50 (patched)
<https://reviews.apache.org/r/57874/#comment242577>
`== null` cannot be true here.
- Attila Doroszlai
On March 23, 2017, 2:29 p.m., Laszlo Puskas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57874/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 2:29 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20542
> https://issues.apache.org/jira/browse/AMBARI-20542
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Problem:
> When validating config types posted in the blueprint and cluster template need to be checked against config types for services in the blueprint available in the stack.
> Previously only config types in the cluster template were considered during the validation.
>
> Solution
> All the config types are taken into account during the above validation, by calling the appropriate internal api.
>
> Note:
> A bug has also been corrected in finding valid/invalid config types.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java 18d08b9
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidatorTest.java 24fa8b8
>
>
> Diff: https://reviews.apache.org/r/57874/diff/1/
>
>
> Testing
> -------
>
> Manually on local env.
> Unit tests written.
>
>
> Thanks,
>
> Laszlo Puskas
>
>