[GitHub] [iceberg] pavibhai commented on pull request #6293: Added FileIO Support for ORC Reader and Writers

[GitBox <gi...@apache.org>]

pavibhai commented on PR #6293:
URL: https://github.com/apache/iceberg/pull/6293#issuecomment-1340672765

   > I'm not a big fan of the fake filesystem approach here, mostly because i'm afraid of mocking an object like that when we don't have the full filesystem state. I feel like this patch would have us maintaining a rather large Hadoop mock.
   > 
   > Is there any chance we can convince the ORC project to allow the creation of a writer from an "java.io.OutputStream" instead of always creating its own file?
   
   Thanks for this insight. Overall I agree that this should not be our long term answer and we shall work in the ORC community to make this integration better.
   In the meantime hopefully this provides the capability and given the relative stability of the FileSystem APIs and limited exposure to just creation of the input and output streams hope this is acceptable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org