You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flex.apache.org by "Mihai Chira (JIRA)" <ji...@apache.org> on 2014/09/12 12:08:34 UTC

[jira] [Created] (FLEX-34537) Minimize duplication between HorizontalLayout and VerticalLayout classes

Mihai Chira created FLEX-34537:
----------------------------------

             Summary: Minimize duplication between HorizontalLayout and VerticalLayout classes
                 Key: FLEX-34537
                 URL: https://issues.apache.org/jira/browse/FLEX-34537
             Project: Apache Flex
          Issue Type: Bug
          Components: Spark: Layout
    Affects Versions: Apache Flex 4.13.0
            Reporter: Mihai Chira
            Priority: Minor


HorizontalLayout and VerticalLayout share most of their code and logic. The only differences are in comments and variable / function names. This introduces the risk that bugs found in one of them might not be transferred to the other one as well. Same for added features.

Their common code (around 90%) could be placed inside a common ancestor or inside a class member. I personally vote for common ancestor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)