You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/30 12:47:30 UTC
[GitHub] [airflow] potiuk opened a new pull request #12718: Improve verification of images with PIP check
potiuk opened a new pull request #12718:
URL: https://github.com/apache/airflow/pull/12718
Verification of images with PIP is done in separate jobs and
they provide useful information to committers and contributors
when the pip check fails.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735961237
BTW. once I merge this change I will also add an automated "updated to newer dependencies" behaviour whenever setup.py changes in the PR. With PIP check guarding it, we should be safe to do `pip upgrade --upgrade-strategy eager` for any PR that changes setup.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735960511
@turbaszek @kaxil @ashb @mik-laj [@mjpieters ?] -> The PR with improved PIP check is ready - and you can actually see how things will work when there is a problem with PIP check (we still have the azure problem to fix in the prod image that @ephraimbuddy is working on):
https://github.com/apache/airflow/pull/12718/checks?check_run_id=1475010204#step:4:562
I already have a couple of small improvements to add:
* adding RED error message to indicate clearly that the `pip check` output is an error and GREEN when everything is fine
* few typos
However, I would love to get some comments on the wording and instructions. I based it on my experiences with getting rid of the conflicts and how I was solving them. I think those instructions should be clear enough for the contributors and commiters on what they should do in case their change actually results in conflict so I am happy to hear any comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735961237
BTW. once I merge this change I will also add an automated "update to newer dependencies" behaviour whenever setup.py changes in the PR. With PIP check guarding it, we should be safe to do `pip upgrade --upgrade-strategy eager` for any PR that changes setup.py/setup.cfg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735820807
It's ready for review. I thnk it's really nice change that allows to focus on dep changes and explains how to fix it in case it happens..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735961237
BTW. once I merge this change I will also add an automated "updated to newer dependencies" flag whenever setup.py changes in the PR. With PIP check guarding it, we should be safe to do 'pip upgrade --upgrade-strategy eager for any PR that changes setup.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735961237
BTW. once I merge this change I will also add an automated "updated to newer dependencies" behaviour whenever setup.py changes in the PR. With PIP check guarding it, we should be safe to do `pip upgrade --upgrade-strategy eager` for any PR that changes setup.py/setup.cfg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-736076180
This is what you get now when there is a pip check error:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735961237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12718:
URL: https://github.com/apache/airflow/pull/12718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12718: Improve verification of images with PIP check
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12718:
URL: https://github.com/apache/airflow/pull/12718#issuecomment-735768153
Still draft, buit it should make it easy to handle dep changes in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org