You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/30 04:49:35 UTC
[GitHub] SteNicholas commented on a change in pull request #3116:
[CARBONDATA-3229]Validate the true/false for all boolean parameters
SteNicholas commented on a change in pull request #3116: [CARBONDATA-3229]Validate the true/false for all boolean parameters
URL: https://github.com/apache/carbondata/pull/3116#discussion_r252115526
##########
File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
##########
@@ -30,7 +30,7 @@
public static final String CARBON_OPTIONS_BAD_RECORDS_LOGGER_ENABLE =
"carbon.options.bad.records.logger.enable";
- public static String CARBON_OPTIONS_BAD_RECORDS_LOGGER_ENABLE_DEFAULT = "false";
+ public static final String CARBON_OPTIONS_BAD_RECORDS_LOGGER_ENABLE_DEFAULT = "false";
Review comment:
I didn't removed final because this origin condition is that final was removed.This need to add final to modify the variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services