[GitHub] [geode] jvarenina commented on a change in pull request #7234: GEODE-9854: Orphaned .drf file causing memory leak

[GitBox <gi...@apache.org>]

jvarenina commented on a change in pull request #7234:
URL: https://github.com/apache/geode/pull/7234#discussion_r780960053



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -7642,4 +7652,23 @@ public void sendTo(DataOutput out) throws IOException {
 
   }
 
+  /**
+   * Used to track all information's about live entries that region has in this oplog.
+   * That information is only needed until oplog is compacted. This is because compaction will
+   * clear all live entries from this oplog.
+   */
+  private static class RegionMap {
+
+    final AtomicReference<ConcurrentMap<Long, DiskRegionInfo>> regionMap =
+        new AtomicReference<>(new ConcurrentHashMap<>());
+
+    public void close() {
+      regionMap.set(null);

Review comment:
       That was one of the proposed solution, but it was changed to this current one after @dschneider-pivotal change request https://github.com/apache/geode/pull/7145#discussion_r761565133




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org