[jira] [Commented] (SLING-10586) ArtifactManager getArtifactHandler fails for remote repositories.

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375476#comment-17375476 ] 

Konrad Windszus commented on SLING-10586:
-----------------------------------------

Indeed, the check in https://github.com/apache/sling-org-apache-sling-feature/blob/3d6749494d3b5cc180aed627e207509061ad0be0/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManager.java#L383 needs to be improved, because NIO throws another exception (which is currently not ignored). However, it would be good to do the check if a URL is local or not without relying on exceptions...

> ArtifactManager getArtifactHandler fails for remote repositories.
> -----------------------------------------------------------------
>
>                 Key: SLING-10586
>                 URL: https://issues.apache.org/jira/browse/SLING-10586
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>    Affects Versions: Feature Model 1.2.26
>            Reporter: Karl Pauls
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: Feature Model 1.2.28
>
>
> After the migration to NIO, the ArtifactManager fails if repositories are configured (the default) that are not for the local disc (like e.g. maven central) and an artifact is not first found in a local repository.
> Looks like this:
> {noformat}
> #73 11.46 java.nio.file.FileSystemNotFoundException: Provider "https" not installed
> #73 11.46 	at java.base/java.nio.file.Path.of(Unknown Source)
> #73 11.46 	at java.base/java.nio.file.Paths.get(Unknown Source)
> #73 11.46 	at org.apache.sling.feature.io.artifacts.ArtifactManager$DefaultArtifactHandler.getArtifact(ArtifactManager.java:383)
> #73 11.46 	at org.apache.sling.feature.io.artifacts.ArtifactManager.getArtifactHandler(ArtifactManager.java:245)
> #73 11.46 	at org.apache.sling.feature.launcher.impl.FeatureProcessor.createApplication(FeatureProcessor.java:143)
> #73 11.46 	at org.apache.sling.feature.launcher.impl.Bootstrap.assemble(Bootstrap.java:208)
> #73 11.46 	at org.apache.sling.feature.launcher.impl.Bootstrap.run(Bootstrap.java:123)
> #73 11.46 	at org.apache.sling.feature.launcher.impl.Main.main(Main.java:402)
> {noformat}
> [~kwin], can you have a look and see if that is related to your NIO changes?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)