You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/04/14 11:17:09 UTC

[GitHub] [dubbo-go] jack15083 opened a new pull request #1157: fix registery dir cache key issue

jack15083 opened a new pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #1141
   
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#issuecomment-819445872


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1157](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a46ea43) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/474ec0ac97c7ab05a64d602a122fe0b446fb9629?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (474ec0a) will **decrease** coverage by `1.35%`.
   > The diff coverage is `61.97%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1157/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1157      +/-   ##
   ==========================================
   - Coverage   59.21%   57.86%   -1.36%     
   ==========================================
     Files         269      252      -17     
     Lines       13181    12480     -701     
   ==========================================
   - Hits         7805     7221     -584     
   + Misses       4408     4347      -61     
   + Partials      968      912      -56     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <0.00%> (ø)` | |
   | [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [141 more](https://codecov.io/gh/apache/dubbo-go/pull/1157/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2ec80b8...a46ea43](https://codecov.io/gh/apache/dubbo-go/pull/1157?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#discussion_r613723437



##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
 	return buildString
 }
 
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {
+	urlNew, _ := NewURL(c.PrimitiveURL)

Review comment:
       Why use `PrimitiveURL` instead of using `c` directly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] jack15083 commented on a change in pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Posted by GitBox <gi...@apache.org>.
jack15083 commented on a change in pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#discussion_r613732638



##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
 	return buildString
 }
 
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {
+	urlNew, _ := NewURL(c.PrimitiveURL)

Review comment:
       这里加上这一段只是为了获取通知里timestamp，因为这里的c用的旧的invoker url，看下图的逻辑，执行了common.MergeURL(url, referenceUrl) 会将新url的参数给覆盖掉，不清楚为啥要执行这一步merge
   
   ![image](https://user-images.githubusercontent.com/2142066/114810062-ea598280-9ddd-11eb-95a5-b06109b28c53.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] jack15083 commented on a change in pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Posted by GitBox <gi...@apache.org>.
jack15083 commented on a change in pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#discussion_r613732638



##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
 	return buildString
 }
 
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {
+	urlNew, _ := NewURL(c.PrimitiveURL)

Review comment:
       这里加上这一段只是为了获取通知里timestamp，因为这里的c用的旧的invoker url 的参数，看下图的逻辑，执行了common.MergeURL(url, referenceUrl) 会将新url的参数给覆盖掉，不清楚为啥要执行这一步merge
   
   ![image](https://user-images.githubusercontent.com/2142066/114810062-ea598280-9ddd-11eb-95a5-b06109b28c53.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org