You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/09/01 09:03:47 UTC

[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #37380: MINOR: [C++][Python] [Docs] clearer description of q argument of quantiles

jorisvandenbossche commented on code in PR #37380:
URL: https://github.com/apache/arrow/pull/37380#discussion_r1312775041


##########
python/pyarrow/_compute.pyx:
##########
@@ -2145,7 +2145,8 @@ class QuantileOptions(_QuantileOptions):
     Parameters
     ----------
     q : double or sequence of double, default 0.5
-        Quantiles to compute. All values must be in [0, 1].
+        Probability levels of the quantiles to compute. All values must be in

Review Comment:
   > The original t-Digest paper refers to these as quantiles [1]
   
   The proposed change here also still calls the "thing" we want to compute quantiles ("Probability levels of the quantiles to compute"), so I don't think that's in contrast with how it is worded in the quoted text. 
   
   Now, this is out of my comfort zone, so personally I am happy to follow the lead of numpy to follow the terminology used in R and julia.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org