You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/20 00:01:00 UTC
svn commit: r1696678 - in /commons/proper/bcel/trunk/src: changes/
main/java/org/apache/commons/bcel6/classfile/
Author: sebb
Date: Wed Aug 19 22:00:59 2015
New Revision: 1696678
URL: http://svn.apache.org/r1696678
Log:
BCEL-198 better support for clone/copy methods
Modified:
commons/proper/bcel/trunk/src/changes/changes.xml
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java
Modified: commons/proper/bcel/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/changes/changes.xml?rev=1696678&r1=1696677&r2=1696678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/changes/changes.xml (original)
+++ commons/proper/bcel/trunk/src/changes/changes.xml Wed Aug 19 22:00:59 2015
@@ -63,6 +63,7 @@ The <action> type attribute can be add,u
<body>
<release version="6.0" date="TBA" description="Major release with Java 7 and 8 support">
+ <action issue="BCEL-198" type="update">better support for clone/copy methods</action>
<action issue="BCEL-242" type="remove">Remove Serializable</action>
<action issue="BCEL-231" type="remove">Remove deprecated methods and classes</action>
<action issue="BCEL-110" type="remove">Problem with JAXB if the bcel classloader is used; remove the broken ClassLoader class</action>
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java?rev=1696678&r1=1696677&r2=1696678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationDefault.java Wed Aug 19 22:00:59 2015
@@ -85,7 +85,7 @@ public class AnnotationDefault extends A
@Override
public Attribute copy(ConstantPool _constant_pool) {
- throw new RuntimeException("Not implemented yet!");
+ return (AnnotationDefault) clone();
}
@Override
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java?rev=1696678&r1=1696677&r2=1696678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/EnclosingMethod.java Wed Aug 19 22:00:59 2015
@@ -64,9 +64,7 @@ public class EnclosingMethod extends Att
@Override
public Attribute copy(ConstantPool constant_pool) {
- throw new RuntimeException("Not implemented yet!");
- // is this next line sufficient?
- // return (EnclosingMethod)clone();
+ return (EnclosingMethod) clone();
}
// Accessors
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java?rev=1696678&r1=1696677&r2=1696678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotations.java Wed Aug 19 22:00:59 2015
@@ -120,7 +120,6 @@ public abstract class ParameterAnnotatio
*/
@Override
public Attribute copy( ConstantPool constant_pool ) {
- ParameterAnnotations c = (ParameterAnnotations) clone();
- return c;
+ return (ParameterAnnotations) clone();
}
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java?rev=1696678&r1=1696677&r2=1696678&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/RuntimeInvisibleAnnotations.java Wed Aug 19 22:00:59 2015
@@ -56,8 +56,7 @@ public class RuntimeInvisibleAnnotations
@Override
public Attribute copy(ConstantPool constant_pool)
{
- Annotations c = (Annotations) clone();
- return c;
+ return (Annotations) clone();
}
@Override