You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/09/10 15:42:00 UTC
[jira] [Work logged] (AMQ-9548) Add new broker mbean attributes to directly retrieve total number of queues and topics
[ https://issues.apache.org/jira/browse/AMQ-9548?focusedWorklogId=934042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934042 ]
ASF GitHub Bot logged work on AMQ-9548:
---------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/24 15:41
Start Date: 10/Sep/24 15:41
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1288:
URL: https://github.com/apache/activemq/pull/1288#discussion_r1752222333
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java:
##########
@@ -280,11 +280,21 @@ public ObjectName[] getTopics() {
return safeGetBroker().getTopicsNonSuppressed();
}
+ @Override
+ public int getTotalTopicsCount() {
+ return getTopics().length;
+ }
+
@Override
public ObjectName[] getQueues() {
return safeGetBroker().getQueuesNonSuppressed();
}
+ @Override
+ public int getTotalQueuesCount() {
+ return getQueues().length;
Review Comment:
This still calls a method that creates a new array of objects. Why not just return the value of the size from the map?
Issue Time Tracking
-------------------
Worklog Id: (was: 934042)
Time Spent: 20m (was: 10m)
> Add new broker mbean attributes to directly retrieve total number of queues and topics
> --------------------------------------------------------------------------------------
>
> Key: AMQ-9548
> URL: https://issues.apache.org/jira/browse/AMQ-9548
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: JMX
> Affects Versions: 5.18.5, 6.1.2
> Reporter: Ken Liao
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.2.0, 6.1.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now, to monitor the number of destination, the only way is to read the destinations MBean and get the total destination. However, this means reading all destination names into memory, if the user has 10K+ destination with long destination name, it will be a large amount of memory just to monitor the number of them.
> The proposal here is to add either a new MBean value or a method to obtain that data. We can also add a method to retrieve the first K destination as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact