You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "fhan688 (via GitHub)" <gi...@apache.org> on 2026/06/02 06:40:48 UTC
[PR] feat(flink): support remote partitioner for simple bucket index [hudi]
fhan688 opened a new pull request, #18897:
URL: https://github.com/apache/hudi/pull/18897
### Describe the issue this Pull Request addresses
This PR wires Flink simple bucket index writes to the existing timeline-service-backed remote partitioner path.
Today Flink simple bucket index routes records with local bucket-to-task mapping. When writer parallelism changes, bucket ownership can shift across subtasks, which can make the writer route records and load bucket file groups inconsistently. Hudi already has remote partition helper support in the timeline service and write config, but the Flink simple bucket index write pipeline does not use it.
This PR enables Flink writers to use remote bucket partition assignment when `hoodie.bucket.index.remote.partitioner.enable=true`.
### Summary and Changelog
This PR adds remote partitioner support for Flink simple bucket index.
Changes:
- Add Flink option `hoodie.bucket.index.remote.partitioner.enable`, backed by the existing core bucket remote partitioner config key.
- Add Flink option resolution logic to enable remote partitioning only for simple bucket index with embedded timeline server enabled.
- Add `BucketIndexRemotePartitioner` for Flink `partitionCustom`, using `RemotePartitionHelper` and `NumBucketsFunction`.
- Wire the remote partitioner into Flink bulk insert and streaming write bucket index pipelines.
- Make `BucketStreamWriteFunction` use remote partition assignment when deciding whether a bucket belongs to the current writer subtask.
- Propagate the Flink option into `HoodieWriteConfig`.
- Include the remote partitioner flag in `EmbeddedTimelineService` reuse identity to avoid sharing a timeline service across incompatible writer
configs.
- Add unit tests and an integration test covering the enabled remote partitioner path.
No code was copied from external sources.
### Impact
This is a user-facing Flink write feature, disabled by default.
When `hoodie.bucket.index.remote.partitioner.enable=true`, Flink simple bucket index writers use the timeline service to determine bucket-to-task assignment. This improves bucket routing consistency for simple bucket index writes, especially when writer parallelism changes.
Public API/config impact:
- Adds Flink support for `hoodie.bucket.index.remote.partitioner.enable`.
Storage format impact:
- None.
Performance impact:
- Remote partitioning introduces timeline-service lookups during bucket routing. The option is disabled by default and only applies to simple bucket index when embedded timeline server is enabled.
### Risk Level
medium
This changes Flink bucket index routing behavior when the new option is enabled. The default behavior is unchanged because the option defaults to `false`.
Risk mitigation:
- The feature is gated to simple bucket index.
- The feature requires embedded timeline server to be enabled.
- Added unit tests for option resolution, write config propagation, remote partition calculation, and Flink write client config.
- Added an integration test for Flink bucket stream writes with remote partitioner enabled.
Verification:
- `mvn -pl hudi-flink-datasource/hudi-flink -am -Dcheckstyle.skip=true -DskipITs -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false
-Dtest=TestOptionsResolver,TestStreamerUtil,TestFlinkWriteClients,TestBucketIndexRemotePartitioner test`
- `mvn -pl hudi-flink-datasource/hudi-flink -am -Dcheckstyle.skip=true -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false
-Dtest=ITTestBucketStreamWrite#testRemotePartitioner test`
### Documentation Update
Required.
The Hudi website/config documentation should be updated to describe Flink support for:
- `hoodie.bucket.index.remote.partitioner.enable`
The documentation should mention that this option applies to Flink simple bucket index writes, requires embedded timeline server, and defaults to `false`.
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610881783
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.80% +1.78%
- Complexity 28461 29180 +719
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96386 +2536
+ Misses 38529 35931 -2598
- Partials 7667 7778 +111
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <66.66%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [164 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628881419
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.27%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 49.27% -17.75%
+ Complexity 28461 16161 -12300
=============================================
Files 2520 1974 -546
Lines 140046 107795 -32251
Branches 17197 13152 -4045
=============================================
- Hits 93850 53113 -40737
- Misses 38529 49162 +10633
+ Partials 7667 5520 -2147
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <66.66%> (-16.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.91% <66.66%> (-12.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1621 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628910491
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.15% -18.86%
+ Complexity 28461 16507 -11954
=============================================
Files 2520 2021 -499
Lines 140046 112967 -27079
Branches 17197 14348 -2849
=============================================
- Hits 93850 54400 -39450
- Misses 38529 52828 +14299
+ Partials 7667 5739 -1928
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.07% <66.66%> (-17.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <66.66%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628925953
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.06%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.06% -5.95%
+ Complexity 28461 25780 -2681
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
- Hits 93850 85402 -8448
- Misses 38529 47155 +8626
+ Partials 7667 7297 -370
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.68% <66.66%> (-17.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.86% <66.66%> (-12.41%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [705 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629013239
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.68%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.68% +1.67%
- Complexity 28461 29042 +581
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96064 +2214
+ Misses 38529 36055 -2474
- Partials 7667 7735 +68
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.02% <66.66%> (-0.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <66.66%> (-0.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [245 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601233870
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.36% +1.35%
- Complexity 28461 29271 +810
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96608 +2758
+ Misses 38529 36909 -1620
- Partials 7667 7794 +127
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611845796
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.85%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 53.85% -13.16%
+ Complexity 28461 12467 -15994
=============================================
Files 2520 1435 -1085
Lines 140046 72383 -67663
Branches 17197 8304 -8893
=============================================
- Hits 93850 38982 -54868
+ Misses 38529 29884 -8645
+ Partials 7667 3517 -4150
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `73.01% <66.66%> (-13.60%)` | :arrow_down: |
... and [1864 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623149519
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35815a03f8b6932196ccc9c79312c4126ab4c229 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440)
* afce817cc343e50ab577f030bcaf42ff83f70095 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623610403
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (afce817). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (afce817) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.23% -5.78%
+ Complexity 28461 25894 -2567
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
- Hits 93850 85637 -8213
- Misses 38529 46809 +8280
+ Partials 7667 7405 -262
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.67% <66.66%> (-17.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <66.66%> (-12.59%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [683 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623723989
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29089 +628
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96187 +2337
+ Misses 38529 35890 -2639
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.25% <66.66%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <66.66%> (-0.06%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [203 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623668407
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.51%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.51% +1.50%
- Complexity 28461 28948 +487
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 95822 +1972
+ Misses 38529 36279 -2250
- Partials 7667 7750 +83
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <66.66%> (-0.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <66.66%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [261 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4618662080
> This makes the routing side and bucket-loading side use the same remote assignment source, instead of maintaining separate local assignment calculations.
The motive for remote partitioner is to resolve data skew since it has the global view of assignment, does the change in this PR also addreses the similiar issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610174170
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e386c2ac9deee077a3e26dc1b93ca61f514519c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408)
* 3c0b2ea83622cfe9917a084684a0fbfe54982031 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610773863
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.51%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.51% +1.49%
- Complexity 28461 29013 +552
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 95982 +2132
+ Misses 38529 36352 -2177
- Partials 7667 7761 +94
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <66.66%> (-0.62%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [238 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610761584
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.59%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.59% +0.58%
- Complexity 28461 28602 +141
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 94703 +853
+ Misses 38529 37571 -958
- Partials 7667 7821 +154
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.47% <66.66%> (-6.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [360 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611928130
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.98%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 59.98% -7.03%
+ Complexity 28461 24503 -3958
============================================
Files 2520 2469 -51
Lines 140046 134841 -5205
Branches 17197 16001 -1196
============================================
- Hits 93850 80885 -12965
- Misses 38529 47043 +8514
+ Partials 7667 6913 -754
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <66.66%> (-16.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <66.66%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [675 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610203644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e386c2ac9deee077a3e26dc1b93ca61f514519c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408)
* 3c0b2ea83622cfe9917a084684a0fbfe54982031 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610848307
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96357 +2507
+ Misses 38529 35968 -2561
- Partials 7667 7770 +103
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.12% <66.66%> (-0.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [170 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629231245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
}, {
"hash" : "b8b51c0468e7261298b6457334478b5e5e699120",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14478",
"triggerID" : "b8b51c0468e7261298b6457334478b5e5e699120",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8b51c0468e7261298b6457334478b5e5e699120 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14478)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #18897:
URL: https://github.com/apache/hudi/pull/18897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623663367
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.71% +0.70%
- Complexity 28461 28625 +164
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 94704 +854
+ Misses 38529 37344 -1185
- Partials 7667 7803 +136
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-4.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <66.66%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [365 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623242745
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (afce817). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (afce817) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 44.77% -22.25%
+ Complexity 28461 8525 -19936
=============================================
Files 2520 1201 -1319
Lines 140046 62787 -77259
Branches 17197 6860 -10337
=============================================
- Hits 93850 28111 -65739
+ Misses 38529 31549 -6980
+ Partials 7667 3127 -4540
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `62.69% <66.66%> (-23.92%)` | :arrow_down: |
... and [2121 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599734254
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 46.15% -20.86%
+ Complexity 28461 15557 -12904
=============================================
Files 2520 1994 -526
Lines 140046 110510 -29536
Branches 17197 13769 -3428
=============================================
- Hits 93850 51005 -42845
- Misses 38529 54080 +15551
+ Partials 7667 5425 -2242
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1613 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599694725
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.90%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 53.90% -13.11%
+ Complexity 28461 12472 -15989
=============================================
Files 2520 1435 -1085
Lines 140046 72367 -67679
Branches 17197 8292 -8905
=============================================
- Hits 93850 39009 -54841
+ Misses 38529 29844 -8685
+ Partials 7667 3514 -4153
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `73.01% <66.66%> (-13.60%)` | :arrow_down: |
... and [1863 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601137594
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.83% +1.82%
- Complexity 28461 29190 +729
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96438 +2588
+ Misses 38529 35878 -2651
- Partials 7667 7775 +108
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <66.66%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [128 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601495786
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29475 +1014
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97334 +3484
+ Misses 38529 36184 -2345
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599807313
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 63.64% -3.38%
+ Complexity 28461 26974 -1487
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
- Hits 93850 89154 -4696
- Misses 38529 43562 +5033
+ Partials 7667 7375 -292
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <66.66%> (-4.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <66.66%> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [491 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601457942
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601220441
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.24%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.24% +1.23%
- Complexity 28461 29191 +730
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96439 +2589
+ Misses 38529 37098 -1431
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599913284
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29187 +726
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96421 +2571
+ Misses 38529 35894 -2635
- Partials 7667 7776 +109
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [132 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601555726
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29475 +1014
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97334 +3484
+ Misses 38529 36184 -2345
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <66.66%> (-0.46%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599746094
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.93%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.93% -18.08%
+ Complexity 28461 16444 -12017
=============================================
Files 2520 1994 -526
Lines 140046 110510 -29536
Branches 17197 13769 -3428
=============================================
- Hits 93850 54077 -39773
- Misses 38529 50786 +12257
+ Partials 7667 5647 -2020
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <66.66%> (-16.46%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1564 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601381389
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629088444
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96261 +2411
+ Misses 38529 35821 -2708
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [217 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629023720
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96257 +2407
+ Misses 38529 35824 -2705
- Partials 7667 7773 +106
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [221 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610679250
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 55.15% -11.86%
+ Complexity 28461 19509 -8952
=============================================
Files 2520 2046 -474
Lines 140046 115754 -24292
Branches 17197 14899 -2298
=============================================
- Hits 93850 63847 -30003
- Misses 38529 45222 +6693
+ Partials 7667 6685 -982
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.14% <66.66%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <66.66%> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1385 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610609361
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.85%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 53.85% -13.16%
+ Complexity 28461 12465 -15996
=============================================
Files 2520 1435 -1085
Lines 140046 72383 -67663
Branches 17197 8304 -8893
=============================================
- Hits 93850 38982 -54868
+ Misses 38529 29884 -8645
+ Partials 7667 3517 -4150
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `73.01% <66.66%> (-13.60%)` | :arrow_down: |
... and [1864 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610802780
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.69%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.69% +1.67%
- Complexity 28461 29104 +643
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96232 +2382
+ Misses 38529 36119 -2410
- Partials 7667 7744 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.09% <66.66%> (-0.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <66.66%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [184 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611738360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 44.87% -22.14%
+ Complexity 28461 8577 -19884
=============================================
Files 2520 1203 -1317
Lines 140046 62990 -77056
Branches 17197 6860 -10337
=============================================
- Hits 93850 28267 -65583
+ Misses 38529 31594 -6935
+ Partials 7667 3129 -4538
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `62.69% <66.66%> (-23.92%)` | :arrow_down: |
... and [2118 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612058040
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.65%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.65% +1.64%
- Complexity 28461 29101 +640
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96187 +2337
+ Misses 38529 36158 -2371
- Partials 7667 7752 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <66.66%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [191 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623973257
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afce817cc343e50ab577f030bcaf42ff83f70095 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610817917
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29163 +702
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96352 +2502
+ Misses 38529 35972 -2557
- Partials 7667 7771 +104
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.09% <66.66%> (-0.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [173 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623613212
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (afce817). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (afce817) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.23% -5.78%
+ Complexity 28461 25894 -2567
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
- Hits 93850 85637 -8213
- Misses 38529 46809 +8280
+ Partials 7667 7405 -262
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.67% <66.66%> (-17.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <66.66%> (-12.59%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [683 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623187840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35815a03f8b6932196ccc9c79312c4126ab4c229 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440)
* afce817cc343e50ab577f030bcaf42ff83f70095 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629027346
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96257 +2407
+ Misses 38529 35824 -2705
- Partials 7667 7773 +106
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.30% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [221 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611980110
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.18%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.18% -5.83%
+ Complexity 28461 25961 -2500
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17202 +5
============================================
- Hits 93850 85723 -8127
- Misses 38529 46946 +8417
+ Partials 7667 7428 -239
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <66.66%> (-16.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <66.66%> (-12.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [663 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612094359
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.66%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.66% +1.65%
- Complexity 28461 29107 +646
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96204 +2354
+ Misses 38529 36138 -2391
- Partials 7667 7755 +88
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <66.66%> (-0.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <66.66%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612007728
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.28%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.28% -5.73%
+ Complexity 28461 25986 -2475
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
- Hits 93850 85861 -7989
- Misses 38529 46831 +8302
+ Partials 7667 7405 -262
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.75% <66.66%> (-17.59%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <66.66%> (-12.52%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [659 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612033729
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.59%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.59% +0.57%
- Complexity 28461 28605 +144
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 94695 +845
+ Misses 38529 37592 -937
- Partials 7667 7810 +143
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.47% <66.66%> (-6.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <66.66%> (-0.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [358 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623710099
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.73%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.73% +1.72%
- Complexity 28461 29065 +604
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96132 +2282
+ Misses 38529 35950 -2579
- Partials 7667 7769 +102
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.24% <66.66%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <66.66%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [212 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623689574
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.63%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.63% +1.62%
- Complexity 28461 29005 +544
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 95988 +2138
+ Misses 38529 36126 -2403
- Partials 7667 7737 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.98% <66.66%> (-0.36%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-0.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623678144
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.54%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.54% +1.53%
- Complexity 28461 28951 +490
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 95867 +2017
+ Misses 38529 36249 -2280
- Partials 7667 7735 +68
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <66.66%> (-0.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-0.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [238 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599761670
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.38%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 58.38% -8.64%
+ Complexity 28461 24700 -3761
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
- Hits 93850 81790 -12060
- Misses 38529 51259 +12730
+ Partials 7667 7042 -625
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `86.50% <66.66%> (-0.11%)` | :arrow_down: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [606 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4600008046
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.83% +1.81%
- Complexity 28461 29189 +728
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96427 +2577
+ Misses 38529 35889 -2640
- Partials 7667 7775 +108
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.36% <66.66%> (+0.02%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [131 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3346622659
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -258,6 +258,24 @@ public static boolean isSimpleBucketIndexType(Configuration conf) {
return isBucketIndexType(conf) && getBucketEngineType(conf).equals(HoodieIndex.BucketIndexEngineType.SIMPLE);
}
+ /**
+ * Returns whether the simple bucket index should use remote partitioner.
+ */
+ public static boolean enableBucketRemotePartitioner(Configuration conf) {
+ return isSimpleBucketIndexType(conf)
+ && isBucketRemotePartitionerEnabled(conf)
+ && Boolean.parseBoolean(conf.getString(
+ HoodieWriteConfig.EMBEDDED_TIMELINE_SERVER_ENABLE.key(),
Review Comment:
Thanks for the suggestion. I accepted this and removed the dependency on `hoodie.embed.timeline.server` from the remote bucket partitioner enablement check.
I also fixed the `HoodieWriteConfig` builder order in `FlinkWriteClients` so that the call-site flag passed to `getHoodieClientConfig(...)` is applied after `withProps(...)`. This prevents user-provided DDL options from overriding the coordinator/client-side timeline service behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3346668496
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -280,17 +283,16 @@ public boolean equals(Object o) {
return false;
}
TimelineServiceIdentifier that = (TimelineServiceIdentifier) o;
- if (this.hostAddr != null && that.hostAddr != null) {
- return isMetadataEnabled == that.isMetadataEnabled && isEarlyConflictDetectionEnable == that.isEarlyConflictDetectionEnable
- && hostAddr.equals(that.hostAddr) && markerType == that.markerType;
- } else {
Review Comment:
Thanks for pointing this out. This change is not only for the new remote partitioner flag, but also fixes a latent equality/hashCode bug in `TimelineServiceIdentifier`.
Previously, when both `hostAddr` values were null, `equals` returned true without comparing the other fields. That means two identifiers with different marker type, metadata table config, early conflict detection config, or remote partitioner config could be treated as equal, while `hashCode` still included some of those fields. This could break the equals/hashCode contract and also cause the embedded timeline service to be incorrectly reused.
I removed the special if/else branch and switched to comparing all identifier fields consistently with `Objects.equals(hostAddr, that.hostAddr)`. I also added a unit test to cover the null-host case and verify all fields participate in equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360663439
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
- .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
.withEmbeddedTimelineServerReuseEnabled(true) // make write client embedded timeline service singleton
.withAllowOperationMetadataField(conf.get(FlinkOptions.CHANGELOG_ENABLED))
.withProps(flinkConf2TypedProperties(conf))
+ .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
Review Comment:
> why moving it around
Good question. The ordering is intentional: user props should still keep precedence for generic configs such as timeline server reuse and operation metadata field, while timeline server enablement is controlled by the caller. The coordinator-side client must enable it, and task-side clients must disable it. I added an inline comment to make this precedence explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628887319
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|2|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.74% -18.27%
+ Complexity 28461 16372 -12089
=============================================
Files 2520 1991 -529
Lines 140046 110241 -29805
Branches 17197 13686 -3511
=============================================
- Hits 93850 53738 -40112
- Misses 38529 50802 +12273
+ Partials 7667 5701 -1966
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <66.66%> (-16.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <66.66%> (-12.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1613 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628927255
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.28%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.28% -5.74%
+ Complexity 28461 25925 -2536
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
- Hits 93850 85703 -8147
- Misses 38529 46748 +8219
+ Partials 7667 7403 -264
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.68% <66.66%> (-17.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <66.66%> (-12.59%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [703 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628983786
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.71% +0.70%
- Complexity 28461 28628 +167
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 94702 +852
+ Misses 38529 37372 -1157
- Partials 7667 7780 +113
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-4.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <66.66%> (-0.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [389 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628987239
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.79%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.79% +0.77%
- Complexity 28461 28661 +200
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 94812 +962
+ Misses 38529 37255 -1274
- Partials 7667 7787 +120
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-4.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <66.66%> (-0.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [362 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623798378
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29089 +628
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96189 +2339
+ Misses 38529 35888 -2641
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.28% <66.66%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <66.66%> (-0.06%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [201 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360088428
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
- .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
.withEmbeddedTimelineServerReuseEnabled(true) // make write client embedded timeline service singleton
.withAllowOperationMetadataField(conf.get(FlinkOptions.CHANGELOG_ENABLED))
.withProps(flinkConf2TypedProperties(conf))
+ .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
Review Comment:
why moving it around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601195111
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.24%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.24% +1.23%
- Complexity 28461 29190 +729
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96438 +2588
+ Misses 38529 37098 -1431
- Partials 7667 7775 +108
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <66.66%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599753564
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.47%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 47.47% -19.55%
+ Complexity 28461 16652 -11809
=============================================
Files 2520 2046 -474
Lines 140046 115748 -24298
Branches 17197 14887 -2310
=============================================
- Hits 93850 54947 -38903
- Misses 38529 54979 +16450
+ Partials 7667 5822 -1845
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599881389
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.78%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.78% +1.76%
- Complexity 28461 29158 +697
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96355 +2505
+ Misses 38529 35971 -2558
- Partials 7667 7765 +98
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <66.66%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601034815
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.83% +1.82%
- Complexity 28461 29190 +729
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96436 +2586
+ Misses 38529 35881 -2648
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <66.66%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610643469
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.11%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|2|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 55.11% -11.90%
+ Complexity 28461 18623 -9838
=============================================
Files 2520 2007 -513
Lines 140046 110852 -29194
Branches 17197 13834 -3363
=============================================
- Hits 93850 61099 -32751
- Misses 38529 43461 +4932
+ Partials 7667 6292 -1375
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.54% <66.66%> (+0.27%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1453 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611991657
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.24%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.24% -5.77%
+ Complexity 28461 25977 -2484
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
- Hits 93850 85803 -8047
- Misses 38529 46882 +8353
+ Partials 7667 7412 -255
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.16% <66.66%> (-17.18%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <66.66%> (-12.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [659 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612045768
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.54%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.54% +1.53%
- Complexity 28461 29052 +591
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96029 +2179
+ Misses 38529 36326 -2203
- Partials 7667 7742 +75
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <66.66%> (-0.57%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <66.66%> (-0.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [231 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628821273
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 38.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 38.71% -28.30%
+ Complexity 28461 12378 -16083
=============================================
Files 2520 1974 -546
Lines 140046 107795 -32251
Branches 17197 13152 -4045
=============================================
- Hits 93850 41736 -52114
- Misses 38529 61046 +22517
+ Partials 7667 5013 -2654
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <66.66%> (-16.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `64.28% <66.66%> (-22.33%)` | :arrow_down: |
... and [1896 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4622997140
> > This makes the routing side and bucket-loading side use the same remote assignment source, instead of maintaining separate local assignment calculations.
>
> The motive for remote partitioner is to resolve data skew since it has the global view of assignment, does the change in this PR also addreses the similiar issue?
Yes. This PR brings the same remote bucket-to-task assignment mechanism to the Flink bucket index path. The remote partitioner keeps the partition-to-start-offset mapping centrally in the timeline service, so assignment is based on the global sequence of partition bucket ranges instead of independent local hash-based calculations.
To be precise, this helps with assignment-level skew across partition buckets. It does not rebalance record-volume skew inside a hot bucket. In this PR, both the Flink routing path and the bucket-loading path use the same remote assignment source, so they get the same skew-mitigation behavior and remain consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623883187
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29089 +628
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96189 +2339
+ Misses 38529 35888 -2641
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.28% <66.66%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.21% <66.66%> (-0.06%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [201 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360671093
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -140,7 +141,10 @@ public static DataStream<RowData> bulkInsert(Configuration conf, RowType rowType
"Consistent hashing bucket index does not work with bulk insert using FLINK engine. Use simple bucket index or Spark engine.");
}
String indexKeys = OptionsResolver.getIndexKeyField(conf);
- BucketIndexPartitioner<HoodieKey> partitioner = new BucketIndexPartitioner<>(conf, indexKeys);
+ Partitioner<HoodieKey> partitioner =
+ OptionsResolver.shouldUseBucketRemotePartitioner(conf)
Review Comment:
> can we introduce a factory class to create these partitioners?
Done. I added `BucketIndexPartitionerFactory` to centralize the local/remote simple bucket partitioner selection and updated both bulk insert and streaming simple bucket paths to use it. I also added unit coverage for both local and remote partitioner creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629052856
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96259 +2409
+ Misses 38529 35823 -2706
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.31% <66.66%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [219 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629025486
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96257 +2407
+ Misses 38529 35824 -2705
- Partials 7667 7773 +106
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [221 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629022624
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96257 +2407
+ Misses 38529 35824 -2705
- Partials 7667 7773 +106
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [221 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360062989
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -107,6 +114,11 @@ public void open(Configuration parameters) throws IOException {
this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(config);
this.numBucketsFunction = new NumBucketsFunction(config.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
config.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), config.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ this.isRemotePartitionerEnabled = OptionsResolver.shouldUseBucketRemotePartitioner(config);
Review Comment:
inline `isRemotePartitionerEnabled` and check whether `remotePartitionHelper` is null where needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628862116
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 45.15% -21.86%
+ Complexity 28461 14887 -13574
=============================================
Files 2520 1974 -546
Lines 140046 107795 -32251
Branches 17197 13152 -4045
=============================================
- Hits 93850 48677 -45173
- Misses 38529 54041 +15512
+ Partials 7667 5077 -2590
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <66.66%> (-16.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `73.01% <66.66%> (-13.60%)` | :arrow_down: |
... and [1700 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599467351
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e386c2ac9deee077a3e26dc1b93ca61f514519c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599876250
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.74% +1.72%
- Complexity 28461 29151 +690
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96301 +2451
+ Misses 38529 36036 -2493
- Partials 7667 7754 +87
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.07% <66.66%> (-0.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <66.66%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [166 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4600119025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e386c2ac9deee077a3e26dc1b93ca61f514519c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601290086
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.36% +1.35%
- Complexity 28461 29271 +810
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96608 +2758
+ Misses 38529 36909 -1620
- Partials 7667 7794 +127
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601227045
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.24%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.24% +1.23%
- Complexity 28461 29191 +730
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96441 +2591
+ Misses 38529 37096 -1433
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610734587
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 63.83% -3.18%
+ Complexity 28461 27095 -1366
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
- Hits 93850 89434 -4416
- Misses 38529 42876 +4347
- Partials 7667 7785 +118
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.75% <66.66%> (-17.59%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [452 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610777909
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.59%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.59% +1.57%
- Complexity 28461 29066 +605
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96095 +2245
+ Misses 38529 36238 -2291
- Partials 7667 7762 +95
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [227 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610936699
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.80% +1.78%
- Complexity 28461 29180 +719
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96390 +2540
+ Misses 38529 35927 -2602
- Partials 7667 7778 +111
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [163 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612170926
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.75%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96349 +2499
+ Misses 38529 35982 -2547
- Partials 7667 7766 +99
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.35% <66.66%> (+0.02%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [165 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612202790
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.80% +1.79%
- Complexity 28461 29187 +726
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96399 +2549
+ Misses 38529 35925 -2604
- Partials 7667 7773 +106
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.35% <66.66%> (+0.02%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [160 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623707153
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.69%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.69% +1.68%
- Complexity 28461 29040 +579
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96069 +2219
+ Misses 38529 36022 -2507
- Partials 7667 7760 +93
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.24% <66.66%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-0.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [224 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623697687
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.67%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.67% +1.65%
- Complexity 28461 29023 +562
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96039 +2189
+ Misses 38529 36061 -2468
- Partials 7667 7751 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.06% <66.66%> (-0.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-0.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628889506
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.90%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|2|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.90% -18.12%
+ Complexity 28461 16400 -12061
=============================================
Files 2520 1991 -529
Lines 140046 110259 -29787
Branches 17197 13778 -3419
=============================================
- Hits 93850 53917 -39933
- Misses 38529 50689 +12160
+ Partials 7667 5653 -2014
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.46% <66.66%> (-16.88%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <66.66%> (-12.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1604 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3345346471
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -258,6 +258,24 @@ public static boolean isSimpleBucketIndexType(Configuration conf) {
return isBucketIndexType(conf) && getBucketEngineType(conf).equals(HoodieIndex.BucketIndexEngineType.SIMPLE);
}
+ /**
+ * Returns whether the simple bucket index should use remote partitioner.
+ */
+ public static boolean enableBucketRemotePartitioner(Configuration conf) {
Review Comment:
🤖 nit: `enableBucketRemotePartitioner` reads as a command ("enable it") rather than a predicate, which could mislead a reader into thinking this is a side-effecting method. Could you rename it to something like `shouldUseBucketRemotePartitioner` or `isBucketRemotePartitionerActive` to make it clear it's a pure check?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+import org.apache.hudi.util.ViewStorageProperties;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Bucket index input partitioner backed by the embedded timeline service.
+ *
+ * @param <T> The type of object to hash
+ */
+public class BucketIndexRemotePartitioner<T extends HoodieKey> implements Partitioner<T> {
+
+ private final Configuration conf;
+ private final String indexKeyFields;
+ private final NumBucketsFunction numBucketsFunction;
+
+ private transient RemotePartitionHelper remotePartitionHelper;
+
+ public BucketIndexRemotePartitioner(Configuration conf, String indexKeyFields) {
+ this.conf = conf;
+ this.indexKeyFields = indexKeyFields;
+ this.numBucketsFunction = new NumBucketsFunction(conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
+ conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), conf.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ }
+
+ @Override
+ public int partition(T key, int numPartitions) {
+ String partitionPath = normalizePartitionPath(key.getPartitionPath());
+ int numBuckets = numBucketsFunction.getNumBuckets(partitionPath);
+ int curBucket = BucketIdentifier.getBucketId(key.getRecordKey(), indexKeyFields, numBuckets);
+ return getRemotePartition(getRemotePartitionHelper(), numBucketsFunction, partitionPath, curBucket, numPartitions);
+ }
+
+ public static int getRemotePartition(
+ RemotePartitionHelper remotePartitionHelper,
+ NumBucketsFunction numBucketsFunction,
+ String partitionPath,
+ int curBucket,
+ int partitionNum) {
Review Comment:
🤖 nit: `partitionNum` could be misread as "a specific partition index" rather than "total number of partitions". Could you rename it to `numPartitions` to match the Flink `Partitioner` interface's own parameter name and the instance method above?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -75,6 +77,11 @@ public class BucketStreamWriteFunction extends StreamWriteFunction {
* Functions for calculating the task partition to dispatch.
*/
private Functions.Function3<Integer, String, Integer, Integer> partitionIndexFunc;
+
+ private boolean remotePartitionerEnabled;
Review Comment:
🤖 nit: other boolean fields in this class (e.g. `isInsertOverwrite`) use the `is` prefix — could you rename this to `isRemotePartitionerEnabled` for consistency?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610108034
> > This improves bucket routing consistency for simple bucket index writes, especially when writer parallelism changes.
>
> Can you explain a bit more about this part, the record keys are routed based on bucket ids instead of tasks, even if the task parallelism changes, the same key should still route to the same bucket?
Thanks for the correction. I agree that the current local simple bucket logic keeps the key-to-bucket mapping stable. A parallelism change only affects the bucket-to-task mapping, and both `partitionCustom` and `BucketStreamWriteFunction#bootstrapIndexIfNeed` recompute that mapping with the current parallelism, so it is not accurate to say that parallelism changes cause key routing inconsistency.
I updated the motivation to be more precise: this change centralizes bucket-to-task assignment through the timeline service by reusing the existing remote partitioner capability. This makes the routing side and bucket-loading side use the same remote assignment source, instead of maintaining separate local assignment calculations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610460421
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 44.83% -22.18%
+ Complexity 28461 8565 -19896
=============================================
Files 2520 1203 -1317
Lines 140046 62990 -77056
Branches 17197 6860 -10337
=============================================
- Hits 93850 28244 -65606
+ Misses 38529 31633 -6896
+ Partials 7667 3113 -4554
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `62.69% <66.66%> (-23.92%)` | :arrow_down: |
... and [2116 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610682154
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 55.15% -11.86%
+ Complexity 28461 19509 -8952
=============================================
Files 2520 2046 -474
Lines 140046 115754 -24292
Branches 17197 14899 -2298
=============================================
- Hits 93850 63847 -30003
- Misses 38529 45222 +6693
+ Partials 7667 6685 -982
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.14% <66.66%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <66.66%> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1385 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610669966
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.12%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 55.12% -11.89%
+ Complexity 28461 19509 -8952
=============================================
Files 2520 2046 -474
Lines 140046 115754 -24292
Branches 17197 14891 -2306
=============================================
- Hits 93850 63812 -30038
- Misses 38529 45257 +6728
+ Partials 7667 6685 -982
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.44% <66.66%> (-16.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <66.66%> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1391 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610631708
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.52%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 46.52% -20.49%
+ Complexity 28461 15339 -13122
=============================================
Files 2520 1977 -543
Lines 140046 108126 -31920
Branches 17197 13181 -4016
=============================================
- Hits 93850 50308 -43542
- Misses 38529 52530 +14001
+ Partials 7667 5288 -2379
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.03% <66.66%> (-12.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1651 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610767693
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.38%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.38% +1.37%
- Complexity 28461 28926 +465
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 95804 +1954
+ Misses 38529 36520 -2009
- Partials 7667 7771 +104
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.19% <66.66%> (-3.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [260 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610819232
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29163 +702
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96352 +2502
+ Misses 38529 35972 -2557
- Partials 7667 7771 +104
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.09% <66.66%> (-0.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [173 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601437287
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601326684
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601454115
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611908368
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|2|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.80% -18.22%
+ Complexity 28461 16432 -12029
=============================================
Files 2520 1994 -526
Lines 140046 110498 -29548
Branches 17197 13690 -3507
=============================================
- Hits 93850 53926 -39924
- Misses 38529 50872 +12343
+ Partials 7667 5700 -1967
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <66.66%> (-16.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <66.66%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1593 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611998330
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.26%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.26% -5.75%
+ Complexity 28461 25977 -2484
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
- Hits 93850 85829 -8021
- Misses 38529 46860 +8331
+ Partials 7667 7408 -259
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.16% <66.66%> (-17.18%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <66.66%> (-12.52%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [659 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611178389
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c0b2ea83622cfe9917a084684a0fbfe54982031 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433)
* 35815a03f8b6932196ccc9c79312c4126ab4c229 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612146665
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.71% +1.70%
- Complexity 28461 29132 +671
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96267 +2417
+ Misses 38529 36066 -2463
- Partials 7667 7764 +97
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <66.66%> (-0.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [176 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611882913
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.51%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 46.51% -20.50%
+ Complexity 28461 15337 -13124
=============================================
Files 2520 1977 -543
Lines 140046 108052 -31994
Branches 17197 13156 -4041
=============================================
- Hits 93850 50261 -43589
- Misses 38529 52495 +13966
+ Partials 7667 5296 -2371
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <66.66%> (-12.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1649 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599733132
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 46.15% -20.86%
+ Complexity 28461 15557 -12904
=============================================
Files 2520 1994 -526
Lines 140046 110510 -29536
Branches 17197 13769 -3428
=============================================
- Hits 93850 51005 -42845
- Misses 38529 54080 +15551
+ Partials 7667 5425 -2242
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1613 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601539118
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29475 +1014
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97334 +3484
+ Misses 38529 36184 -2345
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <66.66%> (-0.46%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610895051
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.80% +1.78%
- Complexity 28461 29180 +719
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96388 +2538
+ Misses 38529 35929 -2600
- Partials 7667 7778 +111
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599899219
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.79%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.79% +1.77%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96369 +2519
+ Misses 38529 35952 -2577
- Partials 7667 7770 +103
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <66.66%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <66.66%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599895155
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.78%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.78% +1.77%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96368 +2518
+ Misses 38529 35953 -2576
- Partials 7667 7770 +103
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.30% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <66.66%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611981642
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.18%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.18% -5.83%
+ Complexity 28461 25961 -2500
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17202 +5
============================================
- Hits 93850 85723 -8127
- Misses 38529 46946 +8417
+ Partials 7667 7428 -239
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <66.66%> (-16.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <66.66%> (-12.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [663 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611984453
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.22%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|3|
>|spark-scala-tests|10|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.22% -5.79%
+ Complexity 28461 25977 -2484
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17202 +5
============================================
- Hits 93850 85773 -8077
- Misses 38529 46911 +8382
+ Partials 7667 7413 -254
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.11% <66.66%> (-17.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <66.66%> (-12.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [662 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611973369
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.46%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 62.46% -4.55%
+ Complexity 28461 25467 -2994
============================================
Files 2520 2469 -51
Lines 140046 134841 -5205
Branches 17197 16001 -1196
============================================
- Hits 93850 84234 -9616
- Misses 38529 43548 +5019
+ Partials 7667 7059 -608
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <66.66%> (-16.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <66.66%> (-12.42%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [699 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612161730
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.75%
- Complexity 28461 29163 +702
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96348 +2498
+ Misses 38529 35983 -2546
- Partials 7667 7766 +99
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [166 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4608924532
> This improves bucket routing consistency for simple bucket index writes, especially when writer parallelism changes.
Can you explain a bit more about this part, the record keys are routed based on bucket ids instead of tasks, even if the task parallelism changes, the same key should still route to the same bucket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3347375131
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
+ .withProps(flinkConf2TypedProperties(conf))
Review Comment:
Good catch. The intended precedence change is only for `hoodie.embed.timeline.server`, because Flink needs the coordinator/client write-client creation path to decide whether the embedded timeline server is started.
Moving `withProps(...)` before all three setters also changed precedence for `hoodie.embed.timeline.server.reuse.enabled` and
`hoodie.allow.operation.metadata.field`, which is broader than intended. I will narrow the change so only
`withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)` is applied after `withProps(...)`, while keeping the previous user-prop precedence for reuse and operation metadata field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599863553
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.80% +0.78%
- Complexity 28461 28749 +288
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 94983 +1133
+ Misses 38529 37323 -1206
- Partials 7667 7785 +118
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <66.66%> (-4.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <66.66%> (-0.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [305 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623718470
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.74% +1.72%
- Complexity 28461 29066 +605
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96137 +2287
+ Misses 38529 35947 -2582
- Partials 7667 7767 +100
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.25% <66.66%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <66.66%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [208 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628718285
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
}, {
"hash" : "b8b51c0468e7261298b6457334478b5e5e699120",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14478",
"triggerID" : "b8b51c0468e7261298b6457334478b5e5e699120",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afce817cc343e50ab577f030bcaf42ff83f70095 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467)
* b8b51c0468e7261298b6457334478b5e5e699120 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14478)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628917174
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.75%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 60.75% -6.26%
+ Complexity 28461 25602 -2859
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
- Hits 93850 84974 -8876
- Misses 38529 47695 +9166
+ Partials 7667 7185 -482
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.68% <66.66%> (-17.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <66.66%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [710 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628996569
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.83% +0.81%
- Complexity 28461 28673 +212
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 94865 +1015
+ Misses 38529 37197 -1332
- Partials 7667 7792 +125
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (-4.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <66.66%> (-0.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [351 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623407228
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (afce817). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (afce817) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 53.74% -13.27%
+ Complexity 28461 12410 -16051
=============================================
Files 2520 1433 -1087
Lines 140046 72175 -67871
Branches 17197 8304 -8893
=============================================
- Hits 93850 38793 -55057
+ Misses 38529 29866 -8663
+ Partials 7667 3516 -4151
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `73.01% <66.66%> (-13.60%)` | :arrow_down: |
... and [1877 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623657280
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.67%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.67% +0.65%
- Complexity 28461 28594 +133
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 94639 +789
+ Misses 38529 37431 -1098
- Partials 7667 7781 +114
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-4.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [370 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623695328
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.64% +1.63%
- Complexity 28461 29011 +550
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
+ Hits 93850 96004 +2154
+ Misses 38529 36105 -2424
- Partials 7667 7742 +75
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.01% <66.66%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <66.66%> (-0.25%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [230 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629019115
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.78%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.78% +1.76%
- Complexity 28461 29096 +635
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96194 +2344
+ Misses 38529 35899 -2630
- Partials 7667 7761 +94
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.26% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <66.66%> (-0.13%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [226 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610670999
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.12%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 55.12% -11.89%
+ Complexity 28461 19509 -8952
=============================================
Files 2520 2046 -474
Lines 140046 115754 -24292
Branches 17197 14891 -2306
=============================================
- Hits 93850 63812 -30038
- Misses 38529 45257 +6728
+ Partials 7667 6685 -982
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.44% <66.66%> (-16.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <66.66%> (-0.41%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1391 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599498709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e386c2ac9deee077a3e26dc1b93ca61f514519c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601401827
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3345467741
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -638,6 +638,14 @@ public class FlinkOptions extends HoodieConfig {
.withDescription("Users can use this parameter to specify expression and the corresponding bucket "
+ "numbers (separated by commas).Multiple rules are separated by semicolons like "
+ "hoodie.bucket.index.partition.expressions=expression1,bucket-number1;expression2,bucket-number2");
+
+ @AdvancedConfig
+ public static final ConfigOption<Boolean> BUCKET_INDEX_REMOTE_PARTITIONER_ENABLE = ConfigOptions
Review Comment:
it's unnecessary to introduce this config as a flink option, users can configure $BUCKET_PARTITIONER directly in DDL options.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -258,6 +258,24 @@ public static boolean isSimpleBucketIndexType(Configuration conf) {
return isBucketIndexType(conf) && getBucketEngineType(conf).equals(HoodieIndex.BucketIndexEngineType.SIMPLE);
}
+ /**
+ * Returns whether the simple bucket index should use remote partitioner.
+ */
+ public static boolean enableBucketRemotePartitioner(Configuration conf) {
Review Comment:
+1
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/embedded/EmbeddedTimelineService.java:
##########
@@ -280,17 +283,16 @@ public boolean equals(Object o) {
return false;
}
TimelineServiceIdentifier that = (TimelineServiceIdentifier) o;
- if (this.hostAddr != null && that.hostAddr != null) {
- return isMetadataEnabled == that.isMetadataEnabled && isEarlyConflictDetectionEnable == that.isEarlyConflictDetectionEnable
- && hostAddr.equals(that.hostAddr) && markerType == that.markerType;
- } else {
Review Comment:
can you explain a bit more about why the if else branch is removed.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -258,6 +258,24 @@ public static boolean isSimpleBucketIndexType(Configuration conf) {
return isBucketIndexType(conf) && getBucketEngineType(conf).equals(HoodieIndex.BucketIndexEngineType.SIMPLE);
}
+ /**
+ * Returns whether the simple bucket index should use remote partitioner.
+ */
+ public static boolean enableBucketRemotePartitioner(Configuration conf) {
+ return isSimpleBucketIndexType(conf)
+ && isBucketRemotePartitionerEnabled(conf)
+ && Boolean.parseBoolean(conf.getString(
+ HoodieWriteConfig.EMBEDDED_TIMELINE_SERVER_ENABLE.key(),
Review Comment:
The check for `EMBEDDED_TIMELINE_SERVER_ENABLE` is not needed, since embedded timeline server is always started in the writer coordinator and always disabled on client side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3346919808
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+import org.apache.hudi.util.ViewStorageProperties;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Bucket index input partitioner backed by the embedded timeline service.
+ *
+ * @param <T> The type of object to hash
+ */
+public class BucketIndexRemotePartitioner<T extends HoodieKey> implements Partitioner<T> {
+
+ private final Configuration conf;
+ private final String indexKeyFields;
+ private final NumBucketsFunction numBucketsFunction;
+
+ private transient RemotePartitionHelper remotePartitionHelper;
+
+ public BucketIndexRemotePartitioner(Configuration conf, String indexKeyFields) {
+ this.conf = conf;
+ this.indexKeyFields = indexKeyFields;
+ this.numBucketsFunction = new NumBucketsFunction(conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
+ conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), conf.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ }
+
+ @Override
+ public int partition(T key, int numPartitions) {
+ String partitionPath = normalizePartitionPath(key.getPartitionPath());
+ int numBuckets = numBucketsFunction.getNumBuckets(partitionPath);
+ int curBucket = BucketIdentifier.getBucketId(key.getRecordKey(), indexKeyFields, numBuckets);
+ return getRemotePartition(getRemotePartitionHelper(), numBucketsFunction, partitionPath, curBucket, numPartitions);
+ }
+
+ public static int getRemotePartition(
+ RemotePartitionHelper remotePartitionHelper,
+ NumBucketsFunction numBucketsFunction,
+ String partitionPath,
+ int curBucket,
+ int numPartitions) {
+ String normalizedPartitionPath = normalizePartitionPath(partitionPath);
+ try {
+ int partition = remotePartitionHelper.getPartition(
+ numBucketsFunction.getNumBuckets(normalizedPartitionPath),
+ normalizedPartitionPath,
+ curBucket,
+ numPartitions);
+ if (partition < 0) {
+ throw new RuntimeException(
+ "Get remote partition succeeded, but the subtask id is negative: " + partition);
+ }
+ return partition;
+ } catch (Exception e) {
Review Comment:
🤖 nit: the broad `catch (Exception e)` also catches the `RuntimeException` thrown a few lines above for the negative partition case, so the eventual stack reads as "Get remote partition failed" caused by "Get remote partition succeeded, but the subtask id is negative" — contradictory and confusing. Could you move the negative-check throw outside the try (or catch a narrower exception)? Also, consider `HoodieException` over a bare `RuntimeException`.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
+ .withProps(flinkConf2TypedProperties(conf))
Review Comment:
🤖 Moving `withProps(...)` before `withEmbeddedTimelineServerEnabled`, `withEmbeddedTimelineServerReuseEnabled`, and `withAllowOperationMetadataField` silently flips precedence: call-site flags now always override user-supplied props for all three keys. Forcing the timeline-server-enable flag is what makes the new integration test work even with `hoodie.embed.timeline.server=false`, but is the same implicit override intended for `hoodie.embed.timeline.server.reuse.enabled` and `hoodie.allow.operation.metadata.field` (via `CHANGELOG_ENABLED`)? Worth calling out as a behavior change in the PR description since it affects callers beyond just this feature.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+import org.apache.hudi.util.ViewStorageProperties;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Bucket index input partitioner backed by the embedded timeline service.
+ *
+ * @param <T> The type of object to hash
+ */
+public class BucketIndexRemotePartitioner<T extends HoodieKey> implements Partitioner<T> {
+
+ private final Configuration conf;
+ private final String indexKeyFields;
+ private final NumBucketsFunction numBucketsFunction;
+
+ private transient RemotePartitionHelper remotePartitionHelper;
+
+ public BucketIndexRemotePartitioner(Configuration conf, String indexKeyFields) {
+ this.conf = conf;
+ this.indexKeyFields = indexKeyFields;
+ this.numBucketsFunction = new NumBucketsFunction(conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
+ conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), conf.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ }
+
+ @Override
+ public int partition(T key, int numPartitions) {
+ String partitionPath = normalizePartitionPath(key.getPartitionPath());
+ int numBuckets = numBucketsFunction.getNumBuckets(partitionPath);
+ int curBucket = BucketIdentifier.getBucketId(key.getRecordKey(), indexKeyFields, numBuckets);
+ return getRemotePartition(getRemotePartitionHelper(), numBucketsFunction, partitionPath, curBucket, numPartitions);
+ }
+
+ public static int getRemotePartition(
+ RemotePartitionHelper remotePartitionHelper,
+ NumBucketsFunction numBucketsFunction,
+ String partitionPath,
+ int curBucket,
+ int numPartitions) {
+ String normalizedPartitionPath = normalizePartitionPath(partitionPath);
Review Comment:
🤖 nit: `partition()` already normalizes the path on line 54 before calling `getRemotePartition`, so this re-normalization is redundant on that path. Could you normalize once at the single entry point (the static helper) and drop it from `partition()`, or vice versa?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599870980
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.89%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.89% +0.88%
- Complexity 28461 28800 +339
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 95114 +1264
+ Misses 38529 37174 -1355
- Partials 7667 7803 +136
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.37% <66.66%> (-3.97%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <66.66%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [286 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601301287
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.87%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.87% +1.86%
- Complexity 28461 29474 +1013
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 97333 +3483
+ Misses 38529 36185 -2344
- Partials 7667 7793 +126
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.08% <68.51%> (-0.27%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.77% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [144 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610844698
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.77% +1.76%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96357 +2507
+ Misses 38529 35968 -2561
- Partials 7667 7770 +103
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.12% <66.66%> (-0.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.25% <66.66%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [170 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599752224
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.47%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|4|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 47.47% -19.55%
+ Complexity 28461 16652 -11809
=============================================
Files 2520 2046 -474
Lines 140046 115748 -24298
Branches 17197 14887 -2310
=============================================
- Hits 93850 54947 -38903
- Misses 38529 54979 +16450
+ Partials 7667 5822 -1845
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4600027248
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.83% +1.82%
- Complexity 28461 29190 +729
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96436 +2586
+ Misses 38529 35881 -2648
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <66.66%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <66.66%> (+<0.01%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599819534
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 67.71% +0.69%
- Complexity 28461 28705 +244
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 94858 +1008
+ Misses 38529 37432 -1097
- Partials 7667 7801 +134
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <66.66%> (-4.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (-0.35%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [325 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4601200855
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.24%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.24% +1.23%
- Complexity 28461 29191 +730
============================================
Files 2520 2521 +1
Lines 140046 141311 +1265
Branches 17197 17465 +268
============================================
+ Hits 93850 96439 +2589
+ Misses 38529 37098 -1431
- Partials 7667 7774 +107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <66.66%> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.23% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <66.66%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <66.66%> (-0.47%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612059796
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.65%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.65% +1.64%
- Complexity 28461 29101 +640
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96187 +2337
+ Misses 38529 36158 -2371
- Partials 7667 7752 +85
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <66.66%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [191 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612073961
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.65%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.65% +1.64%
- Complexity 28461 29101 +640
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96188 +2338
+ Misses 38529 36158 -2371
- Partials 7667 7751 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <66.66%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [190 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611709106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35815a03f8b6932196ccc9c79312c4126ab4c229 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3348433314
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/partitioner/TestBucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+
+import org.apache.flink.configuration.Configuration;
+import org.junit.jupiter.api.Test;
+
+import java.lang.reflect.Field;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+/**
+ * Test cases for {@link BucketIndexRemotePartitioner}.
+ */
+class TestBucketIndexRemotePartitioner {
+
+ @Test
+ void testGetRemotePartitionDelegatesWithNormalizedPartitionPath() throws Exception {
+ RemotePartitionHelper remotePartitionHelper = mock(RemotePartitionHelper.class);
+ NumBucketsFunction numBucketsFunction = new NumBucketsFunction(8);
+
+ when(remotePartitionHelper.getPartition(8, "", 2, 10)).thenReturn(5);
+
+ int partition = BucketIndexRemotePartitioner.getRemotePartition(
+ remotePartitionHelper, numBucketsFunction, null, 2, 10);
+
+ assertEquals(5, partition);
+ verify(remotePartitionHelper).getPartition(8, "", 2, 10);
+ }
+
+ @Test
+ void testGetRemotePartitionWrapsRemoteFailure() throws Exception {
+ RemotePartitionHelper remotePartitionHelper = mock(RemotePartitionHelper.class);
+ NumBucketsFunction numBucketsFunction = new NumBucketsFunction(4);
+
+ when(remotePartitionHelper.getPartition(4, "par1", 1, 6)).thenThrow(new Exception("remote unavailable"));
+
+ HoodieException error = assertThrows(HoodieException.class, () ->
+ BucketIndexRemotePartitioner.getRemotePartition(remotePartitionHelper, numBucketsFunction, "par1", 1, 6));
+
+ assertEquals("Get remote partition failed.", error.getMessage());
+ assertEquals("remote unavailable", error.getCause().getMessage());
+ }
+
+ @Test
+ void testGetRemotePartitionRejectsNegativePartition() throws Exception {
+ RemotePartitionHelper remotePartitionHelper = mock(RemotePartitionHelper.class);
+ NumBucketsFunction numBucketsFunction = new NumBucketsFunction(4);
+
+ when(remotePartitionHelper.getPartition(4, "par1", 1, 6)).thenReturn(-1);
+
+ HoodieException error = assertThrows(HoodieException.class, () ->
+ BucketIndexRemotePartitioner.getRemotePartition(remotePartitionHelper, numBucketsFunction, "par1", 1, 6));
+
+ assertEquals("Get remote partition succeeded, but the subtask id is negative: -1", error.getMessage());
+ }
+
+ @Test
+ void testPartitionUsesRemotePartition() throws Exception {
+ Configuration conf = new Configuration();
+ conf.set(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS, 8);
+ RemotePartitionHelper remotePartitionHelper = mock(RemotePartitionHelper.class);
+ HoodieKey key = new HoodieKey("id1", null);
+ int currentBucket = BucketIdentifier.getBucketId(key.getRecordKey(), "id", 8);
+
+ when(remotePartitionHelper.getPartition(8, "", currentBucket, 16)).thenReturn(11);
+
+ BucketIndexRemotePartitioner<HoodieKey> partitioner = new BucketIndexRemotePartitioner<>(conf, "id");
+ setRemotePartitionHelper(partitioner, remotePartitionHelper);
+
+ assertEquals(11, partitioner.partition(key, 16));
+ }
+
+ private void setRemotePartitionHelper(
+ BucketIndexRemotePartitioner<HoodieKey> partitioner,
Review Comment:
🤖 nit: using reflection to inject the mock is brittle — could `remotePartitionHelper` be exposed via a package-private setter or test-only constructor so the test doesn't need `setAccessible(true)`?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+import org.apache.hudi.util.ViewStorageProperties;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Bucket index input partitioner backed by the embedded timeline service.
+ *
+ * @param <T> The type of object to hash
+ */
Review Comment:
🤖 nit: the javadoc says `@param <T> The type of object to hash`, but `T` is bounded to `HoodieKey` and the class doesn't really hash — could you reword this (e.g. "the key type to partition by") to avoid confusion?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/BucketIndexRemotePartitioner.java:
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.partitioner;
+
+import org.apache.hudi.common.model.HoodieKey;
+import org.apache.hudi.common.table.view.FileSystemViewStorageConfig;
+import org.apache.hudi.common.util.RemotePartitionHelper;
+import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.index.bucket.BucketIdentifier;
+import org.apache.hudi.index.bucket.partition.NumBucketsFunction;
+import org.apache.hudi.util.ViewStorageProperties;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.configuration.Configuration;
+
+/**
+ * Bucket index input partitioner backed by the embedded timeline service.
+ *
+ * @param <T> The type of object to hash
+ */
+public class BucketIndexRemotePartitioner<T extends HoodieKey> implements Partitioner<T> {
+
+ private final Configuration conf;
+ private final String indexKeyFields;
+ private final NumBucketsFunction numBucketsFunction;
+
+ private transient RemotePartitionHelper remotePartitionHelper;
+
+ public BucketIndexRemotePartitioner(Configuration conf, String indexKeyFields) {
+ this.conf = conf;
+ this.indexKeyFields = indexKeyFields;
+ this.numBucketsFunction = new NumBucketsFunction(conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
+ conf.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), conf.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ }
+
+ @Override
+ public int partition(T key, int numPartitions) {
+ String partitionPath = normalizePartitionPath(key.getPartitionPath());
+ int numBuckets = numBucketsFunction.getNumBuckets(partitionPath);
Review Comment:
🤖 nit: the two `getRemotePartition` overloads have very similar signatures (one takes `NumBucketsFunction`, the other `int numBuckets`) — could the private one be renamed (e.g. `doGetRemotePartition`) to make it obvious at call sites which is which?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611144964
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c0b2ea83622cfe9917a084684a0fbfe54982031 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433)
* 35815a03f8b6932196ccc9c79312c4126ab4c229 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611004489
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3c0b2ea83622cfe9917a084684a0fbfe54982031 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612152971
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.71%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.71% +1.70%
- Complexity 28461 29132 +671
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96269 +2419
+ Misses 38529 36064 -2465
- Partials 7667 7764 +97
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <66.66%> (-0.26%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [174 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360657211
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -107,6 +114,11 @@ public void open(Configuration parameters) throws IOException {
this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(config);
this.numBucketsFunction = new NumBucketsFunction(config.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
config.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), config.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ this.isRemotePartitionerEnabled = OptionsResolver.shouldUseBucketRemotePartitioner(config);
Review Comment:
> inline `isRemotePartitionerEnabled` and check whether `remotePartitionHelper` is null where needed.
Done. I removed the separate `isRemotePartitionerEnabled` flag and now use `remotePartitionHelper != null` as the single source of truth. This avoids keeping two pieces of state for the same condition while preserving the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360090011
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -140,7 +141,10 @@ public static DataStream<RowData> bulkInsert(Configuration conf, RowType rowType
"Consistent hashing bucket index does not work with bulk insert using FLINK engine. Use simple bucket index or Spark engine.");
}
String indexKeys = OptionsResolver.getIndexKeyField(conf);
- BucketIndexPartitioner<HoodieKey> partitioner = new BucketIndexPartitioner<>(conf, indexKeys);
+ Partitioner<HoodieKey> partitioner =
+ OptionsResolver.shouldUseBucketRemotePartitioner(conf)
Review Comment:
can we introduce a factory class to create these partitioners?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628741942
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.76%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 44.76% -22.25%
+ Complexity 28461 8523 -19938
=============================================
Files 2520 1201 -1319
Lines 140046 62783 -77263
Branches 17197 6859 -10338
=============================================
- Hits 93850 28107 -65743
+ Misses 38529 31549 -6980
+ Partials 7667 3127 -4540
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `62.69% <66.66%> (-23.92%)` | :arrow_down: |
... and [2121 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628981700
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.85%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 65.85% -1.16%
+ Complexity 28461 27857 -604
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
- Hits 93850 92100 -1750
- Misses 38529 39914 +1385
- Partials 7667 7840 +173
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.68% <66.66%> (-17.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.88% <66.66%> (-0.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [543 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599545284
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.91%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 44.91% -22.10%
+ Complexity 28461 8579 -19882
=============================================
Files 2520 1203 -1317
Lines 140046 62992 -77054
Branches 17197 6852 -10345
=============================================
- Hits 93850 28296 -65554
+ Misses 38529 31568 -6961
+ Partials 7667 3128 -4539
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `62.69% <66.66%> (-23.92%)` | :arrow_down: |
... and [2117 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599719859
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.53%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 46.53% -20.49%
+ Complexity 28461 15342 -13119
=============================================
Files 2520 1977 -543
Lines 140046 108046 -32000
Branches 17197 13144 -4053
=============================================
- Hits 93850 50275 -43575
- Misses 38529 52482 +13953
+ Partials 7667 5289 -2378
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <66.66%> (-12.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1632 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599790461
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.30%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 61.30% -5.71%
+ Complexity 28461 25986 -2475
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
- Hits 93850 85884 -7966
- Misses 38529 46799 +8270
+ Partials 7667 7408 -259
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <66.66%> (-12.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `86.50% <66.66%> (-0.11%)` | :arrow_down: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [637 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599765661
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.38%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 58.38% -8.64%
+ Complexity 28461 24700 -3761
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
- Hits 93850 81790 -12060
- Misses 38529 51259 +12730
+ Partials 7667 7042 -625
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `86.50% <66.66%> (-0.11%)` | :arrow_down: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [606 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599776935
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.78%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (4e386c2). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (4e386c2) |
>|------|------|------|
>|spark-java-tests|14|5|
>|spark-scala-tests|10|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 60.78% -6.23%
+ Complexity 28461 25663 -2798
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
- Hits 93850 85154 -8696
- Misses 38529 47746 +9217
+ Partials 7667 7191 -476
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <66.66%> (-17.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <66.66%> (-12.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `86.50% <66.66%> (-0.11%)` | :arrow_down: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [645 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599878424
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.76% +1.74%
- Complexity 28461 29151 +690
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96331 +2481
+ Misses 38529 36006 -2523
- Partials 7667 7754 +87
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.07% <66.66%> (-0.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <66.66%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [146 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4599902360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.51852%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.79%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4e386c2`](https://app.codecov.io/gh/apache/hudi/commit/4e386c2ac9deee077a3e26dc1b93ca61f514519c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.79% +1.77%
- Complexity 28461 29164 +703
============================================
Files 2520 2521 +1
Lines 140046 140091 +45
Branches 17197 17199 +2
============================================
+ Hits 93850 96371 +2521
+ Misses 38529 35951 -2578
- Partials 7667 7769 +102
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <68.51%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.22% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <66.66%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <66.66%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.42% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.53% <100.00%> (+1.63%)` | :arrow_up: |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.09% <66.66%> (+1.48%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [137 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 closed pull request #18897: feat(flink): support remote partitioner for simple bucket index
URL: https://github.com/apache/hudi/pull/18897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "fhan688 (via GitHub)" <gi...@apache.org>.
fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360657211
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -107,6 +114,11 @@ public void open(Configuration parameters) throws IOException {
this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(config);
this.numBucketsFunction = new NumBucketsFunction(config.get(FlinkOptions.BUCKET_INDEX_PARTITION_EXPRESSIONS),
config.get(FlinkOptions.BUCKET_INDEX_PARTITION_RULE), config.get(FlinkOptions.BUCKET_INDEX_NUM_BUCKETS));
+ this.isRemotePartitionerEnabled = OptionsResolver.shouldUseBucketRemotePartitioner(config);
Review Comment:
> inline `isRemotePartitionerEnabled` and check whether `remotePartitionHelper` is null where needed.
Done. I removed the separate isRemotePartitionerEnabled flag and now use remotePartitionHelper != null as the single source of truth. This avoids keeping two pieces of state for the same condition while preserving the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628999982
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.60%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.60% +1.58%
- Complexity 28461 28987 +526
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 95940 +2090
+ Misses 38529 36180 -2349
- Partials 7667 7734 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <66.66%> (-0.63%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <66.66%> (-0.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [256 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628696678
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14408",
"triggerID" : "4e386c2ac9deee077a3e26dc1b93ca61f514519c",
"triggerType" : "PUSH"
}, {
"hash" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14433",
"triggerID" : "3c0b2ea83622cfe9917a084684a0fbfe54982031",
"triggerType" : "PUSH"
}, {
"hash" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14440",
"triggerID" : "35815a03f8b6932196ccc9c79312c4126ab4c229",
"triggerType" : "PUSH"
}, {
"hash" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467",
"triggerID" : "afce817cc343e50ab577f030bcaf42ff83f70095",
"triggerType" : "PUSH"
}, {
"hash" : "b8b51c0468e7261298b6457334478b5e5e699120",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b8b51c0468e7261298b6457334478b5e5e699120",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afce817cc343e50ab577f030bcaf42ff83f70095 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=14467)
* b8b51c0468e7261298b6457334478b5e5e699120 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4628898063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.15%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (b8b51c0). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (b8b51c0) |
>|------|------|------|
>|spark-java-tests|14|3|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 48.15% -18.86%
+ Complexity 28461 16507 -11954
=============================================
Files 2520 2021 -499
Lines 140046 112967 -27079
Branches 17197 14348 -2849
=============================================
- Hits 93850 54399 -39451
- Misses 38529 52828 +14299
+ Partials 7667 5740 -1927
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.07% <66.66%> (-17.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.87% <66.66%> (-12.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4623654377
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.80%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`afce817`](https://app.codecov.io/gh/apache/hudi/commit/afce817cc343e50ab577f030bcaf42ff83f70095?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 65.80% -1.21%
+ Complexity 28461 27820 -641
============================================
Files 2520 2518 -2
Lines 140046 139851 -195
Branches 17197 17214 +17
============================================
- Hits 93850 92034 -1816
- Misses 38529 39975 +1446
- Partials 7667 7842 +175
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.27% <70.37%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.67% <66.66%> (-17.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.30% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `73.71% <100.00%> (+0.81%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [523 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4629077012
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.36364%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b8b51c0`](https://app.codecov.io/gh/apache/hudi/commit/b8b51c0468e7261298b6457334478b5e5e699120?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 86.20% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.82% +1.81%
- Complexity 28461 29125 +664
============================================
Files 2520 2519 -1
Lines 140046 139854 -192
Branches 17197 17203 +6
============================================
+ Hits 93850 96261 +2411
+ Misses 38529 35821 -2708
- Partials 7667 7772 +105
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.53% <76.36%> (+0.18%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.76% <66.66%> (-0.15%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.04% <66.66%> (-0.19%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <66.66%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.22% <66.66%> (-0.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.28% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `76.02% <100.00%> (+3.12%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...ink/partitioner/BucketIndexPartitionerFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexPartitionerFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFBhcnRpdGlvbmVyRmFjdG9yeS5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `15.24% <0.00%> (+0.06%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `86.20% <86.20%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.18% <0.00%> (-5.59%)` | :arrow_down: |
... and [217 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610751501
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.83%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 65.83% -1.18%
+ Complexity 28461 27907 -554
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
- Hits 93850 92231 -1619
- Misses 38529 39995 +1466
- Partials 7667 7869 +202
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.75% <66.66%> (-17.59%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <66.66%> (-0.37%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [500 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612026359
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.52%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 63.52% -3.50%
+ Complexity 28461 26870 -1591
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
- Hits 93850 88992 -4858
- Misses 38529 43709 +5180
+ Partials 7667 7396 -271
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.47% <66.66%> (-6.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.75% <66.66%> (-12.52%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [526 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610664516
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.74%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (3c0b2ea). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (3c0b2ea) |
>|------|------|------|
>|spark-java-tests|14|2|
>|spark-scala-tests|10|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 54.74% -12.27%
+ Complexity 28461 19311 -9150
=============================================
Files 2520 2046 -474
Lines 140046 115754 -24292
Branches 17197 14891 -2306
=============================================
- Hits 93850 63373 -30477
- Misses 38529 45812 +7283
+ Partials 7667 6569 -1098
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.44% <66.66%> (-16.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <66.66%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1397 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610781896
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.64%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.64% +1.63%
- Complexity 28461 29092 +631
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96167 +2317
+ Misses 38529 36161 -2368
- Partials 7667 7767 +100
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <66.66%> (-0.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [208 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4610788883
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.34694%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.67%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3c0b2ea`](https://app.codecov.io/gh/apache/hudi/commit/3c0b2ea83622cfe9917a084684a0fbfe54982031?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 83.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.67% +1.65%
- Complexity 28461 29099 +638
============================================
Files 2520 2521 +1
Lines 140046 140095 +49
Branches 17197 17210 +13
============================================
+ Hits 93850 96205 +2355
+ Misses 38529 36148 -2381
- Partials 7667 7742 +75
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <67.34%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <66.66%> (-0.08%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <66.66%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <66.66%> (-0.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <66.66%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `83.33% <83.33%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [186 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612048910
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.54%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.54% +1.53%
- Complexity 28461 29052 +591
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96029 +2179
+ Misses 38529 36326 -2203
- Partials 7667 7742 +75
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <66.66%> (-0.57%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <66.66%> (-0.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [231 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4612088936
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.66%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
+ Coverage 67.01% 68.66% +1.65%
- Complexity 28461 29107 +646
============================================
Files 2520 2521 +1
Lines 140046 140097 +51
Branches 17197 17210 +13
============================================
+ Hits 93850 96201 +2351
+ Misses 38529 36140 -2389
- Partials 7667 7756 +89
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.05% <66.66%> (-0.29%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <66.66%> (-0.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.38% <66.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `88.88% <83.33%> (+2.27%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [190 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611910570
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.62745%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.94%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 16.66% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | 84.61% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
============================================
- Coverage 67.01% 59.94% -7.07%
+ Complexity 28461 24487 -3974
============================================
Files 2520 2469 -51
Lines 140046 134841 -5205
Branches 17197 16001 -1196
============================================
- Hits 93850 80835 -13015
- Misses 38529 47089 +8560
+ Partials 7667 6917 -750
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.33% <68.62%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <66.66%> (-16.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.84% <66.66%> (-12.42%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/hudi/configuration/FlinkOptions.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FFlinkOptions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9GbGlua09wdGlvbnMuamF2YQ==) | `99.78% <ø> (ø)` | |
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `74.37% <100.00%> (+1.47%)` | :arrow_up: |
| [...n/java/org/apache/hudi/util/FlinkWriteClients.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkWriteClients.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1dyaXRlQ2xpZW50cy5qYXZh) | `96.09% <100.00%> (ø)` | |
| [...c/main/java/org/apache/hudi/util/StreamerUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FStreamerUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9TdHJlYW1lclV0aWwuamF2YQ==) | `66.92% <100.00%> (+0.08%)` | :arrow_up: |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `87.30% <83.33%> (+0.68%)` | :arrow_up: |
| [...sink/partitioner/BucketIndexRemotePartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketIndexRemotePartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRJbmRleFJlbW90ZVBhcnRpdGlvbmVyLmphdmE=) | `84.61% <84.61%> (ø)` | |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | `68.65% <16.66%> (-5.12%)` | :arrow_down: |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | `14.91% <0.00%> (-0.27%)` | :arrow_down: |
... and [675 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): support remote partitioner for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18897:
URL: https://github.com/apache/hudi/pull/18897#issuecomment-4611900361
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.32%. Comparing base ([`af38b88`](https://app.codecov.io/gh/apache/hudi/commit/af38b880de5c0bf15c35639fc39a7a94613d99a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`35815a0`](https://app.codecov.io/gh/apache/hudi/commit/35815a03f8b6932196ccc9c79312c4126ab4c229?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (af38b88) and HEAD (35815a0). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (af38b88) | HEAD (35815a0) |
>|------|------|------|
>|spark-java-tests|14|1|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18897 +/- ##
=============================================
- Coverage 67.01% 49.32% -17.69%
+ Complexity 28461 16221 -12240
=============================================
Files 2520 1977 -543
Lines 140046 108052 -31994
Branches 17197 13156 -4041
=============================================
- Hits 93850 53301 -40549
- Misses 38529 49232 +10703
+ Partials 7667 5519 -2148
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <66.66%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.16% <66.66%> (-0.07%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <66.66%> (-16.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18897/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <66.66%> (-12.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18897?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://app.codecov.io/gh/apache/hudi/pull/18897?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Fembedded%2FEmbeddedTimelineService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9lbWJlZGRlZC9FbWJlZGRlZFRpbWVsaW5lU2VydmljZS5qYXZh) | `74.60% <66.66%> (-12.02%)` | :arrow_down: |
... and [1601 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18897/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org