DO NOT REPLY [Bug 23530] New: - StackOverflowError in Action

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23530>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23530

StackOverflowError in Action

           Summary: StackOverflowError in Action
           Product: Struts
           Version: Nightly Build
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Critical
          Priority: Other
         Component: Controller
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: matthias.fraass@tricoder.net


There's an issue with the org/apache/struts/action/Action.java checked in on
2003/08/23:

protected void saveErrors(HttpServletRequest request, ActionErrors errors) 
{
 this.saveErrors(request, errors);
}

was supposed to call 

protected void saveErrors(HttpServletRequest request, ActionMessages errors)

given the assumption that the "errors" parameter of the first Method is an
ActionMessages (as ActionErrors extends ActionMessages). But when it is an
ActionErrors (which can happen when you have old code instanciating ActionErrors
and not ActionMessages) it reqults in an infinite loop calling itself again and
again =).

A possible fix would be to make a cast:

  this.saveErrors(request, (ErrorMessages)errors);

Regards,

Matz

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org