You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2018/07/10 19:44:00 UTC
[jira] [Comment Edited] (MESOS-9067) Improve performance of json
parsing by avoiding conversion cost.
[ https://issues.apache.org/jira/browse/MESOS-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539159#comment-16539159 ]
Benjamin Mahler edited comment on MESOS-9067 at 7/10/18 7:43 PM:
-----------------------------------------------------------------
{noformat}
commit 7918442b6c15ca31a401247850c5ad2d10d12317
Author: Benjamin Mahler <bm...@apache.org>
Date: Mon Jul 9 18:21:03 2018 -0700
Updated json parsing to avoid copying between picojson and stout JSON.
When looking at some profiling data, it looks as though we approximately
double the cost of JSON parsing due to having to convert from
`picojson::value` to `JSON::Value`.
Michael Park pointed me to the parsing "context" that's customizable in
picojson. This patch replaces our conversion with a parsing context in
order to parse directly into JSON::Value and avoid copying.
Review: https://reviews.apache.org/r/67861
{noformat}
was (Author: bmahler):
{noformat}
commit 7918442b6c15ca31a401247850c5ad2d10d12317
Author: Benjamin Mahler <bm...@apache.org>
Date: Mon Jul 9 18:21:03 2018 -0700
Updated json parsing to avoid copying between picojson and stout JSON.
When looking at some profiling data, it looks as though we approximately
double the cost of JSON parsing due to having to convert from
`picojson::value` to `JSON::Value`.
Michael Park pointed me to the parsing "context" that's customizable in
picojson. This patch replaces our conversion with a parsing context in
order to parse directly into JSON::Value and avoid copying.
Review: https://reviews.apache.org/r/67861
{noforamt}
> Improve performance of json parsing by avoiding conversion cost.
> ----------------------------------------------------------------
>
> Key: MESOS-9067
> URL: https://issues.apache.org/jira/browse/MESOS-9067
> Project: Mesos
> Issue Type: Improvement
> Components: stout
> Reporter: Benjamin Mahler
> Assignee: Benjamin Mahler
> Priority: Major
> Labels: performance
> Fix For: 1.7.0
>
>
> Stout's JSON parsing function parses into picojson::value followed by converting to JSON::Value. This carries a significant conversion cost (almost doubling the parse time).
> We can leverage picojson's parsing context to avoid this cost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)