[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2867: Make integration test use standard dist

[GitBox <gi...@apache.org>]

nicoloboschi commented on a change in pull request #2867:
URL: https://github.com/apache/bookkeeper/pull/2867#discussion_r739007025



##########
File path: tests/docker-images/statestore-image/Dockerfile
##########
@@ -46,8 +46,8 @@ RUN mkdir /opt/bookkeeper/conf
 RUN mkdir /opt/bookkeeper/scripts
 
 ### -----Copy Jars------###
-ADD ./dist/server.tar.gz /opt/
-RUN mv /opt/server/lib/*.jar /opt/bookkeeper/lib/
+ADD ./dist/bookkeeper-server-*.*SNAPSHOT.tar.gz /opt/

Review comment:
       in this way the integration tests won't run in a release version branch, correct? (without -SNAPSHOT suffix)
   I think we must not break this
   I suggest to use
   `bookkeeper-server-*.tar.gz`

##########
File path: bookkeeper-dist/server/build.gradle
##########
@@ -31,6 +31,7 @@ releaseArtifacts {
 dependencies {
     implementation project(':bookkeeper-server')
     implementation project(':bookkeeper-stats-providers:prometheus-metrics-provider')
+    implementation project(':bookkeeper-http:vertx-http-server')

Review comment:
       Is this needed? we already depend from `:stream:server` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org