You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/09/17 07:35:42 UTC
Re: [PR] [SPARK-53112][SQL][PYTHON][CONNECT] Support TIME in the make_timestamp_ntz and try_make_timestamp_ntz functions in PySpark [spark]
zhengruifeng commented on code in PR #51831:
URL: https://github.com/apache/spark/pull/51831#discussion_r2354600837
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -4027,14 +4033,56 @@ def make_timestamp_ntz(
mins: "ColumnOrName",
secs: "ColumnOrName",
) -> Column:
- return _invoke_function_over_columns(
- "make_timestamp_ntz", years, months, days, hours, mins, secs
- )
+ ...
+
+
+def make_timestamp_ntz( # type: ignore[misc]
+ yearsOrDate: "ColumnOrName",
Review Comment:
can we change the argument names?
does it break this?
```
make_timestamp_ntz(years=..., months=..., days=..., hours=..., mins=..., secs=...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org