You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2012/08/09 20:34:03 UTC

[Bug 53687] New: Minor fixes to test/dbd.c

https://issues.apache.org/bugzilla/show_bug.cgi?id=53687

          Priority: P2
            Bug ID: 53687
          Assignee: bugs@apr.apache.org
           Summary: Minor fixes to test/dbd.c
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mi+apache@aldan.algebra.com
          Hardware: All
            Status: NEW
           Version: 1.4.1
         Component: APR-util
           Product: APR

Created attachment 29198
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29198&action=edit
Fix several issues with test/dbd.c

The test/dbd.c has a few nits, that cause undue test-failures with
Sybase/FreeTDS driver:

* The test table is created without explicit "null" for some of the columns.
MySQL and SQLite seem to default to "null" anyway, but Sybase defaults to "not
null"
* %s is used in one statement, where the actual value is numeric
* When outputting errors with printf, newline is not always added

After patching the tests still work with sqlite3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


[Bug 53687] Minor fixes to test/dbd.c

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53687

--- Comment #1 from Mikhail T. <mi...@aldan.algebra.com> ---
Created attachment 29201
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29201&action=edit
Fix test's INSERT-statements to work with Sybase

The second hunk, which removes trailing semicolons from individual statements,
makes things work with Sybase without breaking SQLite3.

The first hunk, however, which replaces semicolons with newlines as separators
between statements, while helping Sybase pass the tests, causes SQLite3 (and,
likely, MySQL) to fail.

Thus, I'd be happy seeing just the second hunk committed, while the discussion
on how to handle the situation illustrated by the first one is ongoing...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


[Bug 53687] Minor fixes to test/dbd.c

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53687

Mikhail T. <mi...@aldan.algebra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |53666

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


[Bug 53687] Minor fixes to test/dbd.c

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53687

Mikhail T. <mi...@aldan.algebra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


[Bug 53687] Minor fixes to test/dbd.c

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53687

Mikhail T. <mi...@aldan.algebra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29198|0                           |1
           is patch|                            |
  Attachment #29198|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org