You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Timothy Chen <tn...@apache.org> on 2014/04/10 03:26:45 UTC
Review Request 20187: Patch for KAFKA-1363
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20187/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1363
https://issues.apache.org/jira/browse/KAFKA-1363
Repository: kafka
Description
-------
KAFKA-1363 Avoid delete topic deadlock by checking thread run status
Diffs
-----
core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80
Diff: https://reviews.apache.org/r/20187/diff/
Testing
-------
Thanks,
Timothy Chen
Re: Review Request 20187: Patch for KAFKA-1363
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20187/#review40008
-----------------------------------------------------------
core/src/main/scala/kafka/controller/TopicDeletionManager.scala
<https://reviews.apache.org/r/20187/#comment72793>
Could you explain why we want to set the flag to false during shutdown()?
- Jun Rao
On April 10, 2014, 1:27 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20187/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 1:27 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1363
> https://issues.apache.org/jira/browse/KAFKA-1363
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1363 Avoid delete topic deadlock by checking thread run status
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80
>
> Diff: https://reviews.apache.org/r/20187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 20187: Patch for KAFKA-1363
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20187/#review40028
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 10, 2014, 1:27 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20187/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 1:27 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1363
> https://issues.apache.org/jira/browse/KAFKA-1363
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1363 Avoid delete topic deadlock by checking thread run status
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80
>
> Diff: https://reviews.apache.org/r/20187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 20187: Patch for KAFKA-1363
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20187/
-----------------------------------------------------------
(Updated April 10, 2014, 1:27 a.m.)
Review request for kafka.
Bugs: KAFKA-1363
https://issues.apache.org/jira/browse/KAFKA-1363
Repository: kafka
Description
-------
KAFKA-1363 Avoid delete topic deadlock by checking thread run status
Diffs
-----
core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80
Diff: https://reviews.apache.org/r/20187/diff/
Testing
-------
Thanks,
Timothy Chen