[jira] Reopened: (MYFACES-628) Current Lifecycle implementation violates JSF Spec 1.1

["Bill Dudney (JIRA)" <my...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/MYFACES-628?page=all ]
     
Bill Dudney reopened MYFACES-628:
---------------------------------


Hi Ronald,

On the logging: I'll update that with the requested detail

On the before listeners in render: I think I have a fix for that but I wanted to run it by the rest of the dev team.

In the FacesServlet.service method I can wrap the call to lifecycle.render in a check for 'responseComplete'. This will avoid calling render all together (as Ronald needs) and seems to be what is needed. The other approach is to have a check at the top of render that looks for 'responsecomplete' and just returns. Which fix is better?

> Current Lifecycle implementation violates JSF Spec 1.1
> ------------------------------------------------------
>
>          Key: MYFACES-628
>          URL: http://issues.apache.org/jira/browse/MYFACES-628
>      Project: MyFaces
>         Type: Bug
>   Components: JSR-127
>     Versions: 1.1.0
>     Reporter: Holger Schimanski
>     Assignee: Bill Dudney
>     Priority: Blocker
>      Fix For: 1.1.1

>
> If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or FacesContext.responseComplete(), then the LifeCycleImpl should not execute the functionality required for the current phase. (see JSF Spec 1.1 section 11-1 page 296f.)  LifeCycleImpl is not taking care about this. 
> This is important for us, because we'd like to make a redirect in the before render response phase. And at the moment an Illegal State exception is thrown, because the renderResponse is executed although responseComplete has been called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira