You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/08/19 11:00:29 UTC
cloudstack-cloudmonkey git commit: Revert "Fix some parameters are
double encoded"
Repository: cloudstack-cloudmonkey
Updated Branches:
refs/heads/master 1bc53d203 -> 653dcca9e
Revert "Fix some parameters are double encoded"
This breaks API, api expects only single encoding. Tested against 4.5.1.
... "(UI uses javascript to encode on
the fly, see ui/scripts/accounts.js:1852), such as registerSSHKeyPair/publickey.
I did a quick search for other cases, bu there may be more parameters."
This reverts commit 6bd92395592c133a63b8087bf4acc9cb3a1aac0d.
Project: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/commit/653dcca9
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/tree/653dcca9
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/diff/653dcca9
Branch: refs/heads/master
Commit: 653dcca9e008e20fee83f0b40f388611ad931d15
Parents: 1bc53d2
Author: Rohit Yadav <ro...@shapeblue.com>
Authored: Wed Aug 19 14:29:05 2015 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Wed Aug 19 14:29:05 2015 +0530
----------------------------------------------------------------------
cloudmonkey/requester.py | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack-cloudmonkey/blob/653dcca9/cloudmonkey/requester.py
----------------------------------------------------------------------
diff --git a/cloudmonkey/requester.py b/cloudmonkey/requester.py
index a8f587b..d652948 100644
--- a/cloudmonkey/requester.py
+++ b/cloudmonkey/requester.py
@@ -189,9 +189,6 @@ def make_request(command, args, logger, url, credentials, expires,
args[key] = value
if not key:
args.pop(key)
- else:
- if key in ['publickey', 'privatekey', 'certificate']:
- args[key] = urllib.quote_plus(str(value))
# try to use the apikey/secretkey method by default
# followed by trying to check if we're using integration port