You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2006/10/27 15:54:39 UTC

svn commit: r468385 - /spamassassin/trunk/Makefile.PL

Author: jm
Date: Fri Oct 27 06:54:38 2006
New Revision: 468385

URL: http://svn.apache.org/viewvc?view=rev&rev=468385
Log:
bug 4681: work around race condition between Makefile.PL and the generated file rules/72_active.cf; create the file at Makefile.PL time, so that it will be installed and to silence a silly warning

Modified:
    spamassassin/trunk/Makefile.PL

Modified: spamassassin/trunk/Makefile.PL
URL: http://svn.apache.org/viewvc/spamassassin/trunk/Makefile.PL?view=diff&rev=468385&r1=468384&r2=468385
==============================================================================
--- spamassassin/trunk/Makefile.PL (original)
+++ spamassassin/trunk/Makefile.PL Fri Oct 27 06:54:38 2006
@@ -273,6 +273,12 @@
     'NO_META' => 1,
 );
 
+# rules/72_active.cf is built from "rulesrc", but *must* exist before
+# WriteMakefile() is called due to shortcomings in MakeMaker.
+my @FILES_THAT_MUST_EXIST = qw(
+        rules/72_active.cf
+    );
+
 # That META.yml stuff was introduced with Perl 6.06_03, see
 # <http://archive.develooper.com/makemaker@perl.org/msg00922.html>
 # <http://archive.develooper.com/makemaker@perl.org/msg00984.html>
@@ -378,6 +384,10 @@
   exit 1;
 }
 
+foreach my $file (@FILES_THAT_MUST_EXIST) {
+  open (TOUCH, ">>$file") or die "cannot touch '$file'";
+  close TOUCH;
+}
 
 #######################################################################