You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/03/28 09:19:28 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1392: [CELEBORN-372][FOLLOWUP][LICENSE] Remove exclusion from Apache Rat
pan3793 opened a new pull request, #1392:
URL: https://github.com/apache/incubator-celeborn/pull/1392
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove `LimitedInputStream.java` exclusion from Apache Rat.
### Why are the changes needed?
The `LimitedInputStream.java` has a standard Apache License v2 header, which can pass the Apache Rat Check.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
build/mvn apache-rat:check
```
Also passed the CI license check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1392: [CELEBORN-372][FOLLOWUP][LICENSE] Remove exclusion from Apache Rat
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1392:
URL: https://github.com/apache/incubator-celeborn/pull/1392#issuecomment-1486287156
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1392?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1392](https://codecov.io/gh/apache/incubator-celeborn/pull/1392?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c31b5f6) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/cb19ed1c66a8ece834fc6aea10b8b57627d2eec6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb19ed1) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1392 +/- ##
============================================
- Coverage 29.92% 29.88% -0.04%
+ Complexity 919 916 -3
============================================
Files 223 223
Lines 18660 18660
Branches 1987 1987
============================================
- Hits 5583 5574 -9
- Misses 12689 12694 +5
- Partials 388 392 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/celeborn/client/write/DataPushQueue.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvd3JpdGUvRGF0YVB1c2hRdWV1ZS5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1392/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1392: [CELEBORN-372][FOLLOWUP][LICENSE] Remove exclusion from Apache Rat
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1392:
URL: https://github.com/apache/incubator-celeborn/pull/1392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1392: [CELEBORN-372][FOLLOWUP][LICENSE] Remove exclusion from Apache Rat
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1392: [CELEBORN-372][FOLLOWUP][LICENSE] Remove exclusion from Apache Rat
URL: https://github.com/apache/incubator-celeborn/pull/1392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org