You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/09/26 09:24:19 UTC
[GitHub] [incubator-inlong] luchunliang opened a new pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
luchunliang opened a new pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591
Fixes #1589
### Motivation
See #1589 , Manager provide an openapi of DataProxy configuration data.
### Modifications
inlong-manager/doc/sql/apache_inlong_manager.sql
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/CacheCluster.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/CacheClusterExt.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/CacheTopic.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/ClusterSet.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeChannel.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeChannelExt.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeSink.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeSinkExt.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeSource.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/FlumeSourceExt.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/InLongId.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/ProxyCluster.java
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/dataproxy/ProxyClusterToCacheCluster.java
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/ClusterSetMapper.java
inlong-manager/manager-dao/src/main/resources/mappers/ClusterSetMapper.xml
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/DataProxyClusterService.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/DataProxyClusterServiceImpl.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/CacheClusterObject.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/CacheClusterSetObject.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/CacheTopicObject.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyCluster.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyClusterSet.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyConfigRepository.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/DataProxyConfigResponse.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/IRepository.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/InLongIdObject.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/ProxyChannel.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/ProxyClusterObject.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/ProxySink.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/ProxySource.java
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/repository/RepositoryTimerTask.java
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/openapi/DataProxyController.java
inlong-manager/pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927293489
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1591](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a9e2a6) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/385b2a9a29a4e50fcba7e7e84b3938a7510f9465?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385b2a9) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1591 +/- ##
=========================================
Coverage 12.19% 12.19%
- Complexity 1049 1050 +1
=========================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
=========================================
Hits 3995 3995
Misses 27995 27995
Partials 765 765
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bemq/server/common/heartbeat/HeartbeatManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9jb21tb24vaGVhcnRiZWF0L0hlYXJ0YmVhdE1hbmFnZXIuamF2YQ==) | `36.36% <0.00%> (-2.03%)` | :arrow_down: |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `34.51% <0.00%> (+0.44%)` | :arrow_up: |
| [.../inlong/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `40.00% <0.00%> (+1.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385b2a9...1a9e2a6](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927293489
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1591](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1d272b) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/385b2a9a29a4e50fcba7e7e84b3938a7510f9465?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385b2a9) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1591 +/- ##
============================================
+ Coverage 12.19% 12.21% +0.01%
+ Complexity 1049 1048 -1
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
+ Hits 3995 4001 +6
+ Misses 27995 27989 -6
Partials 765 765
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385b2a9...d1d272b](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#discussion_r716177908
##########
File path: inlong-manager/doc/sql/apache_inlong_manager.sql
##########
@@ -845,4 +845,225 @@ CREATE TABLE `wf_task_instance`
AUTO_INCREMENT = 704
DEFAULT CHARSET = utf8mb4 COMMENT ='Task instance';
+-- ----------------------------
Review comment:
this file is used for docker-compose, it's better to change [docker-compose/sql/apache_inlong_manager.sql](https://github.com/apache/incubator-inlong/blob/master/docker/docker-compose/sql/apache_inlong_manager.sql) too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
healchow commented on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927532168
It is recommended to move the entity classes that interact with the database to the manager-dao module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
healchow commented on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-929786042
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927293489
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1591](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07db505) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/385b2a9a29a4e50fcba7e7e84b3938a7510f9465?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385b2a9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1591 +/- ##
============================================
- Coverage 12.19% 12.18% -0.01%
+ Complexity 1049 1048 -1
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
- Hits 3995 3992 -3
- Misses 27995 27997 +2
- Partials 765 766 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bemq/server/common/heartbeat/HeartbeatManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9jb21tb24vaGVhcnRiZWF0L0hlYXJ0YmVhdE1hbmFnZXIuamF2YQ==) | `36.36% <0.00%> (-2.03%)` | :arrow_down: |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385b2a9...07db505](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#discussion_r716177908
##########
File path: inlong-manager/doc/sql/apache_inlong_manager.sql
##########
@@ -845,4 +845,225 @@ CREATE TABLE `wf_task_instance`
AUTO_INCREMENT = 704
DEFAULT CHARSET = utf8mb4 COMMENT ='Task instance';
+-- ----------------------------
Review comment:
this file is used for docker-compose, it's better to change [docker-compose/sql/apache_inlong_manager.sql](https://github.com/apache/incubator-inlong/blob/master/docker/docker-compose/sql/apache_inlong_manager.sql) too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang closed pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
luchunliang closed pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
healchow commented on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-929786042
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927293489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter edited a comment on pull request #1591: [INLONG-1589] Manager provide an openapi of DataProxy configuration data for multi-subcluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1591:
URL: https://github.com/apache/incubator-inlong/pull/1591#issuecomment-927293489
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1591](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1d272b) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/385b2a9a29a4e50fcba7e7e84b3938a7510f9465?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385b2a9) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1591 +/- ##
============================================
+ Coverage 12.19% 12.21% +0.01%
+ Complexity 1049 1048 -1
============================================
Files 392 392
Lines 32755 32755
Branches 5159 5159
============================================
+ Hits 3995 4001 +6
+ Misses 27995 27989 -6
Partials 765 765
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/1591/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385b2a9...d1d272b](https://codecov.io/gh/apache/incubator-inlong/pull/1591?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org