You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/06/07 20:53:47 UTC

Review Request 67492: ATLAS-2746: Term/Category creation doesn't need Entity.UPDATE privilege for simple cases.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67492/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2746
    https://issues.apache.org/jira/browse/ATLAS-2746


Repository: atlas


Description
-------

See JIRA


Diffs
-----

  repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java be2f16e9d 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java ff5aa6ea7 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 4d65328ca 


Diff: https://reviews.apache.org/r/67492/diff/1/


Testing
-------

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/468/


Thanks,

Apoorv Naik


Re: Review Request 67492: ATLAS-2746: Term/Category creation doesn't need Entity.UPDATE privilege for simple cases.

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67492/#review204465
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/67492/#comment286950>

    If this comment is not relevant any more, please remove.


- Madhan Neethiraj


On June 7, 2018, 8:53 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67492/
> -----------------------------------------------------------
> 
> (Updated June 7, 2018, 8:53 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2746
>     https://issues.apache.org/jira/browse/ATLAS-2746
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See JIRA
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java be2f16e9d 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java ff5aa6ea7 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 4d65328ca 
> 
> 
> Diff: https://reviews.apache.org/r/67492/diff/1/
> 
> 
> Testing
> -------
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/468/
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>