You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/03/29 18:14:38 UTC
[PR] HDDS-12734. Enable native lib in CI checks [ozone]
adoroszlai opened a new pull request, #8190:
URL: https://github.com/apache/ozone/pull/8190
## What changes were proposed in this pull request?
Currently only _native_ check builds Ozone's native library, because it was initially very slow (added 15 minutes to the build time). Now it is less than 1 minute:
```
[INFO] Apache Ozone HDDS RocksDB Tools .................... SUCCESS [ 45.621 s]
```
This PR enables native library in CI and drops _native_ check. This increases test coverage by letting _repro_ and _acceptance_ checks also to test it.
Replace `@Native` tag with JUnit built-in annotation that checks the Maven property used to enable the native lib at build.
https://issues.apache.org/jira/browse/HDDS-12734
## How was this patch tested?
```
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.552 s -- in org.apache.hadoop.hdds.utils.TestNativeLibraryLoader
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.891 s -- in org.apache.hadoop.hdds.utils.db.managed.TestManagedRawSSTFileIterator
```
```
[INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 205.5 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithNativeLib
[INFO] Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 205.4 s -- in org.apache.hadoop.ozone.om.snapshot.TestOmSnapshotFsoWithoutNativeLib
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/14147241123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12734. Enable native lib in CI checks [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8190:
URL: https://github.com/apache/ozone/pull/8190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12734. Enable native lib in CI checks [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8190:
URL: https://github.com/apache/ozone/pull/8190#issuecomment-2774789211
> I am trying out ChatGPT Plus (o3-mini-high) for code reviews.
My observations about it:
- It's a mix of surprisingly good and completely wrong items.
- It's overly verbose with lots of BS.
- It's an "overview", not a "review": does not say whether the change is good or bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12734. Enable native lib in CI checks [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #8190:
URL: https://github.com/apache/ozone/pull/8190#issuecomment-2770834783
I am trying out ChatGPT Plus (o3-mini-high) for code reviews. Here's the output: https://chatgpt.com/share/67ec69d7-11a0-800e-ac7d-c592062a1e6c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12734. Enable native lib in CI checks [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8190:
URL: https://github.com/apache/ozone/pull/8190#issuecomment-2812559250
Thanks @jojochuang, @swamirishi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12734. Enable native lib in CI checks [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8190:
URL: https://github.com/apache/ozone/pull/8190#issuecomment-2790194210
@swamirishi please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org