You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/02 21:55:53 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25283: Chart: custom labels for extrasecrets/configmaps
jedcunningham commented on code in PR #25283:
URL: https://github.com/apache/airflow/pull/25283#discussion_r936057724
##########
chart/values.schema.json:
##########
@@ -857,6 +857,15 @@
"description": "Type **as string** of secret E.G. Opaque, kubernetes.io/dockerconfigjson, etc.",
"type": "string"
},
+ "labels": {
+ "description": "Labels for the secret",
+ "type": "object",
+ "additionalProperties": {
+ "description": "Label key",
+ "default": null,
Review Comment:
Shouldn't this default be set up a level, as the default for `labels`?
##########
chart/values.schema.json:
##########
@@ -857,6 +857,15 @@
"description": "Type **as string** of secret E.G. Opaque, kubernetes.io/dockerconfigjson, etc.",
"type": "string"
},
+ "labels": {
+ "description": "Labels for the secret",
+ "type": "object",
+ "additionalProperties": {
+ "description": "Label key",
Review Comment:
I'm not sure we need this description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org