You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/04 16:06:02 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

dongjoon-hyun opened a new pull request #32784:
URL: https://github.com/apache/spark/pull/32784


   ### What changes were proposed in this pull request?
   
   This PR aims to change `DiskBlockManager` like the following to allow `ShuffleDataIO` to decide the behavior of shuffle file deletion.
   ```scala
   - private[spark] class DiskBlockManager(conf: SparkConf, deleteFilesOnStop: Boolean)
   +private[spark] class DiskBlockManager(conf: SparkConf, var deleteFilesOnStop: Boolean)
   ```
   
   ### Why are the changes needed?
   
   To implement enhanced shuffle data management feature via `ShuffleDataIO` like https://github.com/apache/spark/pull/32730 .
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This is a private class.
   
   ### How was this patch tested?
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854942917


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139339/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854842694


   **[Test build #139339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139339/testReport)** for PR 32784 at commit [`1a86882`](https://github.com/apache/spark/commit/1a86882681e52d16e826d31cd03ff747faf8a550).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-855177716


   cc @Ngone51 too FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854927640


   **[Test build #139339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139339/testReport)** for PR 32784 at commit [`1a86882`](https://github.com/apache/spark/commit/1a86882681e52d16e826d31cd03ff747faf8a550).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854942917


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139339/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854879623


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854875225


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854842694


   **[Test build #139339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139339/testReport)** for PR 32784 at commit [`1a86882`](https://github.com/apache/spark/commit/1a86882681e52d16e826d31cd03ff747faf8a550).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-855423924


   Thank you so much, @mridulm , @viirya , @HyukjinKwon .
   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854840349


   Hi, @mridulm and @viirya . I spin off this part from the original PR.
   Could you review this independently, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32784:
URL: https://github.com/apache/spark/pull/32784#issuecomment-854879623


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43861/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #32784: [SPARK-35654][CORE] Allow ShuffleDataIO control DiskBlockManager.deleteFilesOnStop

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32784:
URL: https://github.com/apache/spark/pull/32784


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org