[GitHub] [pulsar-client-node] massakam commented on a change in pull request #137: Return MessageId as promise resolve at Producer#send

[GitBox <gi...@apache.org>]

massakam commented on a change in pull request #137:
URL: https://github.com/apache/pulsar-client-node/pull/137#discussion_r548803734



##########
File path: tests/end_to_end.test.js
##########
@@ -665,5 +665,54 @@ const Pulsar = require('../index.js');
       await consumer.close();
       await client.close();
     });
+
+    test('Produce/Consume and validate MessageId', async () => {
+      const client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
+      });
+
+      const topic = 'persistent://public/default/produce-consume-message-id';
+      const producer = await client.createProducer({
+        topic,
+        sendTimeoutMs: 30000,
+        batchingEnabled: true,
+      });
+      expect(producer).not.toBeNull();
+
+      const consumer = await client.subscribe({
+        topic,
+        subscription: 'sub1',
+        ackTimeoutMs: 10000,

Review comment:
       Do we need to set `ackTimeoutMs`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org