You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/03 14:35:15 UTC

[GitHub] [airflow] VinceLegendre commented on issue #24730: Google CloudRun job operator

VinceLegendre commented on issue #24730:
URL: https://github.com/apache/airflow/issues/24730#issuecomment-1369838697

   After a closer look a this [plugin](https://github.com/mharrisb1/airflow-google-cloud-run-plugin), here are some thoughts :
   
   - `CloudRunHook` should extend `GoogleBaseHook`to ease authentication and GCP configuration
   - As [gcloud CLI](https://cloud.google.com/run/docs/create-jobs#command-line) propose the `--execute-now` flag when creating jobs, I think the following logic/naming convention may be more straightforward :
       -  Have a `CloudRunCreateJobOperator` with `execute_now`, `update_if_exists` and `delete_on_exit` capabilities, to allow job definition, run and deletion from Airflow
       - Have a separate `CloudRunExecuteJobOperator`, allowing one to execute a pre-created job in a GCP project
    - `CloudRunListJobs` and `CloudRunDeleteJob` operators to complete CRUD capabilities for jobs, as introduced in the plugin documentation
    - Regarding executions, is the **DELETE** operation mandatory to support ? I may miss some use cases here
   
   Happy to have this issue assigned if necessary @v-hunt , as I think this would be a game changer for many GCP users!
   I guess the required development would be mostly based on @mharrisb1 's really good plugin (congrats btw :clap: )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org