You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/22 02:06:35 UTC
[GitHub] [maven-enforcer] olamy opened a new pull request, #192: remove specific IDE m2e files
olamy opened a new pull request, #192:
URL: https://github.com/apache/maven-enforcer/pull/192
those files are specific to m2e they shouldn;t be stored in the Apache Maven sources!
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] olamy commented on pull request #192: remove specific IDE m2e files
Posted by GitBox <gi...@apache.org>.
olamy commented on PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1322916281
cc @HannesWell @kwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] vtintillier commented on pull request #192: remove specific IDE m2e files
Posted by "vtintillier (via GitHub)" <gi...@apache.org>.
vtintillier commented on PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1413905847
Hi @kwin
looks like the ignore in the file you linked to has a different behavior than what we had with the `META-INF/m2e/lifecycle-mapping-metadata.xml` hosted in maven-enforcer-plugin itself. Before this file was removed, there would be no warning at all in Eclipse, and enforcer would not run as part of the Eclipse build.
Now enforcer still don't run, but we have this warning.
I asked about this in m2e too: https://github.com/eclipse-m2e/m2e-core/discussions/1229
But I think the easiest way forward is to add this file again.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] vtintillier commented on pull request #192: remove specific IDE m2e files
Posted by "vtintillier (via GitHub)" <gi...@apache.org>.
vtintillier commented on PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1413812296
Hello @olamy
I think this is a regression for all users of Eclipse and maven-enforcer-plugin. We now have a warning in all our pom files because of this change:
It means this change forces all those projects to each find a way to ignore this warning. And for now I have not found a way to do it on my side.
The goal of this `META-INF/m2e/lifecycle-mapping-metadata.xml` file is just to declare whether it makes sense to run this plugin in Eclipse or not, so that not all projects have to declare it on their side.
Would you consider reverting this change to help all those projects? Especially given there was no maintenance on this file for 8 years in this project, so not really costing this project anything.
Thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] kwin commented on pull request #192: remove specific IDE m2e files
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1413873314
@vtintillier Please raise an issue with m2e (at https://github.com/eclipse-m2e/m2e-core/issues) as the action `ignore` in https://github.com/eclipse-m2e/m2e-core/blob/e3794059b1250729872daecf9c1ff0b35fc75daf/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml#L130 is the culprit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] olamy merged pull request #192: remove specific IDE m2e files
Posted by GitBox <gi...@apache.org>.
olamy merged PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] olamy commented on pull request #192: remove specific IDE m2e files
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #192:
URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1414561070
Sorry for the disagreement but this file should have never been added..
But your problem should be solved by m2e plugin.
Imagine if every single IDE asks to host their configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org