You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tapestry.apache.org by "seloha ." <se...@hotmail.com> on 2005/09/26 12:10:36 UTC
OutOfMemoryError Tapestry 4.0
I have a page which allows a user to search the database based on various
criteria. I have restricted the number of returned items to 5000. I display
the items in the same search page using the @For component with
volatile="ognl:true" . Repeated searches which return 5000 items will result
in an OutOfMemoryError exception. If I leave the page and then return or
stay on the page I will ultimately get an OutOfMemoryError exception.
I can view other pages after this exception but a repeat of trying to
display 5000 items on this page will display an OutOfMemory exception.
The only way to clear this problem is to restart the servlet container. This
fails using either Jetty or Tomcat in both development and production
environments (using different operating systems).
All the variables displaying the list are explicitly declared in the .page
specification and using initial-value set to null.
I am using Tapestry 4.0 beta 8.
The data is retrieved using Spring and Hibernate (no fancy patterns,
standard Spring declarative transactions and using getHibernateTemplate())
and mapped to Tapestry using hivemodule.xml:
<implementation service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
<invoke-factory>
<construct autowire-services="false"
class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
<event-listener service-id="hivemind.ShutdownCoordinator" />
<set-object property="context"
value="service:tapestry.globals.WebContext" />
</construct>
</invoke-factory>
</implementation>
and injecting the appropriate Spring bean.
I am completely confused as to how to tie down the problem and isolate which
section of code is causing the problem.
Any help would be much appreciated.
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
Isn't the OP's problem a bit more subtle? He doesn't run out of
memory on the *initial* load, so one full page fits in memory. Its repeated
loads of the page that eventually run him out of memory, isn't it (implying
a memory leak)? Or did I misread his original problem?
--- Pat
> -----Original Message-----
> From: Howard Lewis Ship [mailto:hlship@gmail.com]
> Sent: Monday, September 26, 2005 11:45 AM
> To: Tapestry users
> Subject: Re: OutOfMemoryError Tapestry 4.0
>
> The likely difference is how Tapestry renders the page; it will buffer
> the contents in memory (a consequence of the Body component) before
> streaming the entire result to the user. If your page does not use
> any JavaScript, then you should be able to build it without the Body
> component and the results will stream out like a Struts/JSP app.
>
> However, use a Table component and make those 5000 rows navigate as
> 100 pages of 50 rows and your users will thank you!
>
> On 9/26/05, seloha . <se...@hotmail.com> wrote:
> > Thanks ausias,
> >
> > I have thought about reducing the number of objects but a prvious
> version of
> > the app written with struts was able to display many more thn 5000 lines
> > with no problem. A rethink on presentation may be a good idea. Also
> > providing the container with more memory may help.
> >
> > Thanks again,
> >
> > Paul
> >
> > ausias vives <au...@yahoo.co.uk> wrote:
> >
> > Hi,
> >
> > In my experience, the problem you're describing is not
> > related directly with Tapestry, It looks like more as
> > a standard problem with the available memory in the
> > servlet container.
> >
> > I'll try to avoid returning 5000 objects at the same
> > time, depending on the size of the objects this can be
> > a large amount of memory, ant thus it can use all the
> > jetty or tomcat available memory. You can use a
> > browser to avoid returning all the objects at the same
> > time.
> >
> > If you really need all those objects at the same time,
> > you should allow the servlet container to use more
> > memory (even though is always a good idea to increase
> > the server memory).
> >
> > Definetly I recommend you to rethink the way the
> > results are presented to the user (think about having
> > 10 users getting 5000 objects each of them... or even
> > more)
> >
> > Regards
> >
> > >I have a page which allows a user to search the
> > >database based on various criteria. I have restricted the number of
> > >returned
> > >items to 5000. I display the items in the same search page using the
> @For
> > >component with volatile="ognl:true" . Repeated searches which
> > >return 5000 items will result in an OutOfMemoryError exception. If I
> leave
> > >the
> > >page and then return or stay on the page I will ultimately get an
> > >OutOfMemoryError exception.
> > >
> > >I can view other pages after this exception but a
> > >repeat of trying to display 5000 items on this page will display an
> > >OutOfMemory exception.
> > >
> > >The only way to clear this problem is to restart the
> > >servlet container. This fails using either Jetty or Tomcat in both
> > >development and production environments (using different operating
> > >systems).
> > >
> > >All the variables displaying the list are explicitly
> > >declared in the .page specification and using initial-value set to
> null.
> > >
> > >I am using Tapestry 4.0 beta 8.
> > >
> > >The data is retrieved using Spring and Hibernate (no
> > >fancy patterns, standard Spring declarative transactions and using
> > >getHibernateTemplate()) and mapped to Tapestry using hivemodule.xml:
> > >
> > > <implementation
> > >
> > service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > <invoke-factory>
> > > <construct autowire-services="false"
> > >
> > class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > <event-listener
> > >service-id="hivemind.ShutdownCoordinator" />
> > > <set-object property="context"
> > >value="service:tapestry.globals.WebContext" />
> > > </construct>
> > > </invoke-factory>
> > > </implementation>
> > >
> > >and injecting the appropriate Spring bean.
> > >
> > >I am completely confused as to how to tie down the
> > >problem and isolate which section of code is causing the problem.
> > >
> > >Any help would be much appreciated.
> > >
> > >Paul
> > >
> > >
> > >
> > >
> > ---------------------------------------------------------------------
> > >To unsubscribe, e-mail:
> > >tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail:
> > >tapestry-user-help@jakarta.apache.org
> > >
> > >
> >
> >
> >
> >
> > ___________________________________________________________
> > To help you stay safe and secure online, we've developed the all new
> Yahoo!
> > Security Centre. http://uk.security.yahoo.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
>
>
> --
> Howard M. Lewis Ship
> Independent J2EE / Open-Source Java Consultant
> Creator, Jakarta Tapestry
> Creator, Jakarta HiveMind
>
> Professional Tapestry training, mentoring, support
> and project work. http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by Howard Lewis Ship <hl...@gmail.com>.
The likely difference is how Tapestry renders the page; it will buffer
the contents in memory (a consequence of the Body component) before
streaming the entire result to the user. If your page does not use
any JavaScript, then you should be able to build it without the Body
component and the results will stream out like a Struts/JSP app.
However, use a Table component and make those 5000 rows navigate as
100 pages of 50 rows and your users will thank you!
On 9/26/05, seloha . <se...@hotmail.com> wrote:
> Thanks ausias,
>
> I have thought about reducing the number of objects but a prvious version of
> the app written with struts was able to display many more thn 5000 lines
> with no problem. A rethink on presentation may be a good idea. Also
> providing the container with more memory may help.
>
> Thanks again,
>
> Paul
>
> ausias vives <au...@yahoo.co.uk> wrote:
>
> Hi,
>
> In my experience, the problem you're describing is not
> related directly with Tapestry, It looks like more as
> a standard problem with the available memory in the
> servlet container.
>
> I'll try to avoid returning 5000 objects at the same
> time, depending on the size of the objects this can be
> a large amount of memory, ant thus it can use all the
> jetty or tomcat available memory. You can use a
> browser to avoid returning all the objects at the same
> time.
>
> If you really need all those objects at the same time,
> you should allow the servlet container to use more
> memory (even though is always a good idea to increase
> the server memory).
>
> Definetly I recommend you to rethink the way the
> results are presented to the user (think about having
> 10 users getting 5000 objects each of them... or even
> more)
>
> Regards
>
> >I have a page which allows a user to search the
> >database based on various criteria. I have restricted the number of
> >returned
> >items to 5000. I display the items in the same search page using the @For
> >component with volatile="ognl:true" . Repeated searches which
> >return 5000 items will result in an OutOfMemoryError exception. If I leave
> >the
> >page and then return or stay on the page I will ultimately get an
> >OutOfMemoryError exception.
> >
> >I can view other pages after this exception but a
> >repeat of trying to display 5000 items on this page will display an
> >OutOfMemory exception.
> >
> >The only way to clear this problem is to restart the
> >servlet container. This fails using either Jetty or Tomcat in both
> >development and production environments (using different operating
> >systems).
> >
> >All the variables displaying the list are explicitly
> >declared in the .page specification and using initial-value set to null.
> >
> >I am using Tapestry 4.0 beta 8.
> >
> >The data is retrieved using Spring and Hibernate (no
> >fancy patterns, standard Spring declarative transactions and using
> >getHibernateTemplate()) and mapped to Tapestry using hivemodule.xml:
> >
> > <implementation
> >
> service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > <invoke-factory>
> > <construct autowire-services="false"
> >
> class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > <event-listener
> >service-id="hivemind.ShutdownCoordinator" />
> > <set-object property="context"
> >value="service:tapestry.globals.WebContext" />
> > </construct>
> > </invoke-factory>
> > </implementation>
> >
> >and injecting the appropriate Spring bean.
> >
> >I am completely confused as to how to tie down the
> >problem and isolate which section of code is causing the problem.
> >
> >Any help would be much appreciated.
> >
> >Paul
> >
> >
> >
> >
> ---------------------------------------------------------------------
> >To unsubscribe, e-mail:
> >tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail:
> >tapestry-user-help@jakarta.apache.org
> >
> >
>
>
>
>
> ___________________________________________________________
> To help you stay safe and secure online, we've developed the all new Yahoo!
> Security Centre. http://uk.security.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind
Professional Tapestry training, mentoring, support
and project work. http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by Mind Bridge <mi...@yahoo.com>.
Do you have caching disabled by any chance?
seloha . wrote:
> Thanks ausias,
>
> I have thought about reducing the number of objects but a prvious
> version of the app written with struts was able to display many more
> thn 5000 lines with no problem. A rethink on presentation may be a
> good idea. Also providing the container with more memory may help.
>
> Thanks again,
>
> Paul
>
> ausias vives <au...@yahoo.co.uk> wrote:
>
> Hi,
>
> In my experience, the problem you're describing is not
> related directly with Tapestry, It looks like more as
> a standard problem with the available memory in the
> servlet container.
>
> I'll try to avoid returning 5000 objects at the same
> time, depending on the size of the objects this can be
> a large amount of memory, ant thus it can use all the
> jetty or tomcat available memory. You can use a
> browser to avoid returning all the objects at the same
> time.
>
> If you really need all those objects at the same time,
> you should allow the servlet container to use more
> memory (even though is always a good idea to increase
> the server memory).
>
> Definetly I recommend you to rethink the way the
> results are presented to the user (think about having
> 10 users getting 5000 objects each of them... or even
> more)
>
> Regards
>
>> I have a page which allows a user to search the
>> database based on various criteria. I have restricted the number of
>> returned
>> items to 5000. I display the items in the same search page using the
>> @For
>> component with volatile="ognl:true" . Repeated searches which
>> return 5000 items will result in an OutOfMemoryError exception. If I
>> leave the
>> page and then return or stay on the page I will ultimately get an
>> OutOfMemoryError exception.
>>
>> I can view other pages after this exception but a
>> repeat of trying to display 5000 items on this page will display an
>> OutOfMemory exception.
>>
>> The only way to clear this problem is to restart the
>> servlet container. This fails using either Jetty or Tomcat in both
>> development and production environments (using different operating
>> systems).
>>
>> All the variables displaying the list are explicitly
>> declared in the .page specification and using initial-value set to null.
>>
>> I am using Tapestry 4.0 beta 8.
>>
>> The data is retrieved using Spring and Hibernate (no
>> fancy patterns, standard Spring declarative transactions and using
>> getHibernateTemplate()) and mapped to Tapestry using hivemodule.xml:
>>
>> <implementation
>>
> service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
>
>> <invoke-factory>
>> <construct autowire-services="false"
>>
> class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
>
>> <event-listener
>> service-id="hivemind.ShutdownCoordinator" />
>> <set-object property="context"
>> value="service:tapestry.globals.WebContext" />
>> </construct>
>> </invoke-factory>
>> </implementation>
>>
>> and injecting the appropriate Spring bean.
>>
>> I am completely confused as to how to tie down the
>> problem and isolate which section of code is causing the problem.
>>
>> Any help would be much appreciated.
>>
>> Paul
>>
>>
>>
>>
> ---------------------------------------------------------------------
>
>> To unsubscribe, e-mail:
>> tapestry-user-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail:
>> tapestry-user-help@jakarta.apache.org
>>
>>
>
>
>
>
> ___________________________________________________________
> To help you stay safe and secure online, we've developed the all new
> Yahoo!
> Security Centre. http://uk.security.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
Thanks ausias,
I have thought about reducing the number of objects but a prvious version of
the app written with struts was able to display many more thn 5000 lines
with no problem. A rethink on presentation may be a good idea. Also
providing the container with more memory may help.
Thanks again,
Paul
ausias vives <au...@yahoo.co.uk> wrote:
Hi,
In my experience, the problem you're describing is not
related directly with Tapestry, It looks like more as
a standard problem with the available memory in the
servlet container.
I'll try to avoid returning 5000 objects at the same
time, depending on the size of the objects this can be
a large amount of memory, ant thus it can use all the
jetty or tomcat available memory. You can use a
browser to avoid returning all the objects at the same
time.
If you really need all those objects at the same time,
you should allow the servlet container to use more
memory (even though is always a good idea to increase
the server memory).
Definetly I recommend you to rethink the way the
results are presented to the user (think about having
10 users getting 5000 objects each of them... or even
more)
Regards
>I have a page which allows a user to search the
>database based on various criteria. I have restricted the number of
>returned
>items to 5000. I display the items in the same search page using the @For
>component with volatile="ognl:true" . Repeated searches which
>return 5000 items will result in an OutOfMemoryError exception. If I leave
>the
>page and then return or stay on the page I will ultimately get an
>OutOfMemoryError exception.
>
>I can view other pages after this exception but a
>repeat of trying to display 5000 items on this page will display an
>OutOfMemory exception.
>
>The only way to clear this problem is to restart the
>servlet container. This fails using either Jetty or Tomcat in both
>development and production environments (using different operating
>systems).
>
>All the variables displaying the list are explicitly
>declared in the .page specification and using initial-value set to null.
>
>I am using Tapestry 4.0 beta 8.
>
>The data is retrieved using Spring and Hibernate (no
>fancy patterns, standard Spring declarative transactions and using
>getHibernateTemplate()) and mapped to Tapestry using hivemodule.xml:
>
> <implementation
>
service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> <invoke-factory>
> <construct autowire-services="false"
>
class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> <event-listener
>service-id="hivemind.ShutdownCoordinator" />
> <set-object property="context"
>value="service:tapestry.globals.WebContext" />
> </construct>
> </invoke-factory>
> </implementation>
>
>and injecting the appropriate Spring bean.
>
>I am completely confused as to how to tie down the
>problem and isolate which section of code is causing the problem.
>
>Any help would be much appreciated.
>
>Paul
>
>
>
>
---------------------------------------------------------------------
>To unsubscribe, e-mail:
>tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail:
>tapestry-user-help@jakarta.apache.org
>
>
___________________________________________________________
To help you stay safe and secure online, we've developed the all new Yahoo!
Security Centre. http://uk.security.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by ausias vives <au...@yahoo.co.uk>.
Hi,
In my experience, the problem you're describing is not
related directly with Tapestry, It looks like more as
a standard problem with the available memory in the
servlet container.
I'll try to avoid returning 5000 objects at the same
time, depending on the size of the objects this can be
a large amount of memory, ant thus it can use all the
jetty or tomcat available memory. You can use a
browser to avoid returning all the objects at the same
time.
If you really need all those objects at the same time,
you should allow the servlet container to use more
memory (even though is always a good idea to increase
the server memory).
Definetly I recommend you to rethink the way the
results are presented to the user (think about having
10 users getting 5000 objects each of them... or even
more)
Regards
> I have a page which allows a user to search the
> database based on various
> criteria. I have restricted the number of returned
> items to 5000. I display
> the items in the same search page using the @For
> component with
> volatile="ognl:true" . Repeated searches which
> return 5000 items will result
> in an OutOfMemoryError exception. If I leave the
> page and then return or
> stay on the page I will ultimately get an
> OutOfMemoryError exception.
>
> I can view other pages after this exception but a
> repeat of trying to
> display 5000 items on this page will display an
> OutOfMemory exception.
>
> The only way to clear this problem is to restart the
> servlet container. This
> fails using either Jetty or Tomcat in both
> development and production
> environments (using different operating systems).
>
> All the variables displaying the list are explicitly
> declared in the .page
> specification and using initial-value set to null.
>
> I am using Tapestry 4.0 beta 8.
>
> The data is retrieved using Spring and Hibernate (no
> fancy patterns,
> standard Spring declarative transactions and using
> getHibernateTemplate())
> and mapped to Tapestry using hivemodule.xml:
>
> <implementation
>
service-id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> <invoke-factory>
> <construct autowire-services="false"
>
class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> <event-listener
> service-id="hivemind.ShutdownCoordinator" />
> <set-object property="context"
> value="service:tapestry.globals.WebContext" />
> </construct>
> </invoke-factory>
> </implementation>
>
> and injecting the appropriate Spring bean.
>
> I am completely confused as to how to tie down the
> problem and isolate which
> section of code is causing the problem.
>
> Any help would be much appreciated.
>
> Paul
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> tapestry-user-help@jakarta.apache.org
>
>
___________________________________________________________
To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
I looked at this problem for quite some time but did not use a profiler. I
discovered that my development system did not seem to fail (I never got it
to fail) when I did not disable the cache as indicated in Howards post. The
development system was running jetty. The other systems ran tomcat and were
still failing when the tapestry cache was not disabled. I then started
looking at my other Spring code and caching there but could not find any
problems. The OutOfMemoryError's always occurred during render after the
data had been obtained from the database. What was interesting is when I
added a some test code (so that the number of tapestry pages increased) the
code that failing before over so many renders failed quicker. I monitored
memory that was being used by tomcat and decided that by increasing the
default memory allocated to tomcat I would not run out of memory. Having
said all this I re-wrote the page anyway as suggested to have only a hundred
items rendered and paged the results.
After reading around the subject my conclusion was that it was just a
resource allocation issue in tomcat. But what I could not understand was
that with the tapestry cache turned on why would I not get the same page
instance and the page render should not take any more resources.
What you have found confirms my problem with the jetty development system
with cahing re-enabled but I still do not understand the production tomcat
system.
Paul
Patrick Casey <pa...@adelphia.net> wrote:
Shouldn't the old ones go out of scope though and get gc'd?
--- Pat
>-----Original Message-----
>From: Howard Lewis Ship [mailto:hlship@gmail.com]
>Sent: Thursday, October 06, 2005 9:52 AM
>To: Tapestry users; paolo.dona@gmail.com
>Subject: Re: OutOfMemoryError Tapestry 4.0
>
>That might be reasonable if you are running with
>-Dorg.apache.tapestry.disable-caching=true
>
>With caching disabled, Tapestry has to constantly create new enhanced
>subclasses for every page and every component.
>
<snip>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
Shouldn't the old ones go out of scope though and get gc'd?
--- Pat
> -----Original Message-----
> From: Howard Lewis Ship [mailto:hlship@gmail.com]
> Sent: Thursday, October 06, 2005 9:52 AM
> To: Tapestry users; paolo.dona@gmail.com
> Subject: Re: OutOfMemoryError Tapestry 4.0
>
> That might be reasonable if you are running with
> -Dorg.apache.tapestry.disable-caching=true
>
> With caching disabled, Tapestry has to constantly create new enhanced
> subclasses for every page and every component.
>
<snip>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by Leonardo Quijano Vincenzi <le...@dtqsoftware.com>.
Howard Lewis Ship escribió:
>That might be reasonable if you are running with
>-Dorg.apache.tapestry.disable-caching=true
>
>With caching disabled, Tapestry has to constantly create new enhanced
>subclasses for every page and every component.
>
>
Shouldn't it delete old classes?
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by Howard Lewis Ship <hl...@gmail.com>.
That might be reasonable if you are running with
-Dorg.apache.tapestry.disable-caching=true
With caching disabled, Tapestry has to constantly create new enhanced
subclasses for every page and every component.
On 10/6/05, Paolo Donà <pa...@gmail.com> wrote:
> Hi Guys,
> I'm experiencing the same OutOfMemoryError seloha pointed out.
> I have a simple application with Tap4/Spring/Hibernate, a page with 2
> PropertySelection components which submits to a hibernate query (via
> spring's HibernateTemplate) and shows a result page which uses a Table
> component. Every query loads kind about 30 records... so my app is not
> stressed as the seloha's.
> After 20 querys I get the OutOfMemoryError.
>
> I've tried to profile my app with YourKit. That's what I've done:
> 1) Launched my application (running on tomcat)
> 2) done a few back and forth navigations
> 3) took a 1st memory snapshot
> 4) done a few back and forth navigations
> 5) took a 2nd memory snapshot
>
> Then I've used the YourKit's compare snapshots feature and discovered that
> there are +600 new javassist.CtNewClass instances. They are contained in the
> 'classes' HashTable of the unique
> org.apache.hivemind.service.impl.HiveMindClassPool instance.
> HiveMindClassPool used 12MB on the 1st snapshot and raised to 30MB on the
> 2nd.
> I've been only navigating my 2 *already-loaded* pages so I don't understand
> why that object is growing so much.
> The HiveMindClassPool.classes HashTable had about 1500 entries at the 1st
> snapshot and about 3500 at the 2nd one.
>
> I'm not a profiler guru (neither a tapestry one) so maybe I'm missing
> something, but I'd like to help solving this problem.
> I gotta use this app in production systems too.. :-)
>
> Hope this can help,
> Paolo
>
> On 9/27/05, seloha . <se...@hotmail.com> wrote:
> >
> > I have added the code to remove objects from the hibernate session cache
> > (i.e. the use of evict() method). I have checked that it is run each time.
> > This has no affect, to prove it I ran some tests with and without this
> > code.
> > I was not convinced that it would have an affect since I am running two
> > production systems which have run for months without ever being stopped
> > with
> > very similar Spring / Hibernate configurations.
> >
> > I decided to run some fairly crude tests to see if the OutOfMemoryError's
> > were repeatable, these were as follows:
> >
> > 1) Run the same search (which produces the maximum set 5000 results) every
> > time not leaving the search page. The search returned 7 successful results
> > and returned an OutOfMemoryError on the 8 search.
> >
> > 2) Same search as 1) but left the search page after first successful
> > render
> > of results and then repeat each search again without leaving the search
> > page. The search returned 5 successful results and returned an
> > OutOfMemoryError on the 6 search.
> >
> > 3) Same search as 1) but left the search page after each successful render
> > of results and then repeat each search again when leaving the search page
> > always went to the same page. The search returned 3 successful results and
> > returned an OutOfMemoryError on the 4 search.
> >
> > The page which was moved to after the search page was the home page which
> > had no persistent objects fetched using Spring / Hibernate.
> >
> > The above is repeatable every time I do the same tests. Adding the evict
> > object code in spring / hibernate code has no affect.
> >
> > Is it fair to say that since the number of pages that can be successfully
> > rendered before an OutOfMemoryError exception occurs is reduced by
> > changing
> > pages the problem resides at the presentation (Tapestry) level.
> >
> > Any thoughts?
> >
> > Paul
> >
> >
> > Patrick Casey <pa...@adelphia.net> wrote:
> >
> > That looks like it'd work, yep. Dunno if the Hibernate session is
> > the root of your bug, but A) it might be and B) that looks like it'll
> > clear
> > it out.
> >
> > --- Pat
> >
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 1:15 PM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > >
> > >Pat,
> > >
> > >So in my case then since the Hibernate session is controlled by Spring
> > >after
> > >getting the large list I could subsequently call a method in my DAO which
> > >looks something like this:
> > >
> > >public void clearSessionObjects(List bigList) {
> > > Iterator bigListIt = bigList.iterator();
> > > while (bigListIt.hasNext()) {
> > > getHibernateTemplate().evict(bigListIt.next);
> > > }
> > >}
> > >
> > >And without such an eviction this could be what is causing the
> > >OutOfMemoryError.
> > >
> > >regards,
> > >
> > >Paul
> > >
> > >Patrick Casey <pa...@adelphia.net>
> > >
> > > To clean out a hibernate session:
> > >
> > > s.clear();
> > >
> > > That will clean everything out of it. Be warned though that it
> > >clears *everything* out of it, not just the stuff you recently loaded. A
> > >safer way is to evict each object one at a time as you load it e.g.
> > >
> > > Sesison s = HibHelper.getSession();
> > > Query q = s.createQuery("from bigList");
> > > List l = q.list();
> > > For (int x=0; x< l.size(); x++)
> > > s.evict(l.get(x));
> > > >-----Original Message-----
> > > >From: seloha . [mailto:seloha@hotmail.com]
> > > >Sent: Monday, September 26, 2005 12:45 PM
> > > >To: tapestry-user@jakarta.apache.org
> > > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > > >
> > > >Pat,
> > > >
> > > >1) Yes I am setting the object list to null.
> > > >
> > > >2) I have not put a log statement in the code to check it but I have
> > set
> > >a
> > > >break point in debug mode and each time the page was rendered the code
> > in
> > > >pageDetached(PageEvent event) was run.
> > > >
> > > >3) There is no other code which references the list object except the
> > > >rendering using the For component.
> > > >
> > > >4) Subsequent to adding the pageDetached(PageEvent event) I have not
> > run
> > > >it
> > > >on with the caching enabled. This I will do next.
> > > >
> > > >5) I am using hibernate for the persistent layer. I have always just
> > let
> > > >Spring look after the hibernate session using declarative transactions
> > >and
> > > >have never bypassed this mechanism. How do I evict go about evicting
> > the
> > > >objects after the transaction which picks them up. Can I just write a
> > > >piece
> > > >of code in my DAO which after picking the objects up then has something
> > > >like:
> > > >
> > > >getHibernateTemplate().evict(objects);
> > > >
> > > >As you can see I am fairly nieve about use of hibernate too.
> > > >
> > > >
> > > >Thanks,
> > > >
> > > >Paul
> > > >
> > > >
> > > >Patrick Casey <pa...@adelphia.net> wrote:
> > > >
> > > > Well, it really smells to me like a leak, largely because 5,000
> > > >objects, while a pain in the posterior to scroll through, is mouse nuts
> > > >from
> > > >a memory use standpoint (say each object is 10k (a whopper of an
> > object),
> > > >we're only looking at 50 M of memory here. Most object though are at
> > >least
> > > >an order of magnitude smaller than that.
> > > >
> > > > Just to reinterate though:
> > > >
> > > > It loads once fine.
> > > > If you keep loading the page, eventually you get an EOM error,
> > > >right?
> > > >
> > > > Some other things to look at:
> > > >
> > > >1) Unless Howard changed things or I'm remembering wrong, initial-value
> > > >*does not* reset object to that state. Rather it's the value at page
> > > >creation, not the value that something gets set to when a page goes
> > into
> > > >or
> > > >out of the pool. So to null something out after render, you need to
> > > >explicitly set it to null in the detach code (as it appears you are
> > > >doing).
> > > >
> > > >2) Can you put a log statement or something similar in your page
> > detatch
> > > >listener to make sure it's being called? I don't know how many times I
> > >got
> > > >bit by adding PageBeginRender methods to Tap 3 forms without
> > remembering
> > > >to
> > > >add implements PageEventListener to the class.
> > > >
> > > >3) Are there any other object (statics, the visit object, some other
> > > >property on the page) which reference your object chain?
> > > >
> > > >4) Do you still get the EOM with tapestry's cache turned off? If so,
> > it's
> > > >not your tapestry code that's hanging onto a reference. If not, then
> > the
> > > >problem lies in not re-iniitalizing something properly before a page
> > goes
> > > >back into the pool.
> > > >
> > > >5) Are you using Hibernate as your persistence layer? If so, are you
> > > >evicting these objects out of the session and/or loading them in a temp
> > > >session which you are subsequently closing? Objects loaded in a
> > Hibernate
> > > >session have the lifespan of the session, regardless of whether or not
> > > >your
> > > >code holds a reference to them.
> > > >
> > > >
> > > >
> > > > >-----Original Message-----
> > > > >From: seloha . [mailto:seloha@hotmail.com]
> > > > >Sent: Monday, September 26, 2005 11:55 AM
> > > > >To: tapestry-user@jakarta.apache.org
> > > > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > > > >
> > > > >Thanks Pat,
> > > > >
> > > > >One thing I was not doing which you pointed out was setting the list
> > to
> > > > >null
> > > > >in pageDetached(PageEvent event) so I added this and also included
> > > > >System.gc(). This unfortunately had no affect. The list uses abstract
> > > > >getter
> > > > >and setter and is initialized in the .page spec with
> > > > >initial-value="ognl:null".
> > > > >
> > > > >I have a number of selection models for PropertySelection components
> > > >which
> > > > >are initialized lazily which I am not resetting to null each time
> > (but
> > > > >there
> > > > >are only about 100 total items in these objects). Could these have
> > any
> > > > >affect.
> > > > >
> > > > >I am really poking around in the dark. Similar Spring and Hibernate
> > > > >mechanism that I wrote using Tapestry 3.0.3 is on a production system
> > >and
> > > > >has run with no problems for months. Admittedly I never go and
> > display
> > > > >5000
> > > > >objects at once though!
> > > > >
> > > > >I cannot see that I am inadvertently holding onto any objects in the
> > >code
> > > > >but you never know?
> > > > >
> > > > >Thanks again for your help,
> > > > >
> > > > >Paul
> > > > >
> > > > >
> > > > >Patrick Casey <pa...@adelphia.net> wrote:
> > > > >
> > > > > It sounds like a memory leak, but it could just be a slow garbage
> > > > >collector as well. Try adding:
> > > > >
> > > > > System.gc() to the end of your transaction to guarantee the garbage
> > > > >collector runs after each page render. Then see if repeated page
> > >renders
> > > > >still blow out your memory. If they do, then I suspect that somehow
> > you
> > > > >(or
> > > > >tapestry, or spring) is hanging onto a reference to those object
> > after
> > > > >page
> > > > >completion.
> > > > >
> > > > > --- Pat
> > > > >
> > > > > PS You *are* resetting your page properties to null (and nulling out
> > > > >the list of 5000 items) on the page's post-render cleanup phase,
> > right?
> > > > >
> > > > > >-----Original Message-----
> > > > > >From: seloha . [mailto:seloha@hotmail.com]
> > > > > >Sent: Monday, September 26, 2005 3:11 AM
> > > > > >To: tapestry-user@jakarta.apache.org
> > > > > >Subject: OutOfMemoryError Tapestry 4.0
> > > > > >
> > > > > >I have a page which allows a user to search the database based on
> > > >various
> > > > > >criteria. I have restricted the number of returned items to 5000. I
> > > > > >display
> > > > > >the items in the same search page using the @For component with
> > > > > >volatile="ognl:true" . Repeated searches which return 5000 items
> > will
> > > > > >result
> > > > > >in an OutOfMemoryError exception. If I leave the page and then
> > return
> > > >or
> > > > > >stay on the page I will ultimately get an OutOfMemoryError
> > exception.
> > > > > >
> > > > > >I can view other pages after this exception but a repeat of trying
> > to
> > > > > >display 5000 items on this page will display an OutOfMemory
> > >exception.
> > > > > >
> > > > > >The only way to clear this problem is to restart the servlet
> > >container.
> > > > > >This
> > > > > >fails using either Jetty or Tomcat in both development and
> > production
> > > > > >environments (using different operating systems).
> > > > > >
> > > > > >All the variables displaying the list are explicitly declared in
> > the
> > > > >.page
> > > > > >specification and using initial-value set to null.
> > > > > >
> > > > > >I am using Tapestry 4.0 beta 8.
> > > > > >
> > > > > >The data is retrieved using Spring and Hibernate (no fancy
> > patterns,
> > > > > >standard Spring declarative transactions and using
> > > > >getHibernateTemplate())
> > > > > >and mapped to Tapestry using hivemodule.xml:
> > > > > >
> > > > > > <implementation service-
> > > > > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > > > > <invoke-factory>
> > > > > > <construct autowire-services="false"
> > > > > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > > > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > > > > <set-object property="context"
> > > > > >value="service:tapestry.globals.WebContext" />
> > > > > > </construct>
> > > > > > </invoke-factory>
> > > > > > </implementation>
> > > > > >
> > > > > >and injecting the appropriate Spring bean.
> > > > > >
> > > > > >I am completely confused as to how to tie down the problem and
> > >isolate
> > > > > >which
> > > > > >section of code is causing the problem.
> > > > > >
> > > > > >Any help would be much appreciated.
> > > > > >
> > > > > >Paul
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > >---------------------------------------------------------------------
> > > > > >To unsubscribe, e-mail:
> > tapestry-user-unsubscribe@jakarta.apache.org
> > > > > >For additional commands, e-mail: tapestry-user-
> > >help@jakarta.apache.org
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >---------------------------------------------------------------------
> > > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > > >For additional commands, e-mail:
> > tapestry-user-help@jakarta.apache.org
> > > > >
> > > > >
> > > > >
> > > > >---------------------------------------------------------------------
> > > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > > >For additional commands, e-mail:
> > tapestry-user-help@jakarta.apache.org
> > > >
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail:
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> > >
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
>
>
--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind
Professional Tapestry training, mentoring, support
and project work. http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
Re: OutOfMemoryError Tapestry 4.0
Posted by Paolo Donà <pa...@gmail.com>.
Hi Guys,
I'm experiencing the same OutOfMemoryError seloha pointed out.
I have a simple application with Tap4/Spring/Hibernate, a page with 2
PropertySelection components which submits to a hibernate query (via
spring's HibernateTemplate) and shows a result page which uses a Table
component. Every query loads kind about 30 records... so my app is not
stressed as the seloha's.
After 20 querys I get the OutOfMemoryError.
I've tried to profile my app with YourKit. That's what I've done:
1) Launched my application (running on tomcat)
2) done a few back and forth navigations
3) took a 1st memory snapshot
4) done a few back and forth navigations
5) took a 2nd memory snapshot
Then I've used the YourKit's compare snapshots feature and discovered that
there are +600 new javassist.CtNewClass instances. They are contained in the
'classes' HashTable of the unique
org.apache.hivemind.service.impl.HiveMindClassPool instance.
HiveMindClassPool used 12MB on the 1st snapshot and raised to 30MB on the
2nd.
I've been only navigating my 2 *already-loaded* pages so I don't understand
why that object is growing so much.
The HiveMindClassPool.classes HashTable had about 1500 entries at the 1st
snapshot and about 3500 at the 2nd one.
I'm not a profiler guru (neither a tapestry one) so maybe I'm missing
something, but I'd like to help solving this problem.
I gotta use this app in production systems too.. :-)
Hope this can help,
Paolo
On 9/27/05, seloha . <se...@hotmail.com> wrote:
>
> I have added the code to remove objects from the hibernate session cache
> (i.e. the use of evict() method). I have checked that it is run each time.
> This has no affect, to prove it I ran some tests with and without this
> code.
> I was not convinced that it would have an affect since I am running two
> production systems which have run for months without ever being stopped
> with
> very similar Spring / Hibernate configurations.
>
> I decided to run some fairly crude tests to see if the OutOfMemoryError's
> were repeatable, these were as follows:
>
> 1) Run the same search (which produces the maximum set 5000 results) every
> time not leaving the search page. The search returned 7 successful results
> and returned an OutOfMemoryError on the 8 search.
>
> 2) Same search as 1) but left the search page after first successful
> render
> of results and then repeat each search again without leaving the search
> page. The search returned 5 successful results and returned an
> OutOfMemoryError on the 6 search.
>
> 3) Same search as 1) but left the search page after each successful render
> of results and then repeat each search again when leaving the search page
> always went to the same page. The search returned 3 successful results and
> returned an OutOfMemoryError on the 4 search.
>
> The page which was moved to after the search page was the home page which
> had no persistent objects fetched using Spring / Hibernate.
>
> The above is repeatable every time I do the same tests. Adding the evict
> object code in spring / hibernate code has no affect.
>
> Is it fair to say that since the number of pages that can be successfully
> rendered before an OutOfMemoryError exception occurs is reduced by
> changing
> pages the problem resides at the presentation (Tapestry) level.
>
> Any thoughts?
>
> Paul
>
>
> Patrick Casey <pa...@adelphia.net> wrote:
>
> That looks like it'd work, yep. Dunno if the Hibernate session is
> the root of your bug, but A) it might be and B) that looks like it'll
> clear
> it out.
>
> --- Pat
>
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 1:15 PM
> >To: tapestry-user@jakarta.apache.org
> >Subject: RE: OutOfMemoryError Tapestry 4.0
> >
> >Pat,
> >
> >So in my case then since the Hibernate session is controlled by Spring
> >after
> >getting the large list I could subsequently call a method in my DAO which
> >looks something like this:
> >
> >public void clearSessionObjects(List bigList) {
> > Iterator bigListIt = bigList.iterator();
> > while (bigListIt.hasNext()) {
> > getHibernateTemplate().evict(bigListIt.next);
> > }
> >}
> >
> >And without such an eviction this could be what is causing the
> >OutOfMemoryError.
> >
> >regards,
> >
> >Paul
> >
> >Patrick Casey <pa...@adelphia.net>
> >
> > To clean out a hibernate session:
> >
> > s.clear();
> >
> > That will clean everything out of it. Be warned though that it
> >clears *everything* out of it, not just the stuff you recently loaded. A
> >safer way is to evict each object one at a time as you load it e.g.
> >
> > Sesison s = HibHelper.getSession();
> > Query q = s.createQuery("from bigList");
> > List l = q.list();
> > For (int x=0; x< l.size(); x++)
> > s.evict(l.get(x));
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 12:45 PM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > >
> > >Pat,
> > >
> > >1) Yes I am setting the object list to null.
> > >
> > >2) I have not put a log statement in the code to check it but I have
> set
> >a
> > >break point in debug mode and each time the page was rendered the code
> in
> > >pageDetached(PageEvent event) was run.
> > >
> > >3) There is no other code which references the list object except the
> > >rendering using the For component.
> > >
> > >4) Subsequent to adding the pageDetached(PageEvent event) I have not
> run
> > >it
> > >on with the caching enabled. This I will do next.
> > >
> > >5) I am using hibernate for the persistent layer. I have always just
> let
> > >Spring look after the hibernate session using declarative transactions
> >and
> > >have never bypassed this mechanism. How do I evict go about evicting
> the
> > >objects after the transaction which picks them up. Can I just write a
> > >piece
> > >of code in my DAO which after picking the objects up then has something
> > >like:
> > >
> > >getHibernateTemplate().evict(objects);
> > >
> > >As you can see I am fairly nieve about use of hibernate too.
> > >
> > >
> > >Thanks,
> > >
> > >Paul
> > >
> > >
> > >Patrick Casey <pa...@adelphia.net> wrote:
> > >
> > > Well, it really smells to me like a leak, largely because 5,000
> > >objects, while a pain in the posterior to scroll through, is mouse nuts
> > >from
> > >a memory use standpoint (say each object is 10k (a whopper of an
> object),
> > >we're only looking at 50 M of memory here. Most object though are at
> >least
> > >an order of magnitude smaller than that.
> > >
> > > Just to reinterate though:
> > >
> > > It loads once fine.
> > > If you keep loading the page, eventually you get an EOM error,
> > >right?
> > >
> > > Some other things to look at:
> > >
> > >1) Unless Howard changed things or I'm remembering wrong, initial-value
> > >*does not* reset object to that state. Rather it's the value at page
> > >creation, not the value that something gets set to when a page goes
> into
> > >or
> > >out of the pool. So to null something out after render, you need to
> > >explicitly set it to null in the detach code (as it appears you are
> > >doing).
> > >
> > >2) Can you put a log statement or something similar in your page
> detatch
> > >listener to make sure it's being called? I don't know how many times I
> >got
> > >bit by adding PageBeginRender methods to Tap 3 forms without
> remembering
> > >to
> > >add implements PageEventListener to the class.
> > >
> > >3) Are there any other object (statics, the visit object, some other
> > >property on the page) which reference your object chain?
> > >
> > >4) Do you still get the EOM with tapestry's cache turned off? If so,
> it's
> > >not your tapestry code that's hanging onto a reference. If not, then
> the
> > >problem lies in not re-iniitalizing something properly before a page
> goes
> > >back into the pool.
> > >
> > >5) Are you using Hibernate as your persistence layer? If so, are you
> > >evicting these objects out of the session and/or loading them in a temp
> > >session which you are subsequently closing? Objects loaded in a
> Hibernate
> > >session have the lifespan of the session, regardless of whether or not
> > >your
> > >code holds a reference to them.
> > >
> > >
> > >
> > > >-----Original Message-----
> > > >From: seloha . [mailto:seloha@hotmail.com]
> > > >Sent: Monday, September 26, 2005 11:55 AM
> > > >To: tapestry-user@jakarta.apache.org
> > > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > > >
> > > >Thanks Pat,
> > > >
> > > >One thing I was not doing which you pointed out was setting the list
> to
> > > >null
> > > >in pageDetached(PageEvent event) so I added this and also included
> > > >System.gc(). This unfortunately had no affect. The list uses abstract
> > > >getter
> > > >and setter and is initialized in the .page spec with
> > > >initial-value="ognl:null".
> > > >
> > > >I have a number of selection models for PropertySelection components
> > >which
> > > >are initialized lazily which I am not resetting to null each time
> (but
> > > >there
> > > >are only about 100 total items in these objects). Could these have
> any
> > > >affect.
> > > >
> > > >I am really poking around in the dark. Similar Spring and Hibernate
> > > >mechanism that I wrote using Tapestry 3.0.3 is on a production system
> >and
> > > >has run with no problems for months. Admittedly I never go and
> display
> > > >5000
> > > >objects at once though!
> > > >
> > > >I cannot see that I am inadvertently holding onto any objects in the
> >code
> > > >but you never know?
> > > >
> > > >Thanks again for your help,
> > > >
> > > >Paul
> > > >
> > > >
> > > >Patrick Casey <pa...@adelphia.net> wrote:
> > > >
> > > > It sounds like a memory leak, but it could just be a slow garbage
> > > >collector as well. Try adding:
> > > >
> > > > System.gc() to the end of your transaction to guarantee the garbage
> > > >collector runs after each page render. Then see if repeated page
> >renders
> > > >still blow out your memory. If they do, then I suspect that somehow
> you
> > > >(or
> > > >tapestry, or spring) is hanging onto a reference to those object
> after
> > > >page
> > > >completion.
> > > >
> > > > --- Pat
> > > >
> > > > PS You *are* resetting your page properties to null (and nulling out
> > > >the list of 5000 items) on the page's post-render cleanup phase,
> right?
> > > >
> > > > >-----Original Message-----
> > > > >From: seloha . [mailto:seloha@hotmail.com]
> > > > >Sent: Monday, September 26, 2005 3:11 AM
> > > > >To: tapestry-user@jakarta.apache.org
> > > > >Subject: OutOfMemoryError Tapestry 4.0
> > > > >
> > > > >I have a page which allows a user to search the database based on
> > >various
> > > > >criteria. I have restricted the number of returned items to 5000. I
> > > > >display
> > > > >the items in the same search page using the @For component with
> > > > >volatile="ognl:true" . Repeated searches which return 5000 items
> will
> > > > >result
> > > > >in an OutOfMemoryError exception. If I leave the page and then
> return
> > >or
> > > > >stay on the page I will ultimately get an OutOfMemoryError
> exception.
> > > > >
> > > > >I can view other pages after this exception but a repeat of trying
> to
> > > > >display 5000 items on this page will display an OutOfMemory
> >exception.
> > > > >
> > > > >The only way to clear this problem is to restart the servlet
> >container.
> > > > >This
> > > > >fails using either Jetty or Tomcat in both development and
> production
> > > > >environments (using different operating systems).
> > > > >
> > > > >All the variables displaying the list are explicitly declared in
> the
> > > >.page
> > > > >specification and using initial-value set to null.
> > > > >
> > > > >I am using Tapestry 4.0 beta 8.
> > > > >
> > > > >The data is retrieved using Spring and Hibernate (no fancy
> patterns,
> > > > >standard Spring declarative transactions and using
> > > >getHibernateTemplate())
> > > > >and mapped to Tapestry using hivemodule.xml:
> > > > >
> > > > > <implementation service-
> > > > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > > > <invoke-factory>
> > > > > <construct autowire-services="false"
> > > > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > > > <set-object property="context"
> > > > >value="service:tapestry.globals.WebContext" />
> > > > > </construct>
> > > > > </invoke-factory>
> > > > > </implementation>
> > > > >
> > > > >and injecting the appropriate Spring bean.
> > > > >
> > > > >I am completely confused as to how to tie down the problem and
> >isolate
> > > > >which
> > > > >section of code is causing the problem.
> > > > >
> > > > >Any help would be much appreciated.
> > > > >
> > > > >Paul
> > > > >
> > > > >
> > > > >
> > > >
> >---------------------------------------------------------------------
> > > > >To unsubscribe, e-mail:
> tapestry-user-unsubscribe@jakarta.apache.org
> > > > >For additional commands, e-mail: tapestry-user-
> >help@jakarta.apache.org
> > > >
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail:
> tapestry-user-help@jakarta.apache.org
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail:
> tapestry-user-help@jakarta.apache.org
> > >
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail:
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
RE: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
I have added the code to remove objects from the hibernate session cache
(i.e. the use of evict() method). I have checked that it is run each time.
This has no affect, to prove it I ran some tests with and without this code.
I was not convinced that it would have an affect since I am running two
production systems which have run for months without ever being stopped with
very similar Spring / Hibernate configurations.
I decided to run some fairly crude tests to see if the OutOfMemoryError's
were repeatable, these were as follows:
1) Run the same search (which produces the maximum set 5000 results) every
time not leaving the search page. The search returned 7 successful results
and returned an OutOfMemoryError on the 8 search.
2) Same search as 1) but left the search page after first successful render
of results and then repeat each search again without leaving the search
page. The search returned 5 successful results and returned an
OutOfMemoryError on the 6 search.
3) Same search as 1) but left the search page after each successful render
of results and then repeat each search again when leaving the search page
always went to the same page. The search returned 3 successful results and
returned an OutOfMemoryError on the 4 search.
The page which was moved to after the search page was the home page which
had no persistent objects fetched using Spring / Hibernate.
The above is repeatable every time I do the same tests. Adding the evict
object code in spring / hibernate code has no affect.
Is it fair to say that since the number of pages that can be successfully
rendered before an OutOfMemoryError exception occurs is reduced by changing
pages the problem resides at the presentation (Tapestry) level.
Any thoughts?
Paul
Patrick Casey <pa...@adelphia.net> wrote:
That looks like it'd work, yep. Dunno if the Hibernate session is
the root of your bug, but A) it might be and B) that looks like it'll clear
it out.
--- Pat
>-----Original Message-----
>From: seloha . [mailto:seloha@hotmail.com]
>Sent: Monday, September 26, 2005 1:15 PM
>To: tapestry-user@jakarta.apache.org
>Subject: RE: OutOfMemoryError Tapestry 4.0
>
>Pat,
>
>So in my case then since the Hibernate session is controlled by Spring
>after
>getting the large list I could subsequently call a method in my DAO which
>looks something like this:
>
>public void clearSessionObjects(List bigList) {
> Iterator bigListIt = bigList.iterator();
> while (bigListIt.hasNext()) {
> getHibernateTemplate().evict(bigListIt.next);
> }
>}
>
>And without such an eviction this could be what is causing the
>OutOfMemoryError.
>
>regards,
>
>Paul
>
>Patrick Casey <pa...@adelphia.net>
>
> To clean out a hibernate session:
>
> s.clear();
>
> That will clean everything out of it. Be warned though that it
>clears *everything* out of it, not just the stuff you recently loaded. A
>safer way is to evict each object one at a time as you load it e.g.
>
> Sesison s = HibHelper.getSession();
> Query q = s.createQuery("from bigList");
> List l = q.list();
> For (int x=0; x< l.size(); x++)
> s.evict(l.get(x));
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 12:45 PM
> >To: tapestry-user@jakarta.apache.org
> >Subject: RE: OutOfMemoryError Tapestry 4.0
> >
> >Pat,
> >
> >1) Yes I am setting the object list to null.
> >
> >2) I have not put a log statement in the code to check it but I have set
>a
> >break point in debug mode and each time the page was rendered the code in
> >pageDetached(PageEvent event) was run.
> >
> >3) There is no other code which references the list object except the
> >rendering using the For component.
> >
> >4) Subsequent to adding the pageDetached(PageEvent event) I have not run
> >it
> >on with the caching enabled. This I will do next.
> >
> >5) I am using hibernate for the persistent layer. I have always just let
> >Spring look after the hibernate session using declarative transactions
>and
> >have never bypassed this mechanism. How do I evict go about evicting the
> >objects after the transaction which picks them up. Can I just write a
> >piece
> >of code in my DAO which after picking the objects up then has something
> >like:
> >
> >getHibernateTemplate().evict(objects);
> >
> >As you can see I am fairly nieve about use of hibernate too.
> >
> >
> >Thanks,
> >
> >Paul
> >
> >
> >Patrick Casey <pa...@adelphia.net> wrote:
> >
> > Well, it really smells to me like a leak, largely because 5,000
> >objects, while a pain in the posterior to scroll through, is mouse nuts
> >from
> >a memory use standpoint (say each object is 10k (a whopper of an object),
> >we're only looking at 50 M of memory here. Most object though are at
>least
> >an order of magnitude smaller than that.
> >
> > Just to reinterate though:
> >
> > It loads once fine.
> > If you keep loading the page, eventually you get an EOM error,
> >right?
> >
> > Some other things to look at:
> >
> >1) Unless Howard changed things or I'm remembering wrong, initial-value
> >*does not* reset object to that state. Rather it's the value at page
> >creation, not the value that something gets set to when a page goes into
> >or
> >out of the pool. So to null something out after render, you need to
> >explicitly set it to null in the detach code (as it appears you are
> >doing).
> >
> >2) Can you put a log statement or something similar in your page detatch
> >listener to make sure it's being called? I don't know how many times I
>got
> >bit by adding PageBeginRender methods to Tap 3 forms without remembering
> >to
> >add implements PageEventListener to the class.
> >
> >3) Are there any other object (statics, the visit object, some other
> >property on the page) which reference your object chain?
> >
> >4) Do you still get the EOM with tapestry's cache turned off? If so, it's
> >not your tapestry code that's hanging onto a reference. If not, then the
> >problem lies in not re-iniitalizing something properly before a page goes
> >back into the pool.
> >
> >5) Are you using Hibernate as your persistence layer? If so, are you
> >evicting these objects out of the session and/or loading them in a temp
> >session which you are subsequently closing? Objects loaded in a Hibernate
> >session have the lifespan of the session, regardless of whether or not
> >your
> >code holds a reference to them.
> >
> >
> >
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 11:55 AM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > >
> > >Thanks Pat,
> > >
> > >One thing I was not doing which you pointed out was setting the list to
> > >null
> > >in pageDetached(PageEvent event) so I added this and also included
> > >System.gc(). This unfortunately had no affect. The list uses abstract
> > >getter
> > >and setter and is initialized in the .page spec with
> > >initial-value="ognl:null".
> > >
> > >I have a number of selection models for PropertySelection components
> >which
> > >are initialized lazily which I am not resetting to null each time (but
> > >there
> > >are only about 100 total items in these objects). Could these have any
> > >affect.
> > >
> > >I am really poking around in the dark. Similar Spring and Hibernate
> > >mechanism that I wrote using Tapestry 3.0.3 is on a production system
>and
> > >has run with no problems for months. Admittedly I never go and display
> > >5000
> > >objects at once though!
> > >
> > >I cannot see that I am inadvertently holding onto any objects in the
>code
> > >but you never know?
> > >
> > >Thanks again for your help,
> > >
> > >Paul
> > >
> > >
> > >Patrick Casey <pa...@adelphia.net> wrote:
> > >
> > > It sounds like a memory leak, but it could just be a slow garbage
> > >collector as well. Try adding:
> > >
> > > System.gc() to the end of your transaction to guarantee the garbage
> > >collector runs after each page render. Then see if repeated page
>renders
> > >still blow out your memory. If they do, then I suspect that somehow you
> > >(or
> > >tapestry, or spring) is hanging onto a reference to those object after
> > >page
> > >completion.
> > >
> > > --- Pat
> > >
> > > PS You *are* resetting your page properties to null (and nulling out
> > >the list of 5000 items) on the page's post-render cleanup phase, right?
> > >
> > > >-----Original Message-----
> > > >From: seloha . [mailto:seloha@hotmail.com]
> > > >Sent: Monday, September 26, 2005 3:11 AM
> > > >To: tapestry-user@jakarta.apache.org
> > > >Subject: OutOfMemoryError Tapestry 4.0
> > > >
> > > >I have a page which allows a user to search the database based on
> >various
> > > >criteria. I have restricted the number of returned items to 5000. I
> > > >display
> > > >the items in the same search page using the @For component with
> > > >volatile="ognl:true" . Repeated searches which return 5000 items will
> > > >result
> > > >in an OutOfMemoryError exception. If I leave the page and then return
> >or
> > > >stay on the page I will ultimately get an OutOfMemoryError exception.
> > > >
> > > >I can view other pages after this exception but a repeat of trying to
> > > >display 5000 items on this page will display an OutOfMemory
>exception.
> > > >
> > > >The only way to clear this problem is to restart the servlet
>container.
> > > >This
> > > >fails using either Jetty or Tomcat in both development and production
> > > >environments (using different operating systems).
> > > >
> > > >All the variables displaying the list are explicitly declared in the
> > >.page
> > > >specification and using initial-value set to null.
> > > >
> > > >I am using Tapestry 4.0 beta 8.
> > > >
> > > >The data is retrieved using Spring and Hibernate (no fancy patterns,
> > > >standard Spring declarative transactions and using
> > >getHibernateTemplate())
> > > >and mapped to Tapestry using hivemodule.xml:
> > > >
> > > > <implementation service-
> > > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > > <invoke-factory>
> > > > <construct autowire-services="false"
> > > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > > <set-object property="context"
> > > >value="service:tapestry.globals.WebContext" />
> > > > </construct>
> > > > </invoke-factory>
> > > > </implementation>
> > > >
> > > >and injecting the appropriate Spring bean.
> > > >
> > > >I am completely confused as to how to tie down the problem and
>isolate
> > > >which
> > > >section of code is causing the problem.
> > > >
> > > >Any help would be much appreciated.
> > > >
> > > >Paul
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail: tapestry-user-
>help@jakarta.apache.org
> > >
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail:
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
That looks like it'd work, yep. Dunno if the Hibernate session is
the root of your bug, but A) it might be and B) that looks like it'll clear
it out.
--- Pat
> -----Original Message-----
> From: seloha . [mailto:seloha@hotmail.com]
> Sent: Monday, September 26, 2005 1:15 PM
> To: tapestry-user@jakarta.apache.org
> Subject: RE: OutOfMemoryError Tapestry 4.0
>
> Pat,
>
> So in my case then since the Hibernate session is controlled by Spring
> after
> getting the large list I could subsequently call a method in my DAO which
> looks something like this:
>
> public void clearSessionObjects(List bigList) {
> Iterator bigListIt = bigList.iterator();
> while (bigListIt.hasNext()) {
> getHibernateTemplate().evict(bigListIt.next);
> }
> }
>
> And without such an eviction this could be what is causing the
> OutOfMemoryError.
>
> regards,
>
> Paul
>
> Patrick Casey <pa...@adelphia.net>
>
> To clean out a hibernate session:
>
> s.clear();
>
> That will clean everything out of it. Be warned though that it
> clears *everything* out of it, not just the stuff you recently loaded. A
> safer way is to evict each object one at a time as you load it e.g.
>
> Sesison s = HibHelper.getSession();
> Query q = s.createQuery("from bigList");
> List l = q.list();
> For (int x=0; x< l.size(); x++)
> s.evict(l.get(x));
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 12:45 PM
> >To: tapestry-user@jakarta.apache.org
> >Subject: RE: OutOfMemoryError Tapestry 4.0
> >
> >Pat,
> >
> >1) Yes I am setting the object list to null.
> >
> >2) I have not put a log statement in the code to check it but I have set
> a
> >break point in debug mode and each time the page was rendered the code in
> >pageDetached(PageEvent event) was run.
> >
> >3) There is no other code which references the list object except the
> >rendering using the For component.
> >
> >4) Subsequent to adding the pageDetached(PageEvent event) I have not run
> >it
> >on with the caching enabled. This I will do next.
> >
> >5) I am using hibernate for the persistent layer. I have always just let
> >Spring look after the hibernate session using declarative transactions
> and
> >have never bypassed this mechanism. How do I evict go about evicting the
> >objects after the transaction which picks them up. Can I just write a
> >piece
> >of code in my DAO which after picking the objects up then has something
> >like:
> >
> >getHibernateTemplate().evict(objects);
> >
> >As you can see I am fairly nieve about use of hibernate too.
> >
> >
> >Thanks,
> >
> >Paul
> >
> >
> >Patrick Casey <pa...@adelphia.net> wrote:
> >
> > Well, it really smells to me like a leak, largely because 5,000
> >objects, while a pain in the posterior to scroll through, is mouse nuts
> >from
> >a memory use standpoint (say each object is 10k (a whopper of an object),
> >we're only looking at 50 M of memory here. Most object though are at
> least
> >an order of magnitude smaller than that.
> >
> > Just to reinterate though:
> >
> > It loads once fine.
> > If you keep loading the page, eventually you get an EOM error,
> >right?
> >
> > Some other things to look at:
> >
> >1) Unless Howard changed things or I'm remembering wrong, initial-value
> >*does not* reset object to that state. Rather it's the value at page
> >creation, not the value that something gets set to when a page goes into
> >or
> >out of the pool. So to null something out after render, you need to
> >explicitly set it to null in the detach code (as it appears you are
> >doing).
> >
> >2) Can you put a log statement or something similar in your page detatch
> >listener to make sure it's being called? I don't know how many times I
> got
> >bit by adding PageBeginRender methods to Tap 3 forms without remembering
> >to
> >add implements PageEventListener to the class.
> >
> >3) Are there any other object (statics, the visit object, some other
> >property on the page) which reference your object chain?
> >
> >4) Do you still get the EOM with tapestry's cache turned off? If so, it's
> >not your tapestry code that's hanging onto a reference. If not, then the
> >problem lies in not re-iniitalizing something properly before a page goes
> >back into the pool.
> >
> >5) Are you using Hibernate as your persistence layer? If so, are you
> >evicting these objects out of the session and/or loading them in a temp
> >session which you are subsequently closing? Objects loaded in a Hibernate
> >session have the lifespan of the session, regardless of whether or not
> >your
> >code holds a reference to them.
> >
> >
> >
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 11:55 AM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: RE: OutOfMemoryError Tapestry 4.0
> > >
> > >Thanks Pat,
> > >
> > >One thing I was not doing which you pointed out was setting the list to
> > >null
> > >in pageDetached(PageEvent event) so I added this and also included
> > >System.gc(). This unfortunately had no affect. The list uses abstract
> > >getter
> > >and setter and is initialized in the .page spec with
> > >initial-value="ognl:null".
> > >
> > >I have a number of selection models for PropertySelection components
> >which
> > >are initialized lazily which I am not resetting to null each time (but
> > >there
> > >are only about 100 total items in these objects). Could these have any
> > >affect.
> > >
> > >I am really poking around in the dark. Similar Spring and Hibernate
> > >mechanism that I wrote using Tapestry 3.0.3 is on a production system
> and
> > >has run with no problems for months. Admittedly I never go and display
> > >5000
> > >objects at once though!
> > >
> > >I cannot see that I am inadvertently holding onto any objects in the
> code
> > >but you never know?
> > >
> > >Thanks again for your help,
> > >
> > >Paul
> > >
> > >
> > >Patrick Casey <pa...@adelphia.net> wrote:
> > >
> > > It sounds like a memory leak, but it could just be a slow garbage
> > >collector as well. Try adding:
> > >
> > > System.gc() to the end of your transaction to guarantee the garbage
> > >collector runs after each page render. Then see if repeated page
> renders
> > >still blow out your memory. If they do, then I suspect that somehow you
> > >(or
> > >tapestry, or spring) is hanging onto a reference to those object after
> > >page
> > >completion.
> > >
> > > --- Pat
> > >
> > > PS You *are* resetting your page properties to null (and nulling out
> > >the list of 5000 items) on the page's post-render cleanup phase, right?
> > >
> > > >-----Original Message-----
> > > >From: seloha . [mailto:seloha@hotmail.com]
> > > >Sent: Monday, September 26, 2005 3:11 AM
> > > >To: tapestry-user@jakarta.apache.org
> > > >Subject: OutOfMemoryError Tapestry 4.0
> > > >
> > > >I have a page which allows a user to search the database based on
> >various
> > > >criteria. I have restricted the number of returned items to 5000. I
> > > >display
> > > >the items in the same search page using the @For component with
> > > >volatile="ognl:true" . Repeated searches which return 5000 items will
> > > >result
> > > >in an OutOfMemoryError exception. If I leave the page and then return
> >or
> > > >stay on the page I will ultimately get an OutOfMemoryError exception.
> > > >
> > > >I can view other pages after this exception but a repeat of trying to
> > > >display 5000 items on this page will display an OutOfMemory
> exception.
> > > >
> > > >The only way to clear this problem is to restart the servlet
> container.
> > > >This
> > > >fails using either Jetty or Tomcat in both development and production
> > > >environments (using different operating systems).
> > > >
> > > >All the variables displaying the list are explicitly declared in the
> > >.page
> > > >specification and using initial-value set to null.
> > > >
> > > >I am using Tapestry 4.0 beta 8.
> > > >
> > > >The data is retrieved using Spring and Hibernate (no fancy patterns,
> > > >standard Spring declarative transactions and using
> > >getHibernateTemplate())
> > > >and mapped to Tapestry using hivemodule.xml:
> > > >
> > > > <implementation service-
> > > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > > <invoke-factory>
> > > > <construct autowire-services="false"
> > > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > > <set-object property="context"
> > > >value="service:tapestry.globals.WebContext" />
> > > > </construct>
> > > > </invoke-factory>
> > > > </implementation>
> > > >
> > > >and injecting the appropriate Spring bean.
> > > >
> > > >I am completely confused as to how to tie down the problem and
> isolate
> > > >which
> > > >section of code is causing the problem.
> > > >
> > > >Any help would be much appreciated.
> > > >
> > > >Paul
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail: tapestry-user-
> help@jakarta.apache.org
> > >
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail:
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
Pat,
So in my case then since the Hibernate session is controlled by Spring after
getting the large list I could subsequently call a method in my DAO which
looks something like this:
public void clearSessionObjects(List bigList) {
Iterator bigListIt = bigList.iterator();
while (bigListIt.hasNext()) {
getHibernateTemplate().evict(bigListIt.next);
}
}
And without such an eviction this could be what is causing the
OutOfMemoryError.
regards,
Paul
Patrick Casey <pa...@adelphia.net>
To clean out a hibernate session:
s.clear();
That will clean everything out of it. Be warned though that it
clears *everything* out of it, not just the stuff you recently loaded. A
safer way is to evict each object one at a time as you load it e.g.
Sesison s = HibHelper.getSession();
Query q = s.createQuery("from bigList");
List l = q.list();
For (int x=0; x< l.size(); x++)
s.evict(l.get(x));
>-----Original Message-----
>From: seloha . [mailto:seloha@hotmail.com]
>Sent: Monday, September 26, 2005 12:45 PM
>To: tapestry-user@jakarta.apache.org
>Subject: RE: OutOfMemoryError Tapestry 4.0
>
>Pat,
>
>1) Yes I am setting the object list to null.
>
>2) I have not put a log statement in the code to check it but I have set a
>break point in debug mode and each time the page was rendered the code in
>pageDetached(PageEvent event) was run.
>
>3) There is no other code which references the list object except the
>rendering using the For component.
>
>4) Subsequent to adding the pageDetached(PageEvent event) I have not run
>it
>on with the caching enabled. This I will do next.
>
>5) I am using hibernate for the persistent layer. I have always just let
>Spring look after the hibernate session using declarative transactions and
>have never bypassed this mechanism. How do I evict go about evicting the
>objects after the transaction which picks them up. Can I just write a
>piece
>of code in my DAO which after picking the objects up then has something
>like:
>
>getHibernateTemplate().evict(objects);
>
>As you can see I am fairly nieve about use of hibernate too.
>
>
>Thanks,
>
>Paul
>
>
>Patrick Casey <pa...@adelphia.net> wrote:
>
> Well, it really smells to me like a leak, largely because 5,000
>objects, while a pain in the posterior to scroll through, is mouse nuts
>from
>a memory use standpoint (say each object is 10k (a whopper of an object),
>we're only looking at 50 M of memory here. Most object though are at least
>an order of magnitude smaller than that.
>
> Just to reinterate though:
>
> It loads once fine.
> If you keep loading the page, eventually you get an EOM error,
>right?
>
> Some other things to look at:
>
>1) Unless Howard changed things or I'm remembering wrong, initial-value
>*does not* reset object to that state. Rather it's the value at page
>creation, not the value that something gets set to when a page goes into
>or
>out of the pool. So to null something out after render, you need to
>explicitly set it to null in the detach code (as it appears you are
>doing).
>
>2) Can you put a log statement or something similar in your page detatch
>listener to make sure it's being called? I don't know how many times I got
>bit by adding PageBeginRender methods to Tap 3 forms without remembering
>to
>add implements PageEventListener to the class.
>
>3) Are there any other object (statics, the visit object, some other
>property on the page) which reference your object chain?
>
>4) Do you still get the EOM with tapestry's cache turned off? If so, it's
>not your tapestry code that's hanging onto a reference. If not, then the
>problem lies in not re-iniitalizing something properly before a page goes
>back into the pool.
>
>5) Are you using Hibernate as your persistence layer? If so, are you
>evicting these objects out of the session and/or loading them in a temp
>session which you are subsequently closing? Objects loaded in a Hibernate
>session have the lifespan of the session, regardless of whether or not
>your
>code holds a reference to them.
>
>
>
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 11:55 AM
> >To: tapestry-user@jakarta.apache.org
> >Subject: RE: OutOfMemoryError Tapestry 4.0
> >
> >Thanks Pat,
> >
> >One thing I was not doing which you pointed out was setting the list to
> >null
> >in pageDetached(PageEvent event) so I added this and also included
> >System.gc(). This unfortunately had no affect. The list uses abstract
> >getter
> >and setter and is initialized in the .page spec with
> >initial-value="ognl:null".
> >
> >I have a number of selection models for PropertySelection components
>which
> >are initialized lazily which I am not resetting to null each time (but
> >there
> >are only about 100 total items in these objects). Could these have any
> >affect.
> >
> >I am really poking around in the dark. Similar Spring and Hibernate
> >mechanism that I wrote using Tapestry 3.0.3 is on a production system and
> >has run with no problems for months. Admittedly I never go and display
> >5000
> >objects at once though!
> >
> >I cannot see that I am inadvertently holding onto any objects in the code
> >but you never know?
> >
> >Thanks again for your help,
> >
> >Paul
> >
> >
> >Patrick Casey <pa...@adelphia.net> wrote:
> >
> > It sounds like a memory leak, but it could just be a slow garbage
> >collector as well. Try adding:
> >
> > System.gc() to the end of your transaction to guarantee the garbage
> >collector runs after each page render. Then see if repeated page renders
> >still blow out your memory. If they do, then I suspect that somehow you
> >(or
> >tapestry, or spring) is hanging onto a reference to those object after
> >page
> >completion.
> >
> > --- Pat
> >
> > PS You *are* resetting your page properties to null (and nulling out
> >the list of 5000 items) on the page's post-render cleanup phase, right?
> >
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 3:11 AM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: OutOfMemoryError Tapestry 4.0
> > >
> > >I have a page which allows a user to search the database based on
>various
> > >criteria. I have restricted the number of returned items to 5000. I
> > >display
> > >the items in the same search page using the @For component with
> > >volatile="ognl:true" . Repeated searches which return 5000 items will
> > >result
> > >in an OutOfMemoryError exception. If I leave the page and then return
>or
> > >stay on the page I will ultimately get an OutOfMemoryError exception.
> > >
> > >I can view other pages after this exception but a repeat of trying to
> > >display 5000 items on this page will display an OutOfMemory exception.
> > >
> > >The only way to clear this problem is to restart the servlet container.
> > >This
> > >fails using either Jetty or Tomcat in both development and production
> > >environments (using different operating systems).
> > >
> > >All the variables displaying the list are explicitly declared in the
> >.page
> > >specification and using initial-value set to null.
> > >
> > >I am using Tapestry 4.0 beta 8.
> > >
> > >The data is retrieved using Spring and Hibernate (no fancy patterns,
> > >standard Spring declarative transactions and using
> >getHibernateTemplate())
> > >and mapped to Tapestry using hivemodule.xml:
> > >
> > > <implementation service-
> > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > <invoke-factory>
> > > <construct autowire-services="false"
> > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > <set-object property="context"
> > >value="service:tapestry.globals.WebContext" />
> > > </construct>
> > > </invoke-factory>
> > > </implementation>
> > >
> > >and injecting the appropriate Spring bean.
> > >
> > >I am completely confused as to how to tie down the problem and isolate
> > >which
> > >section of code is causing the problem.
> > >
> > >Any help would be much appreciated.
> > >
> > >Paul
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail:
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
To clean out a hibernate session:
s.clear();
That will clean everything out of it. Be warned though that it
clears *everything* out of it, not just the stuff you recently loaded. A
safer way is to evict each object one at a time as you load it e.g.
Sesison s = HibHelper.getSession();
Query q = s.createQuery("from bigList");
List l = q.list();
For (int x=0; x< l.size(); x++)
s.evict(l.get(x));
> -----Original Message-----
> From: seloha . [mailto:seloha@hotmail.com]
> Sent: Monday, September 26, 2005 12:45 PM
> To: tapestry-user@jakarta.apache.org
> Subject: RE: OutOfMemoryError Tapestry 4.0
>
> Pat,
>
> 1) Yes I am setting the object list to null.
>
> 2) I have not put a log statement in the code to check it but I have set a
> break point in debug mode and each time the page was rendered the code in
> pageDetached(PageEvent event) was run.
>
> 3) There is no other code which references the list object except the
> rendering using the For component.
>
> 4) Subsequent to adding the pageDetached(PageEvent event) I have not run
> it
> on with the caching enabled. This I will do next.
>
> 5) I am using hibernate for the persistent layer. I have always just let
> Spring look after the hibernate session using declarative transactions and
> have never bypassed this mechanism. How do I evict go about evicting the
> objects after the transaction which picks them up. Can I just write a
> piece
> of code in my DAO which after picking the objects up then has something
> like:
>
> getHibernateTemplate().evict(objects);
>
> As you can see I am fairly nieve about use of hibernate too.
>
>
> Thanks,
>
> Paul
>
>
> Patrick Casey <pa...@adelphia.net> wrote:
>
> Well, it really smells to me like a leak, largely because 5,000
> objects, while a pain in the posterior to scroll through, is mouse nuts
> from
> a memory use standpoint (say each object is 10k (a whopper of an object),
> we're only looking at 50 M of memory here. Most object though are at least
> an order of magnitude smaller than that.
>
> Just to reinterate though:
>
> It loads once fine.
> If you keep loading the page, eventually you get an EOM error,
> right?
>
> Some other things to look at:
>
> 1) Unless Howard changed things or I'm remembering wrong, initial-value
> *does not* reset object to that state. Rather it's the value at page
> creation, not the value that something gets set to when a page goes into
> or
> out of the pool. So to null something out after render, you need to
> explicitly set it to null in the detach code (as it appears you are
> doing).
>
> 2) Can you put a log statement or something similar in your page detatch
> listener to make sure it's being called? I don't know how many times I got
> bit by adding PageBeginRender methods to Tap 3 forms without remembering
> to
> add implements PageEventListener to the class.
>
> 3) Are there any other object (statics, the visit object, some other
> property on the page) which reference your object chain?
>
> 4) Do you still get the EOM with tapestry's cache turned off? If so, it's
> not your tapestry code that's hanging onto a reference. If not, then the
> problem lies in not re-iniitalizing something properly before a page goes
> back into the pool.
>
> 5) Are you using Hibernate as your persistence layer? If so, are you
> evicting these objects out of the session and/or loading them in a temp
> session which you are subsequently closing? Objects loaded in a Hibernate
> session have the lifespan of the session, regardless of whether or not
> your
> code holds a reference to them.
>
>
>
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 11:55 AM
> >To: tapestry-user@jakarta.apache.org
> >Subject: RE: OutOfMemoryError Tapestry 4.0
> >
> >Thanks Pat,
> >
> >One thing I was not doing which you pointed out was setting the list to
> >null
> >in pageDetached(PageEvent event) so I added this and also included
> >System.gc(). This unfortunately had no affect. The list uses abstract
> >getter
> >and setter and is initialized in the .page spec with
> >initial-value="ognl:null".
> >
> >I have a number of selection models for PropertySelection components
> which
> >are initialized lazily which I am not resetting to null each time (but
> >there
> >are only about 100 total items in these objects). Could these have any
> >affect.
> >
> >I am really poking around in the dark. Similar Spring and Hibernate
> >mechanism that I wrote using Tapestry 3.0.3 is on a production system and
> >has run with no problems for months. Admittedly I never go and display
> >5000
> >objects at once though!
> >
> >I cannot see that I am inadvertently holding onto any objects in the code
> >but you never know?
> >
> >Thanks again for your help,
> >
> >Paul
> >
> >
> >Patrick Casey <pa...@adelphia.net> wrote:
> >
> > It sounds like a memory leak, but it could just be a slow garbage
> >collector as well. Try adding:
> >
> > System.gc() to the end of your transaction to guarantee the garbage
> >collector runs after each page render. Then see if repeated page renders
> >still blow out your memory. If they do, then I suspect that somehow you
> >(or
> >tapestry, or spring) is hanging onto a reference to those object after
> >page
> >completion.
> >
> > --- Pat
> >
> > PS You *are* resetting your page properties to null (and nulling out
> >the list of 5000 items) on the page's post-render cleanup phase, right?
> >
> > >-----Original Message-----
> > >From: seloha . [mailto:seloha@hotmail.com]
> > >Sent: Monday, September 26, 2005 3:11 AM
> > >To: tapestry-user@jakarta.apache.org
> > >Subject: OutOfMemoryError Tapestry 4.0
> > >
> > >I have a page which allows a user to search the database based on
> various
> > >criteria. I have restricted the number of returned items to 5000. I
> > >display
> > >the items in the same search page using the @For component with
> > >volatile="ognl:true" . Repeated searches which return 5000 items will
> > >result
> > >in an OutOfMemoryError exception. If I leave the page and then return
> or
> > >stay on the page I will ultimately get an OutOfMemoryError exception.
> > >
> > >I can view other pages after this exception but a repeat of trying to
> > >display 5000 items on this page will display an OutOfMemory exception.
> > >
> > >The only way to clear this problem is to restart the servlet container.
> > >This
> > >fails using either Jetty or Tomcat in both development and production
> > >environments (using different operating systems).
> > >
> > >All the variables displaying the list are explicitly declared in the
> >.page
> > >specification and using initial-value set to null.
> > >
> > >I am using Tapestry 4.0 beta 8.
> > >
> > >The data is retrieved using Spring and Hibernate (no fancy patterns,
> > >standard Spring declarative transactions and using
> >getHibernateTemplate())
> > >and mapped to Tapestry using hivemodule.xml:
> > >
> > > <implementation service-
> > >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > > <invoke-factory>
> > > <construct autowire-services="false"
> > >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > > <set-object property="context"
> > >value="service:tapestry.globals.WebContext" />
> > > </construct>
> > > </invoke-factory>
> > > </implementation>
> > >
> > >and injecting the appropriate Spring bean.
> > >
> > >I am completely confused as to how to tie down the problem and isolate
> > >which
> > >section of code is causing the problem.
> > >
> > >Any help would be much appreciated.
> > >
> > >Paul
> > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
Pat,
1) Yes I am setting the object list to null.
2) I have not put a log statement in the code to check it but I have set a
break point in debug mode and each time the page was rendered the code in
pageDetached(PageEvent event) was run.
3) There is no other code which references the list object except the
rendering using the For component.
4) Subsequent to adding the pageDetached(PageEvent event) I have not run it
on with the caching enabled. This I will do next.
5) I am using hibernate for the persistent layer. I have always just let
Spring look after the hibernate session using declarative transactions and
have never bypassed this mechanism. How do I evict go about evicting the
objects after the transaction which picks them up. Can I just write a piece
of code in my DAO which after picking the objects up then has something
like:
getHibernateTemplate().evict(objects);
As you can see I am fairly nieve about use of hibernate too.
Thanks,
Paul
Patrick Casey <pa...@adelphia.net> wrote:
Well, it really smells to me like a leak, largely because 5,000
objects, while a pain in the posterior to scroll through, is mouse nuts from
a memory use standpoint (say each object is 10k (a whopper of an object),
we're only looking at 50 M of memory here. Most object though are at least
an order of magnitude smaller than that.
Just to reinterate though:
It loads once fine.
If you keep loading the page, eventually you get an EOM error,
right?
Some other things to look at:
1) Unless Howard changed things or I'm remembering wrong, initial-value
*does not* reset object to that state. Rather it's the value at page
creation, not the value that something gets set to when a page goes into or
out of the pool. So to null something out after render, you need to
explicitly set it to null in the detach code (as it appears you are doing).
2) Can you put a log statement or something similar in your page detatch
listener to make sure it's being called? I don't know how many times I got
bit by adding PageBeginRender methods to Tap 3 forms without remembering to
add implements PageEventListener to the class.
3) Are there any other object (statics, the visit object, some other
property on the page) which reference your object chain?
4) Do you still get the EOM with tapestry's cache turned off? If so, it's
not your tapestry code that's hanging onto a reference. If not, then the
problem lies in not re-iniitalizing something properly before a page goes
back into the pool.
5) Are you using Hibernate as your persistence layer? If so, are you
evicting these objects out of the session and/or loading them in a temp
session which you are subsequently closing? Objects loaded in a Hibernate
session have the lifespan of the session, regardless of whether or not your
code holds a reference to them.
>-----Original Message-----
>From: seloha . [mailto:seloha@hotmail.com]
>Sent: Monday, September 26, 2005 11:55 AM
>To: tapestry-user@jakarta.apache.org
>Subject: RE: OutOfMemoryError Tapestry 4.0
>
>Thanks Pat,
>
>One thing I was not doing which you pointed out was setting the list to
>null
>in pageDetached(PageEvent event) so I added this and also included
>System.gc(). This unfortunately had no affect. The list uses abstract
>getter
>and setter and is initialized in the .page spec with
>initial-value="ognl:null".
>
>I have a number of selection models for PropertySelection components which
>are initialized lazily which I am not resetting to null each time (but
>there
>are only about 100 total items in these objects). Could these have any
>affect.
>
>I am really poking around in the dark. Similar Spring and Hibernate
>mechanism that I wrote using Tapestry 3.0.3 is on a production system and
>has run with no problems for months. Admittedly I never go and display
>5000
>objects at once though!
>
>I cannot see that I am inadvertently holding onto any objects in the code
>but you never know?
>
>Thanks again for your help,
>
>Paul
>
>
>Patrick Casey <pa...@adelphia.net> wrote:
>
> It sounds like a memory leak, but it could just be a slow garbage
>collector as well. Try adding:
>
> System.gc() to the end of your transaction to guarantee the garbage
>collector runs after each page render. Then see if repeated page renders
>still blow out your memory. If they do, then I suspect that somehow you
>(or
>tapestry, or spring) is hanging onto a reference to those object after
>page
>completion.
>
> --- Pat
>
> PS You *are* resetting your page properties to null (and nulling out
>the list of 5000 items) on the page's post-render cleanup phase, right?
>
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 3:11 AM
> >To: tapestry-user@jakarta.apache.org
> >Subject: OutOfMemoryError Tapestry 4.0
> >
> >I have a page which allows a user to search the database based on various
> >criteria. I have restricted the number of returned items to 5000. I
> >display
> >the items in the same search page using the @For component with
> >volatile="ognl:true" . Repeated searches which return 5000 items will
> >result
> >in an OutOfMemoryError exception. If I leave the page and then return or
> >stay on the page I will ultimately get an OutOfMemoryError exception.
> >
> >I can view other pages after this exception but a repeat of trying to
> >display 5000 items on this page will display an OutOfMemory exception.
> >
> >The only way to clear this problem is to restart the servlet container.
> >This
> >fails using either Jetty or Tomcat in both development and production
> >environments (using different operating systems).
> >
> >All the variables displaying the list are explicitly declared in the
>.page
> >specification and using initial-value set to null.
> >
> >I am using Tapestry 4.0 beta 8.
> >
> >The data is retrieved using Spring and Hibernate (no fancy patterns,
> >standard Spring declarative transactions and using
>getHibernateTemplate())
> >and mapped to Tapestry using hivemodule.xml:
> >
> > <implementation service-
> >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > <invoke-factory>
> > <construct autowire-services="false"
> >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > <set-object property="context"
> >value="service:tapestry.globals.WebContext" />
> > </construct>
> > </invoke-factory>
> > </implementation>
> >
> >and injecting the appropriate Spring bean.
> >
> >I am completely confused as to how to tie down the problem and isolate
> >which
> >section of code is causing the problem.
> >
> >Any help would be much appreciated.
> >
> >Paul
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail:
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
Well, it really smells to me like a leak, largely because 5,000
objects, while a pain in the posterior to scroll through, is mouse nuts from
a memory use standpoint (say each object is 10k (a whopper of an object),
we're only looking at 50 M of memory here. Most object though are at least
an order of magnitude smaller than that.
Just to reinterate though:
It loads once fine.
If you keep loading the page, eventually you get an EOM error,
right?
Some other things to look at:
1) Unless Howard changed things or I'm remembering wrong, initial-value
*does not* reset object to that state. Rather it's the value at page
creation, not the value that something gets set to when a page goes into or
out of the pool. So to null something out after render, you need to
explicitly set it to null in the detach code (as it appears you are doing).
2) Can you put a log statement or something similar in your page detatch
listener to make sure it's being called? I don't know how many times I got
bit by adding PageBeginRender methods to Tap 3 forms without remembering to
add implements PageEventListener to the class.
3) Are there any other object (statics, the visit object, some other
property on the page) which reference your object chain?
4) Do you still get the EOM with tapestry's cache turned off? If so, it's
not your tapestry code that's hanging onto a reference. If not, then the
problem lies in not re-iniitalizing something properly before a page goes
back into the pool.
5) Are you using Hibernate as your persistence layer? If so, are you
evicting these objects out of the session and/or loading them in a temp
session which you are subsequently closing? Objects loaded in a Hibernate
session have the lifespan of the session, regardless of whether or not your
code holds a reference to them.
> -----Original Message-----
> From: seloha . [mailto:seloha@hotmail.com]
> Sent: Monday, September 26, 2005 11:55 AM
> To: tapestry-user@jakarta.apache.org
> Subject: RE: OutOfMemoryError Tapestry 4.0
>
> Thanks Pat,
>
> One thing I was not doing which you pointed out was setting the list to
> null
> in pageDetached(PageEvent event) so I added this and also included
> System.gc(). This unfortunately had no affect. The list uses abstract
> getter
> and setter and is initialized in the .page spec with
> initial-value="ognl:null".
>
> I have a number of selection models for PropertySelection components which
> are initialized lazily which I am not resetting to null each time (but
> there
> are only about 100 total items in these objects). Could these have any
> affect.
>
> I am really poking around in the dark. Similar Spring and Hibernate
> mechanism that I wrote using Tapestry 3.0.3 is on a production system and
> has run with no problems for months. Admittedly I never go and display
> 5000
> objects at once though!
>
> I cannot see that I am inadvertently holding onto any objects in the code
> but you never know?
>
> Thanks again for your help,
>
> Paul
>
>
> Patrick Casey <pa...@adelphia.net> wrote:
>
> It sounds like a memory leak, but it could just be a slow garbage
> collector as well. Try adding:
>
> System.gc() to the end of your transaction to guarantee the garbage
> collector runs after each page render. Then see if repeated page renders
> still blow out your memory. If they do, then I suspect that somehow you
> (or
> tapestry, or spring) is hanging onto a reference to those object after
> page
> completion.
>
> --- Pat
>
> PS You *are* resetting your page properties to null (and nulling out
> the list of 5000 items) on the page's post-render cleanup phase, right?
>
> >-----Original Message-----
> >From: seloha . [mailto:seloha@hotmail.com]
> >Sent: Monday, September 26, 2005 3:11 AM
> >To: tapestry-user@jakarta.apache.org
> >Subject: OutOfMemoryError Tapestry 4.0
> >
> >I have a page which allows a user to search the database based on various
> >criteria. I have restricted the number of returned items to 5000. I
> >display
> >the items in the same search page using the @For component with
> >volatile="ognl:true" . Repeated searches which return 5000 items will
> >result
> >in an OutOfMemoryError exception. If I leave the page and then return or
> >stay on the page I will ultimately get an OutOfMemoryError exception.
> >
> >I can view other pages after this exception but a repeat of trying to
> >display 5000 items on this page will display an OutOfMemory exception.
> >
> >The only way to clear this problem is to restart the servlet container.
> >This
> >fails using either Jetty or Tomcat in both development and production
> >environments (using different operating systems).
> >
> >All the variables displaying the list are explicitly declared in the
> .page
> >specification and using initial-value set to null.
> >
> >I am using Tapestry 4.0 beta 8.
> >
> >The data is retrieved using Spring and Hibernate (no fancy patterns,
> >standard Spring declarative transactions and using
> getHibernateTemplate())
> >and mapped to Tapestry using hivemodule.xml:
> >
> > <implementation service-
> >id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> > <invoke-factory>
> > <construct autowire-services="false"
> >class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> > <event-listener service-id="hivemind.ShutdownCoordinator" />
> > <set-object property="context"
> >value="service:tapestry.globals.WebContext" />
> > </construct>
> > </invoke-factory>
> > </implementation>
> >
> >and injecting the appropriate Spring bean.
> >
> >I am completely confused as to how to tie down the problem and isolate
> >which
> >section of code is causing the problem.
> >
> >Any help would be much appreciated.
> >
> >Paul
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by "seloha ." <se...@hotmail.com>.
Thanks Pat,
One thing I was not doing which you pointed out was setting the list to null
in pageDetached(PageEvent event) so I added this and also included
System.gc(). This unfortunately had no affect. The list uses abstract getter
and setter and is initialized in the .page spec with
initial-value="ognl:null".
I have a number of selection models for PropertySelection components which
are initialized lazily which I am not resetting to null each time (but there
are only about 100 total items in these objects). Could these have any
affect.
I am really poking around in the dark. Similar Spring and Hibernate
mechanism that I wrote using Tapestry 3.0.3 is on a production system and
has run with no problems for months. Admittedly I never go and display 5000
objects at once though!
I cannot see that I am inadvertently holding onto any objects in the code
but you never know?
Thanks again for your help,
Paul
Patrick Casey <pa...@adelphia.net> wrote:
It sounds like a memory leak, but it could just be a slow garbage
collector as well. Try adding:
System.gc() to the end of your transaction to guarantee the garbage
collector runs after each page render. Then see if repeated page renders
still blow out your memory. If they do, then I suspect that somehow you (or
tapestry, or spring) is hanging onto a reference to those object after page
completion.
--- Pat
PS You *are* resetting your page properties to null (and nulling out
the list of 5000 items) on the page's post-render cleanup phase, right?
>-----Original Message-----
>From: seloha . [mailto:seloha@hotmail.com]
>Sent: Monday, September 26, 2005 3:11 AM
>To: tapestry-user@jakarta.apache.org
>Subject: OutOfMemoryError Tapestry 4.0
>
>I have a page which allows a user to search the database based on various
>criteria. I have restricted the number of returned items to 5000. I
>display
>the items in the same search page using the @For component with
>volatile="ognl:true" . Repeated searches which return 5000 items will
>result
>in an OutOfMemoryError exception. If I leave the page and then return or
>stay on the page I will ultimately get an OutOfMemoryError exception.
>
>I can view other pages after this exception but a repeat of trying to
>display 5000 items on this page will display an OutOfMemory exception.
>
>The only way to clear this problem is to restart the servlet container.
>This
>fails using either Jetty or Tomcat in both development and production
>environments (using different operating systems).
>
>All the variables displaying the list are explicitly declared in the .page
>specification and using initial-value set to null.
>
>I am using Tapestry 4.0 beta 8.
>
>The data is retrieved using Spring and Hibernate (no fancy patterns,
>standard Spring declarative transactions and using getHibernateTemplate())
>and mapped to Tapestry using hivemodule.xml:
>
> <implementation service-
>id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> <invoke-factory>
> <construct autowire-services="false"
>class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> <event-listener service-id="hivemind.ShutdownCoordinator" />
> <set-object property="context"
>value="service:tapestry.globals.WebContext" />
> </construct>
> </invoke-factory>
> </implementation>
>
>and injecting the appropriate Spring bean.
>
>I am completely confused as to how to tie down the problem and isolate
>which
>section of code is causing the problem.
>
>Any help would be much appreciated.
>
>Paul
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
RE: OutOfMemoryError Tapestry 4.0
Posted by Patrick Casey <pa...@adelphia.net>.
It sounds like a memory leak, but it could just be a slow garbage
collector as well. Try adding:
System.gc() to the end of your transaction to guarantee the garbage
collector runs after each page render. Then see if repeated page renders
still blow out your memory. If they do, then I suspect that somehow you (or
tapestry, or spring) is hanging onto a reference to those object after page
completion.
--- Pat
PS You *are* resetting your page properties to null (and nulling out
the list of 5000 items) on the page's post-render cleanup phase, right?
> -----Original Message-----
> From: seloha . [mailto:seloha@hotmail.com]
> Sent: Monday, September 26, 2005 3:11 AM
> To: tapestry-user@jakarta.apache.org
> Subject: OutOfMemoryError Tapestry 4.0
>
> I have a page which allows a user to search the database based on various
> criteria. I have restricted the number of returned items to 5000. I
> display
> the items in the same search page using the @For component with
> volatile="ognl:true" . Repeated searches which return 5000 items will
> result
> in an OutOfMemoryError exception. If I leave the page and then return or
> stay on the page I will ultimately get an OutOfMemoryError exception.
>
> I can view other pages after this exception but a repeat of trying to
> display 5000 items on this page will display an OutOfMemory exception.
>
> The only way to clear this problem is to restart the servlet container.
> This
> fails using either Jetty or Tomcat in both development and production
> environments (using different operating systems).
>
> All the variables displaying the list are explicitly declared in the .page
> specification and using initial-value set to null.
>
> I am using Tapestry 4.0 beta 8.
>
> The data is retrieved using Spring and Hibernate (no fancy patterns,
> standard Spring declarative transactions and using getHibernateTemplate())
> and mapped to Tapestry using hivemodule.xml:
>
> <implementation service-
> id="hivemind.lib.DefaultSpringBeanFactoryHolder">
> <invoke-factory>
> <construct autowire-services="false"
> class="uk.co.cymbol.tair.tapestry.AppSpringBeanFactoryHolderImpl">
> <event-listener service-id="hivemind.ShutdownCoordinator" />
> <set-object property="context"
> value="service:tapestry.globals.WebContext" />
> </construct>
> </invoke-factory>
> </implementation>
>
> and injecting the appropriate Spring bean.
>
> I am completely confused as to how to tie down the problem and isolate
> which
> section of code is causing the problem.
>
> Any help would be much appreciated.
>
> Paul
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-user-help@jakarta.apache.org