You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ryan-williams <gi...@git.apache.org> on 2015/02/12 22:16:56 UTC
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
GitHub user ryan-williams opened a pull request:
https://github.com/apache/spark/pull/4574
[SPARK-5784] Add StatsD adapter to MetricsSystem
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ryan-williams/spark statsd
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4574.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4574
----
commit 39c5e41d6baa2cd9f2a5a7a4a7bfc32095df1839
Author: Ryan Williams <ry...@gmail.com>
Date: 2015-02-02T14:50:33Z
Add StatsD adapter to MetricsSystem
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4574#discussion_r24625892
--- Diff: pom.xml ---
@@ -207,6 +207,17 @@
</snapshots>
</repository>
<repository>
+ <id>bintray</id>
+ <name>Bintray</name>
+ <url>https://dl.bintray.com/readytalk/maven</url>
--- End diff --
So in general, we can't depend on artifacts that aren't in maven central in Spark's build. The issue is that these can be removed later, taken down, etc, and it will break all spark builds in the wild.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by ryan-williams <gi...@git.apache.org>.
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74574885
yea I could see that making more sense @pwendell. From a cursory look I don't see how to proceed doing that; any pointers?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74167606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27384/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74208978
Hi @pwendell , can we make this `Sink` public, so used could add their own Sink through configuration? I think metrics system support adding customized sink through configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74154547
[Test build #27384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27384/consoleFull) for PR 4574 at commit [`39c5e41`](https://github.com/apache/spark/commit/39c5e41d6baa2cd9f2a5a7a4a7bfc32095df1839).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74164971
Is this the kind of thing that could be published as a separate package (i.e. spark-packages.org) or similar? I think it would be good to have some of these metrics integrations there. Let me know if you are interested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5784] Add StatsD adapter to MetricsSyst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4574#issuecomment-74167587
[Test build #27384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27384/consoleFull) for PR 4574 at commit [`39c5e41`](https://github.com/apache/spark/commit/39c5e41d6baa2cd9f2a5a7a4a7bfc32095df1839).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class StatsDSink(val property: Properties,`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org