You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ádám Bakai (Code Review)" <ge...@cloudera.org> on 2024/12/03 17:24:12 UTC
[kudu-CR] [WIP] TSAN fix
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22158
Change subject: [WIP] TSAN fix
......................................................................
[WIP] TSAN fix
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/util/countdown_latch-test.cc
M src/kudu/util/countdown_latch.h
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/1
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [WIP] TSAN fix
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#2).
Change subject: [WIP] TSAN fix
......................................................................
[WIP] TSAN fix
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/util/countdown_latch-test.cc
M src/kudu/util/countdown_latch.h
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/2
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/797/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Dec 2024 14:18:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 6: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/889/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 6
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jan 2025 14:06:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG
Commit Message:
PS4:
> Instead of adding this extra lock and complicating a very simple thing, wou
You are correct, it looks like it solves the problem as well.
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG@7
PS4, Line 7: countdown_latch
> nit: you can just use [util] here instead and expand a bit in the subject (
Done
http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h
File src/kudu/util/countdown_latch.h:
http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h@133
PS4, Line 133: mutable std::shared_timed_mutex destruction_lock_;
> Why do we need a separate mutex for this? Can't we just use lock_?
My idea was that we needed a separate lock because that lock was causing the TSAN error. But the patch was reworked to solve the thread issue itself.
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Dec 2024 14:02:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 7:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/890/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 7
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 10:35:03 +0000
Gerrit-HasComments: No
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/814/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Dec 2024 17:51:35 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 2:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/747/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2024 00:15:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#8).
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
KUDU-3631 Fix Master shutdown
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time. The
solution is to set it to zero and wait until the deleter thread relying
on the latch is also joined,
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/master/master.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/8
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 8:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/891/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 15:57:34 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/738/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 17:35:12 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/738/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Dec 2024 17:24:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/891/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 16:53:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG
Commit Message:
PS4:
> You are correct, it looks like it solves the problem as well.
Thanks a lot for verifying and updating this patch accordingly!
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc@551
PS5, Line 551: // 3. Shut down generic subsystems.
Since the expired_reserved_tables_deleter_thread_ is started conditionally (see Master::StartAsync()), expired_reserved_tables_deleter_thread_ might be nullptr. In such cases this code leads to a crash, and you could see it's happening in pre-commit tests for PS5.
Please update this code as necessary.
Also, consider adding a comment on the reason for resetting stop_background_threads_latch_ -- it'd make this code easier to comprehend for the readers without a lot of background on the internals of the Master class.
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Dec 2024 17:47:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/747/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Dec 2024 12:31:33 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc@551
PS5, Line 551: expired_reserved_tables_deleter_thread_
> Done
Can you add the comment Alexey asked for as well?
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 6
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 09:25:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc@551
PS5, Line 551: expired_reserved_tables_deleter_thread_
> Can you add the comment Alexey asked for as well?
Sorry, I forgot to commit the actual change.
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 10:36:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/848/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Dec 2024 14:33:40 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/848/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Dec 2024 13:38:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#6).
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
KUDU-3631 Fix Master shutdown
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time. The
solution is to set it to zero and wait until the deleter thread relying
on the latch is also joined,
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/master/master.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/6
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 6
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/797/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Dec 2024 15:36:00 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc@551
PS5, Line 551: expired_reserved_tables_deleter_thread_
> Since the expired_reserved_tables_deleter_thread_ is started conditionally
Done
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jan 2025 14:07:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/889/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 6
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jan 2025 15:34:24 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
KUDU-3631 Fix Master shutdown
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time. The
solution is to set it to zero and wait until the deleter thread relying
on the latch is also joined,
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Reviewed-on: http://gerrit.cloudera.org:8080/22158
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/master.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 9
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/755/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2024 01:34:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#7).
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
KUDU-3631 Fix Master shutdown
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time. The
solution is to set it to zero and wait until the deleter thread relying
on the latch is also joined,
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/master/master.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/7
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 7
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 17:55:42 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [WIP] TSAN fix
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [WIP] TSAN fix
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/755/
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Dec 2024 00:18:23 +0000
Gerrit-HasComments: No
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/814/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 20:09:14 +0000
Gerrit-HasComments: No
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG
Commit Message:
PS4:
Instead of adding this extra lock and complicating a very simple thing, wouldn't it be easier to simply fix the way how the CountDownLatch class is used in one particular case?
Could the problem be addressed by simply joining master's expired_reserved_tables_deleter_thread_ in Master::ShutdownImpl() method along with other threads?
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 07:21:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Zoltan Martonka, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#5).
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
KUDU-3631 Fix Master shutdown
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time. The
solution is to set it to zero and wait until the deleter thread relying
on the latch is also joined,
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/master/master.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/5
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 5
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22158
to look at the new patch set (#3).
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
[countdown_latch] KUDU-3631 Add lock
TSAN gave a warning because CountDownLatch::WaitUntil() and
CountDownLatch::~CountDownLatch() were running at the same time, which
could cause lock_ to be destroyed while being locked by WaitUntil(). A
new lock has been added to ensure that destruction of CountDownLatch
only happens when the mutex is no longer in use.
Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
---
M src/kudu/util/countdown_latch-test.cc
M src/kudu/util/countdown_latch.h
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/22158/3
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [countdown latch] KUDU-3631 Add lock
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG@7
PS4, Line 7: countdown_latch
nit: you can just use [util] here instead and expand a bit in the subject (i.e. Add lock to countdown latch). Also, if there's a JIRA, maybe a separate tag is not necessary at all.
http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h
File src/kudu/util/countdown_latch.h:
http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h@133
PS4, Line 133: mutable std::shared_timed_mutex destruction_lock_;
Why do we need a separate mutex for this? Can't we just use lock_?
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 4
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Dec 2024 17:54:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 7: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/890/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 7
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 11:15:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3631 Fix Master shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown
......................................................................
Patch Set 8: Verified+1
Unrelated Java test failure (RELEASE):
* org.apache.kudu.spark.kudu.DefaultSourceTest (a known flaky test)
--
To view, visit http://gerrit.cloudera.org:8080/22158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8
Gerrit-Change-Number: 22158
Gerrit-PatchSet: 8
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2025 17:55:33 +0000
Gerrit-HasComments: No