[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5201: inline: switch from inline to inline_function

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #5201:
URL: https://github.com/apache/incubator-nuttx/pull/5201#discussion_r782161109



##########
File path: arch/arm/include/armv6-m/irq.h
##########
@@ -219,8 +219,7 @@ struct xcptcontext
 
 /* Get/set the PRIMASK register */
 
-static inline uint8_t getprimask(void) inline_function;
-static inline uint8_t getprimask(void)
+inline_function static uint8_t getprimask(void)

Review comment:
       I noticed that some functions like this one had "inline" before the name of the function and "inline_function" at the end of the function. It is really strange. Maybe we can try to pass "-std=c89" for some arch that is already following C89 to try to catch these issues. Other option is to find "an old era" C89 compiler for some retro arch and test it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org