You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/04 11:36:18 UTC
[GitHub] [fineract] ptuomola opened a new pull request #1147: FINERACT-1074: Cleaning up plugin configurations
ptuomola opened a new pull request #1147:
URL: https://github.com/apache/fineract/pull/1147
## Description
Cleaned up the plugin configuration by ensuring all plugins used are the latest versions, and by pulling each plugin configuration to a separate section in build.gradle, with common parameters (repositories etc) at the start of the file.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454180078
##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
Run as:
gradle clean bootRun'''
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+ jcenter()
+ mavenCentral()
Review comment:
SGTM. FYI what I meant was specifically the mavenCentral() line - AFAIK jCenter() "proxies" (mirrors) Maven Central already anyway, so this is unnecessary and probably just shows down (failed) look ups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#issuecomment-653891310
Thanks @xurror - merge conflicts should be all resolved now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
ptuomola commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454061138
##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
Run as:
gradle clean bootRun'''
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+ jcenter()
+ mavenCentral()
Review comment:
Hi @vorburger - welcome back!
The same lines were there, but just hidden half way down the build.gradle file (lines 164-170 in the previous version). All I did was to reorganise the existing content - I was not trying to make any functional changes at this point, so did not remove any of the settings.
I have another PR ready to further reorganise the content by e.g. grouping all the plugin configurations together. But once we have the contents structured in a more sensible way, then it should be easy to see whether all of the settings are actually needed and remove the ones that are not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror merged pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
xurror merged pull request #1147:
URL: https://github.com/apache/fineract/pull/1147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454180078
##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
Run as:
gradle clean bootRun'''
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+ jcenter()
+ mavenCentral()
Review comment:
SGTM. FYI what I meant was specifically the mavenCentral() line - AFAIK jCenter() "proxies" (mirrors) Maven Central already anyway, so this is unnecessary and probably just slows down (failed) look ups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#discussion_r454018024
##########
File path: fineract-provider/build.gradle
##########
@@ -20,10 +20,17 @@ description = '''\
Run as:
gradle clean bootRun'''
+group = 'org.apache.fineract'
+buildDir = new File(rootProject.projectDir, "../build")
+
+repositories {
+ jcenter()
+ mavenCentral()
Review comment:
This shouldn't be required, no? We didn't have it before either
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1147: FINERACT-1074: Cleaning up plugin configurations
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1147:
URL: https://github.com/apache/fineract/pull/1147#issuecomment-653842101
Some merge conflicts here. Will merge once they are resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org