You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/28 17:28:57 UTC
[GitHub] [hive] pvary opened a new pull request #3061: HIVE-25894: Table migration to Iceberg doesn't remove HMS partitions
pvary opened a new pull request #3061:
URL: https://github.com/apache/hive/pull/3061
### What changes were proposed in this pull request?
During Iceberg table migration of partitioned tables we should drop the partition objects from the HMS.
### Why are the changes needed?
So we have a clean HMS metastore db
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
The existing unit test are checking the migration path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] marton-bod commented on a change in pull request #3061: HIVE-25894: Table migration to Iceberg doesn't remove HMS partitions
Posted by GitBox <gi...@apache.org>.
marton-bod commented on a change in pull request #3061:
URL: https://github.com/apache/hive/pull/3061#discussion_r817466517
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -3939,8 +3939,8 @@ protected boolean getPartitionsByExprInternal(String catName, String dbName, Str
boolean allowSql, boolean allowJdo) throws TException {
assert result != null;
- final ExpressionTree exprTree = PartFilterExprUtil.makeExpressionTree(expressionProxy, expr,
- getDefaultPartitionName(defaultPartitionName), conf);
+ final ExpressionTree exprTree = expr.length != 0 ? PartFilterExprUtil.makeExpressionTree(
Review comment:
Can you explain why this change was needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #3061: HIVE-25894: Table migration to Iceberg doesn't remove HMS partitions
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #3061:
URL: https://github.com/apache/hive/pull/3061#discussion_r817467883
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -3939,8 +3939,8 @@ protected boolean getPartitionsByExprInternal(String catName, String dbName, Str
boolean allowSql, boolean allowJdo) throws TException {
assert result != null;
- final ExpressionTree exprTree = PartFilterExprUtil.makeExpressionTree(expressionProxy, expr,
- getDefaultPartitionName(defaultPartitionName), conf);
+ final ExpressionTree exprTree = expr.length != 0 ? PartFilterExprUtil.makeExpressionTree(
Review comment:
The zero length expression signifies that no filtering is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #3061: HIVE-25894: Table migration to Iceberg doesn't remove HMS partitions
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #3061:
URL: https://github.com/apache/hive/pull/3061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org