You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2005/06/01 01:28:52 UTC
[jira] Created: (JAMES-380) ESMTP Compliance fix
ESMTP Compliance fix
--------------------
Key: JAMES-380
URL: http://issues.apache.org/jira/browse/JAMES-380
Project: James
Type: Bug
Components: SMTPServer
Versions: 2.2.1
Reporter: Stefano Bagnara
Attachments: esmtp-20050601.tar.gz
Here is a cumulative patch for
[#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
[#JAMES-375] - RFC 1854 - Command Pipelining support
[#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
[#JAMES-369] - Always announce AUTH capability to clients
It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
---------------------------
StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
while (optionTokenizer.hasMoreElements()) {
String mailOption = optionTokenizer.nextToken();
- int equalIndex = mailOptionString.indexOf('=');
+ int equalIndex = mailOption.indexOf('=');
------------------------------
It clearly seems a bug.
I think I have no rights to associate this issue to the 4 "childs".
I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
Noel J. Bergman wrote:
> isAuthRequired:
> true when <authRequired> != false and ! in {<authorizedAddresses>}
And this got even more complicated with your ESMTP changes.
> which is why we don't need this change:
> - if (authRequired) {
> + if (authRequired && !relayingAllowed)
We do now ... :-) I hadn't looked at your other changes when I made that
comment.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
Stefano Bagnara wrote:
> > You moved the check inside the authRequired check. I want it
> > OUTSIDE the check because I want for it to apply to ALL
> > e-mail, regardless of whether auth is required or not.
> I did not check your intended behaviour, I simply refactored it.
> Am I missing something?
Actually, I did, and your refactoring pointed it out. :-)
We have two checks:
isAuthRequired:
true when <authRequired> != false and ! in {<authorizedAddresses>}
usRelayingAllowed
true when in {<authorizedAddresses>}
which is why we don't need this change:
- if (authRequired) {
+ if (authRequired && !relayingAllowed)
For now, we want to check the DNSRBL whenever the address is not authorized,
but since the isAuthRequired check would be false in the common case where
SMTP AUTH isn't enabled, we can't rely on isAuthRequired as the sole check.
My check was:
if (blocklisted &&
(authRequired && getUser() == null) &&
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") ||
recipientAddress.getUser().equalsIgnoreCase("abuse"))) {
and should be:
if (blocklisted &&
(!relayAllowed || (authRequired && getUser() == null)) &&
^ handle case when IP not authorized and SMTP AUTH not enabled
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") ||
recipientAddress.getUser().equalsIgnoreCase("abuse"))) {
because !relayedAllow can be true when authRequired is false.
I'd consider cleaning this up, but I think that moving to the fast-fail
approach proposed will clean up the whole area structurally.
Again, please check my logic (above.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by Stefano Bagnara <ap...@bago.org>.
> > > Did you see the patch I did to SMTPHandler earlier today?
> I haven't
> > > committed it, but it seems that our patches need to be merged.
>
> > Just replaced your
> > ...
> > And moved the check a few lines later.
>
> I believe that you broke the code with that last change.
> Please check me on this, since I plan to apply and then fix
> the code again.
>
> You moved the check inside the authRequired check. I want it
> OUTSIDE the check because I want for it to apply to ALL
> e-mail, regardless of whether auth is required or not.
Here is your condition:
if (blocklisted && // was found in the RBL
(authRequired && getUser() == null) && // not authenticated -- don't care
if it is local or not
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") ||
recipientAddress.getUser().equalsIgnoreCase("abuse"))) {
I see that all the conditions are in "&&" and one of them is "authRequired".
I simply moved that code inside a block that already checked the
authRequired. I think I simply "refactored" your code with no change to the
behaviour.
I did not check your intended behaviour, I simply refactored it.
Am I missing something?
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
> I believe that you broke the code with that last change.
Rephrase: "I believe that the patch might not be quite right"
And, actually, I'm not sure that it isn't right. My mistake. I'll review
as I do the merge.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
Stefano Bagnara wrote:
> > Did you see the patch I did to SMTPHandler earlier today? I
> > haven't committed it, but it seems that our patches need to be merged.
> Just replaced your
> ...
> And moved the check a few lines later.
I believe that you broke the code with that last change. Please check me on
this, since I plan to apply and then fix the code again.
You moved the check inside the authRequired check. I want it OUTSIDE the
check because I want for it to apply to ALL e-mail, regardless of whether
auth is required or not.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by Stefano Bagnara <ap...@bago.org>.
> Stefano,
>
> Did you see the patch I did to SMTPHandler earlier today? I
> haven't committed it, but it seems that our patches need to be merged.
I read the thread. The merge should be easy.
Just replaced your
responseString = "550 Rejected: unauthenticated e-mail from " + remoteIP + "
is restricted. Contact the postmaster for details.";
With this one ENHANCEDSTATUSCODES compliant:
responseString = "550
"+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.SECURITY_AUTH)+"
Rejected: unauthenticated e-mail from " + remoteIP + " is restricted.
Contact the postmaster for details.";
And moved the check a few lines later.
Just updated the patch in the JIRA issue with the merged one.
> > rewritten CRLFTerminatedReader to remove buffering
>
> Is this for pipelining?
Yes.
I've read the PIPELINING rfc: James was already "almost" compliant because
it was failing to pipeline on the DATA command (not requested to support
pipelining) but anyway I preferred to remove the Buffering in the wrapper
streamreader because we already have a buffer and this makes handling
easier. Now, with my patch, if you are sure your mail session will work you
can write all the commands in a single send.
The "real" small bug in the current implementation is that after closing the
DATA block with the "CRLF.CRLF" james would then try to handle the commands
buffered before the DATA CRLFTerminatedReader was opened.
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
Stefano,
Did you see the patch I did to SMTPHandler earlier today? I haven't committed it, but it seems that our patches need to be merged.
> rewritten CRLFTerminatedReader to remove buffering
Is this for pipelining?
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Stefano Bagnara updated JAMES-380:
----------------------------------
Attachment: esmtp-20050601.tar.gz
changed SMTPServer/Handler, added DSNStatus (extracted from DSNBounce), rewritten CRLFTerminatedReader to remove buffering.
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-380) ESMTP Compliance fix
Posted by "Jeff Turner (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Jeff Turner resolved JAMES-380:
-------------------------------
Resolution: Fixed
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Stefano Bagnara updated JAMES-380:
----------------------------------
Fix Version: 2.2.1
(was: 3.0)
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Fix For: 2.2.1
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
You had attached it to JAMES-377 and I had gotten it, otherwise I could not
have compiled. :-) But svn diff doesn't tell you when you have files that
need to be added; svn status does. One of those differences between CVS and
SVN.
Fixed in SVN now.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by Stefano Bagnara <ap...@bago.org>.
> No worries. And you should see that the patches are all in
> SVN now, along with my current version of the DNSRBL fast-fail.
>
> I'm running it on my server, so we'll see.
I think I forgot to upload DSNStatus.java or you forgot to commit it ;-)
(I can't find it here:
http://svn.apache.org/repos/asf/james/server/trunk/src/java/org/apache/james
/util/mail/ )
I attach the java file. It should be added to
src/org/apache/james/util/mail/dsn
I've made a specific package for this class because I'm putting there all my
dsn stuff (as like as for mdn).
Stefano
RE: [jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
> I forgot to put the POP3Handler diff in the cumulative patch, sorry.
No worries. And you should see that the patches are all in SVN now, along
with my current version of the DNSRBL fast-fail.
I'm running it on my server, so we'll see.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by Stefano Bagnara <ap...@bago.org>.
> > This set of patches breaks the build.
>
> Nevermind. I deleted the comment. The patches were
> purported to be a cumulative set, which I took too literally.
> I finally found the POP3Handler patch attached to one of the
> other issues.
Sure, you are right.
I forgot to put the POP3Handler diff in the cumulative patch, sorry.
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: [jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman" <no...@devtech.com>.
> This set of patches breaks the build.
Nevermind. I deleted the comment. The patches were purported to be a cumulative set, which I took too literally. I finally found the POP3Handler patch attached to one of the other issues.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=comments#action_66931 ]
Noel J. Bergman commented on JAMES-380:
---------------------------------------
This set of patches breaks the build. Most patches applied, although the one for CRLFTerminatedReader needed to be applied by hand. However, after applying, the following error is observed:
/home/noel/ASF/james/server/trunk/src/java/org/apache/james/pop3server/POP3Handler.java:222: incompatible types
found : org.apache.james.util.CRLFTerminatedReader
required: java.io.BufferedReader
in = new CRLFTerminatedReader(new BufferedInputStream(socket.getInputStream(), 512), "ASCII");
^
1 error
1 warning
BUILD FAILED
and I cannot find a related patch for POP3Handler.java.
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Stefano Bagnara updated JAMES-380:
----------------------------------
Attachment: SMTPHandler.java.checkDSNRBLupdate.diff
Updated SMTPHandler patch to support Noel's update for checking DNS RBL.
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-380) ESMTP Compliance fix
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=comments#action_66697 ]
Stefano Bagnara commented on JAMES-380:
---------------------------------------
I cleaned my diff from DSN support that is still in alpha but I just saw I forgot to remove the "esmtpextensions.add("DSN");" line from the diff. Please remove that line if you add the patch.
PS: I used the patched SMTPServer in production since a week.
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Stefano Bagnara updated JAMES-380:
----------------------------------
Fix Version: 3.0
Description:
Here is a cumulative patch for
[#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
[#JAMES-375] - RFC 1854 - Command Pipelining support
[#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
[#JAMES-369] - Always announce AUTH capability to clients
It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
---------------------------
StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
while (optionTokenizer.hasMoreElements()) {
String mailOption = optionTokenizer.nextToken();
- int equalIndex = mailOptionString.indexOf('=');
+ int equalIndex = mailOption.indexOf('=');
------------------------------
It clearly seems a bug.
I think I have no rights to associate this issue to the 4 "childs".
I'm creating this issue to have a place to append a single patch.
was:
Here is a cumulative patch for
[#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
[#JAMES-375] - RFC 1854 - Command Pipelining support
[#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
[#JAMES-369] - Always announce AUTH capability to clients
It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
---------------------------
StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
while (optionTokenizer.hasMoreElements()) {
String mailOption = optionTokenizer.nextToken();
- int equalIndex = mailOptionString.indexOf('=');
+ int equalIndex = mailOption.indexOf('=');
------------------------------
It clearly seems a bug.
I think I have no rights to associate this issue to the 4 "childs".
I'm creating this issue to have a place to append a single patch.
Environment:
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Fix For: 3.0
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-380) ESMTP Compliance fix
Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-380?page=all ]
Noel J. Bergman updated JAMES-380:
----------------------------------
Comment: was deleted
> ESMTP Compliance fix
> --------------------
>
> Key: JAMES-380
> URL: http://issues.apache.org/jira/browse/JAMES-380
> Project: James
> Type: Bug
> Components: SMTPServer
> Versions: 2.2.1
> Reporter: Stefano Bagnara
> Attachments: SMTPHandler.java.checkDSNRBLupdate.diff, esmtp-20050601.tar.gz
>
> Here is a cumulative patch for
> [#JAMES-377] - rfc2034 ENHANCEDSTATUSCODES
> [#JAMES-375] - RFC 1854 - Command Pipelining support
> [#JAMES-374] - EHLO reply when SIZE limit is enabled is wrong
> [#JAMES-369] - Always announce AUTH capability to clients
> It also fixes a bug in MAIL FROM and RCPT TO attributes tokenizer.
> ---------------------------
> StringTokenizer optionTokenizer = new StringTokenizer(mailOptionString, " ");
> while (optionTokenizer.hasMoreElements()) {
> String mailOption = optionTokenizer.nextToken();
> - int equalIndex = mailOptionString.indexOf('=');
> + int equalIndex = mailOption.indexOf('=');
> ------------------------------
> It clearly seems a bug.
> I think I have no rights to associate this issue to the 4 "childs".
> I'm creating this issue to have a place to append a single patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org