You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/12 22:58:29 UTC

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest 

Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/4388

to review the following change.

Change subject: Take 2: fix flakiness in tablet_history_gc-itest
......................................................................

Take 2: fix flakiness in tablet_history_gc-itest

3a9ea63b9f210b64124b2d9d2b5f14ed1214f272 attempted to fix this bug, but
I added the flag setting to the wrong test case. Take two, this time on
the test case that was actually flaky!

Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4388/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Take 2: fix flakiness in tablet_history_gc-itest
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3383/

-- 
To view, visit http://gerrit.cloudera.org:8080/4388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Take 2: fix flakiness in tablet_history_gc-itest
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No

[kudu-CR] Take 2: fix flakiness in tablet history gc-itest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.

Change subject: Take 2: fix flakiness in tablet_history_gc-itest
......................................................................


Take 2: fix flakiness in tablet_history_gc-itest

3a9ea63b9f210b64124b2d9d2b5f14ed1214f272 attempted to fix this bug, but
I added the flag setting to the wrong test case. Take two, this time on
the test case that was actually flaky!

Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Reviewed-on: http://gerrit.cloudera.org:8080/4388
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>