You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/12/20 01:47:28 UTC
Review Request 64741: Eliminated some unnecessary copying in the HTTP
operator API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/
-----------------------------------------------------------
Review request for mesos, Michael Park and Meng Zhu.
Bugs: MESOS-8344
https://issues.apache.org/jira/browse/MESOS-8344
Repository: mesos
Description
-------
This is only a minor portion of the performance improvements
needed to bring the v1 operator API close to the v0 API
performance.
Diffs
-----
src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6
Diff: https://reviews.apache.org/r/64741/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 64741: Eliminated some unnecessary copying in the
HTTP operator API.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Dec. 20, 2017, 7:52 p.m., Meng Zhu wrote:
> > src/master/http.cpp
> > Lines 4232-4235 (original), 4232-4234 (patched)
> > <https://reviews.apache.org/r/64741/diff/1/?file=1924196#file1924196line4234>
> >
> > how about:
> >
> > `*getTasks.add_pending_tasks() = protobuf::createTask(taskInfo, TASK_STAGING, framework->id());`
Sounds good!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/#review194269
-----------------------------------------------------------
On Dec. 20, 2017, 1:47 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64741/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 1:47 a.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Bugs: MESOS-8344
> https://issues.apache.org/jira/browse/MESOS-8344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is only a minor portion of the performance improvements
> needed to bring the v1 operator API close to the v0 API
> performance.
>
>
> Diffs
> -----
>
> src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6
>
>
> Diff: https://reviews.apache.org/r/64741/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 64741: Eliminated some unnecessary copying in the
HTTP operator API.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/#review194269
-----------------------------------------------------------
src/master/http.cpp
Lines 4232-4235 (original), 4232-4234 (patched)
<https://reviews.apache.org/r/64741/#comment272997>
how about:
`*getTasks.add_pending_tasks() = protobuf::createTask(taskInfo, TASK_STAGING, framework->id());`
- Meng Zhu
On Dec. 19, 2017, 5:47 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64741/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 5:47 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Bugs: MESOS-8344
> https://issues.apache.org/jira/browse/MESOS-8344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is only a minor portion of the performance improvements
> needed to bring the v1 operator API close to the v0 API
> performance.
>
>
> Diffs
> -----
>
> src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6
>
>
> Diff: https://reviews.apache.org/r/64741/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 64741: Eliminated some unnecessary copying in the
HTTP operator API.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/#review194280
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Dec. 19, 2017, 5:47 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64741/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 5:47 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Bugs: MESOS-8344
> https://issues.apache.org/jira/browse/MESOS-8344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is only a minor portion of the performance improvements
> needed to bring the v1 operator API close to the v0 API
> performance.
>
>
> Diffs
> -----
>
> src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6
>
>
> Diff: https://reviews.apache.org/r/64741/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 64741: Eliminated some unnecessary copying in the
HTTP operator API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/#review194208
-----------------------------------------------------------
PASS: Mesos patch 64741 was successfully built and tested.
Reviews applied: `['64741']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64741
- Mesos Reviewbot Windows
On Dec. 19, 2017, 5:47 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64741/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 5:47 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Bugs: MESOS-8344
> https://issues.apache.org/jira/browse/MESOS-8344
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is only a minor portion of the performance improvements
> needed to bring the v1 operator API close to the v0 API
> performance.
>
>
> Diffs
> -----
>
> src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6
>
>
> Diff: https://reviews.apache.org/r/64741/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>