You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/07 14:08:31 UTC
[GitHub] [incubator-tvm] inadob opened a new pull request #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
inadob opened a new pull request #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642
* Add parser support for logical_and, logical_or
* Add boolean dtype as a valid tensor type
* boolean dtype is supported only from tf 1.15
so logical ops work only in that and newer versions
* Logical_not is ommited since tflite can't convert it --> throws an error for addv2:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu merged pull request #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
yzhliu merged pull request #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob edited a comment on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob edited a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-571603544
Simplified code reproducing the error:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573731291
@u99127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob edited a comment on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob edited a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573727010
@u99127 @yzhliu so previously, the tests for **logical_and** and **logical_or** were failing because of the CI tflite version=1.13 and since boolean dtype is supported from tlfite 1.15. Now I added a line in the tests to check the tlfite version. With regard to **logical_not** - it's not included in the PR because of that issue in the snap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-571603544
That's the code for logical_not producing the error:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573727010
@yzhliu so previously, the tests for **logical_and** and **logical_or** were failing because of the CI tflite version=1.13 and since boolean dtype is supported from tlfite 1.15. Now I added a line in the tests to check the tlfite version. With regard to **logical_not** - it's not included in the PR because of that issue in the snap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-581611590
@inadob Can you please rebase?
@yzhliu Is conditional check for TFLite version good for now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-582590768
Thanks @inadob @anijain2305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] inadob removed a comment on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
inadob removed a comment on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-573731291
@u99127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on issue #4642:
[Relay][Frontend][TFLite] Add parser support for logical operators
Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #4642: [Relay][Frontend][TFLite] Add parser support for logical operators
URL: https://github.com/apache/incubator-tvm/pull/4642#issuecomment-572193822
could you address the failure test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services