[jira] [Commented] (CB-4731) Adding config entries in plugin.xml results in duplicate .plist entries

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146623#comment-14146623 ] 

ASF GitHub Bot commented on CB-4731:
------------------------------------

GitHub user gorkem opened a pull request:

    https://github.com/apache/cordova-lib/pull/91

    [CB-4731] avoid duplicates when merging arrays

    removes duplicate entries from arrays when modifying
    plist files

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gorkem/cordova-lib CB-4731

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit 61d940accb0a17ef5af656bba2fd6259f01e8306
Author: Gorkem Ercan <go...@gmail.com>
Date:   2014-09-24T18:01:53Z

    [CB-4731] avoid duplicates when merging arrays
    
    removes duplicate entries from arrays when modifying
    plist files

----


> Adding config entries in plugin.xml results in duplicate .plist entries
> -----------------------------------------------------------------------
>
>                 Key: CB-4731
>                 URL: https://issues.apache.org/jira/browse/CB-4731
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.0.0
>         Environment: macosx
>            Reporter: Tim Croydon
>            Assignee: Braden Shepherdson
>            Priority: Minor
>
> I have the following in the plugin.xml file for a custom plugin:
> {code}
> <platform name="ios">
>     <config-file target="*-Info.plist" parent="UIBackgroundModes">
>         <array>
>            <string>location</string>
>            <string>voip</string>
>         </array>
>     </config-file>        
> </platform>
> {code}
> However, this does not generate the expected entries in the .plist file. I get:
> {code}
> <key>UIBackgroundModes</key>
> <array>
>     <string>location</string>
>     <string>voip</string>
>     <string>location</string>
>     <string>voip</string>
> </array>
> {code}
> i.e. elements are repeated. I have tried with a single element in the source plugin.xml and get the same result.
> I am using the cordova CLI to manage my plugins, platforms and build.
> (p.s. I'm new to Cordova so apologies if this is filed under the incorrect component)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)